search for: use_bounce_buff

...stared at this patch for a while and I don't really understand it. One suggestion though. The patch might be better (or at least might be more obviously correct) if the function defined a boolean at the top which was used to tell if the bounce buffer was in use, something like: const bool use_bounce_buffer = /* condition */; if (use_bounce_buffer) { block = malloc (blksize); ... } r = blk_read (..., use_bounce_buffer ? block : buf, err); etc. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http:/...

Although the time spent in memcpy/memset probably pales in comparison to time spent in socket I/O, it's still worth worth reducing the number of times we have to utilize a bounce buffer when we already have aligned data. Signed-off-by: Eric Blake <eblake@redhat.com> --- filters/cache/cache.c | 60 ++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 21