search for: use_askpass

...flag set, and the only other way to get ssh_askpass() to get called is for open(_PATH_TTY, O_RDWR) to fail. But /dev/tty is a+rw in the normal case. >From readpass.c: char * read_passphrase(const char *prompt, int flags) { char *askpass = NULL, *ret, buf[1024]; int rppflags, use_askpass = 0, ttyfd; rppflags = (flags & RP_ECHO) ? RPP_ECHO_ON : RPP_ECHO_OFF; if (flags & RP_ALLOW_STDIN) { if (!isatty(STDIN_FILENO)) use_askpass = 1; } else { rppflags |= RPP_REQUIRE_TTY; ttyfd = ope...

...16/ssh.c openssh-1.2pre16.patched/ssh.c --- openssh-1.2pre16/ssh.c Thu Dec 9 22:29:24 1999 +++ openssh-1.2pre16.patched/ssh.c Thu Dec 9 23:03:19 1999 @@ -81,6 +81,9 @@ /* Original real UID. */ uid_t original_real_uid; +/* Flag indicating whether we should try to use ssh-askpass or not */ +int use_askpass = 0; + /* Prints a help message to the user. This function never returns. */ void @@ -430,10 +433,20 @@ /* Do not allocate a tty if stdin is not a tty. */ if (!isatty(fileno(stdin))) { + FILE *dummy; if (tty_flag) fprintf(stderr, "Pseudo-terminal will not be allocated becaus...

...dpass.c 3 Oct 2004 10:58:53 -0000 @@ -30,6 +30,9 @@ #include "pathnames.h" #include "log.h" #include "ssh.h" +#include "readconf.h" + +extern Options options; static char * ssh_askpass(char *askpass, const char *msg) @@ -103,7 +106,9 @@ int rppflags, use_askpass = 0, ttyfd; rppflags = (flags & RP_ECHO) ? RPP_ECHO_ON : RPP_ECHO_OFF; - if (flags & RP_USE_ASKPASS) + if (flags & RP_USE_ASKPASS || + (options.prefer_askpass && getenv(SSH_ASKPASS_ENV) && + !(flags & RP_ECHO))) use_askpass = 1; else if (flags & RP_...

...command-line CVS or SVN client, especially if the available GUI clients are broken or quirky. As a test of my proposal, I changed the readpass.c file in my copy of the source to look for an environment variable named "SSH_ASKPASS_IGNORETTY". If that environment variable is set, the use_askpass variable is set in the code. With that variable set (SSH_ASKPASS and DISPLAY are set appropriately, too), when I run a command-line CVS or SVN client against a repository through ssh on a server that requires passwords, the program I specified is started and supplies the password to ssh. Curr...

...--- my_openssh-3.7p1/readpass.c Fri Dec 19 09:46:44 2003 +++ openssh-3.7p1/readpass.c Thu Jan 23 16:36:23 2003 @@ -99,7 +99,7 @@ char * read_passphrase(const char *prompt, int flags) { - char *askpass = NULL, *ret, buf[1024], response; + char *askpass = NULL, *ret, buf[1024]; int rppflags, use_askpass = 0, ttyfd; rppflags = (flags & RP_ECHO) ? RPP_ECHO_ON : RPP_ECHO_OFF; @@ -126,60 +126,13 @@ return ret; } - /* Before reading the passphrase from the user, find it in the - keychain. */ -#ifdef USE_KEYCHAIN - if (get_passphrase_from_keychain(prompt, buf, sizeof buf) == 0...

...ot) was started from a connected terminal. I actually tested this just doing popen("ssh") from a test program and just starting it from the window manager menu) I guess the best way to fix that is to detect that condition in "readpass.c:read_passphrase()", and fallback to 'use_askpass'. However, I haven't found a way to do so :) poll() works fine, writing to the terminal doesn't rase TTOU immediately (yeah, how did read() trigger a TTOU ???) As a relief, I guess I'll restrict the readpassphrase to only restart limited amount of times (and prevent the lockout), a...

...openssh-5.6p1/readpass.c openssh-5.6p1-b/readpass.c --- openssh-5.6p1/readpass.c 2006-08-05 04:39:40.000000000 +0200 +++ openssh-5.6p1-b/readpass.c 2011-01-18 09:52:34.000000000 +0100 @@ -123,6 +123,7 @@ if (!isatty(STDIN_FILENO)) { debug("read_passphrase: stdin is not a tty"); use_askpass = 1; + rppflags |= RPP_STDIN; } } else { rppflags |= RPP_REQUIRE_TTY; Thanks Jean-Yves Faye

https://bugzilla.mindrot.org/show_bug.cgi?id=69 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |djm at mindrot.org Alias| |generalised-askpass -- Configure bugmail: