search for: usb_device_id

Arnaud, I have a question regarding the below structure you've added: > typedef struct usb_device_id_t { > int vendorID; > int productID; > void*(*fun)(); /* handler for specific processing */ > } usb_device_id; I don't understand the last element in this structure. While there can be plenty of reasons for functions returning (void *), I can't figure out what use this...

...-5480,6 +5482,8 @@ static void hub_event(struct work_struct *work) > /* Balance the stuff in kick_hub_wq() and allow autosuspend */ > usb_autopm_put_interface(intf); > kref_put(&hub->kref, hub_release); > + > + kcov_remote_stop(); > } > > static const struct usb_device_id hub_id_table[] = { > diff --git a/include/linux/kcov.h b/include/linux/kcov.h > index 702672d98d35..38a47e0b67c2 100644 > --- a/include/linux/kcov.h > +++ b/include/linux/kcov.h > @@ -30,6 +30,7 @@ void kcov_task_exit(struct task_struct *t); > /* > * Reserved handle ranges:...

Citeren Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Mon Nov 24 13:13:44 2008 > New Revision: 1578 > > Log: > Use new usb_device_id_t and is_usb_device_supported() > for selection of the subdriver. Alexander, It would be nice if you could double check that I didn't horribly break something here. I don't expect any surprises here, but one never knows. Best regards, Arjen -- Please keep list traffic on the list

...ost other bus types now, so you could turn > the question around. However, I don't think majority voting is a good > guide to best practise; lets debate the merits for their own sake. Not really "dwarf", USB is close with over 700 such structures: $ git grep "const struct usb_device_id" | wc -l 725 And i2c is almost just as big as PCI: $ git grep "const struct i2c_device_id" | wc -l 1223 So again, this macro is not consistent with the majority of PCI drivers, nor with any other type of "device id" declaration in the kernel, which is why I feel it should...

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const

We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const

...ance the stuff in kick_hub_wq() and allow autosuspend */ > > > usb_autopm_put_interface(intf); > > > kref_put(&hub->kref, hub_release); > > > + > > > + kcov_remote_stop(); > > > } > > > > > > static const struct usb_device_id hub_id_table[] = { > > > diff --git a/include/linux/kcov.h b/include/linux/kcov.h > > > index 702672d98d35..38a47e0b67c2 100644 > > > --- a/include/linux/kcov.h > > > +++ b/include/linux/kcov.h > > > @@ -30,6 +30,7 @@ void kcov_task_exit(struct task_stru...

...gt;> > the question around. However, I don't think majority voting is a good >> > guide to best practise; lets debate the merits for their own sake. >> >> Not really "dwarf", USB is close with over 700 such structures: >> $ git grep "const struct usb_device_id" | wc -l >> 725 >> >> And i2c is almost just as big as PCI: >> $ git grep "const struct i2c_device_id" | wc -l >> 1223 >> >> So again, this macro is not consistent with the majority of PCI drivers, >> nor with any other type of "de...

..._init(&rnet->lock); spin_lock_init(&rnet->tx_lock); diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 630caf4..8cfc3bb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id netdev->netdev_ops = &catc_netdev_ops; netdev->watchdog_timeo = TX_TIMEOUT; - SET_ETHTOOL_OPS(netdev, &ops); + netdev->ethtool_ops = &ops; catc->usbdev = usbdev; catc->netdev = netdev; diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 660bd5...

..._init(&rnet->lock); spin_lock_init(&rnet->tx_lock); diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 630caf4..8cfc3bb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id netdev->netdev_ops = &catc_netdev_ops; netdev->watchdog_timeo = TX_TIMEOUT; - SET_ETHTOOL_OPS(netdev, &ops); + netdev->ethtool_ops = &ops; catc->usbdev = usbdev; catc->netdev = netdev; diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 660bd5...

..._init(&rnet->lock); spin_lock_init(&rnet->tx_lock); diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 630caf4..8cfc3bb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id netdev->netdev_ops = &catc_netdev_ops; netdev->watchdog_timeo = TX_TIMEOUT; - SET_ETHTOOL_OPS(netdev, &ops); + netdev->ethtool_ops = &ops; catc->usbdev = usbdev; catc->netdev = netdev; diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 660bd5...

..._init(&rnet->lock); spin_lock_init(&rnet->tx_lock); diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 630caf4..8cfc3bb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id netdev->netdev_ops = &catc_netdev_ops; netdev->watchdog_timeo = TX_TIMEOUT; - SET_ETHTOOL_OPS(netdev, &ops); + netdev->ethtool_ops = &ops; catc->usbdev = usbdev; catc->netdev = netdev; diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 660bd5...

..._init(&rnet->lock); spin_lock_init(&rnet->tx_lock); diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 630caf4..8cfc3bb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id netdev->netdev_ops = &catc_netdev_ops; netdev->watchdog_timeo = TX_TIMEOUT; - SET_ETHTOOL_OPS(netdev, &ops); + netdev->ethtool_ops = &ops; catc->usbdev = usbdev; catc->netdev = netdev; diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 660bd5...

...spin_lock_init(&rnet->tx_lock); > diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c > index 630caf4..8cfc3bb 100644 > --- a/drivers/net/usb/catc.c > +++ b/drivers/net/usb/catc.c > @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id > > netdev->netdev_ops = &catc_netdev_ops; > netdev->watchdog_timeo = TX_TIMEOUT; > - SET_ETHTOOL_OPS(netdev, &ops); > + netdev->ethtool_ops = &ops; > > catc->usbdev = usbdev; > catc->netdev = netdev;...

...spin_lock_init(&rnet->tx_lock); > diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c > index 630caf4..8cfc3bb 100644 > --- a/drivers/net/usb/catc.c > +++ b/drivers/net/usb/catc.c > @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id > > netdev->netdev_ops = &catc_netdev_ops; > netdev->watchdog_timeo = TX_TIMEOUT; > - SET_ETHTOOL_OPS(netdev, &ops); > + netdev->ethtool_ops = &ops; > > catc->usbdev = usbdev; > catc->netdev = netdev;...

...spin_lock_init(&rnet->tx_lock); > diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c > index 630caf4..8cfc3bb 100644 > --- a/drivers/net/usb/catc.c > +++ b/drivers/net/usb/catc.c > @@ -793,7 +793,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id > > netdev->netdev_ops = &catc_netdev_ops; > netdev->watchdog_timeo = TX_TIMEOUT; > - SET_ETHTOOL_OPS(netdev, &ops); > + netdev->ethtool_ops = &ops; > > catc->usbdev = usbdev; > catc->netdev = netdev;...