search for: usagestr

...), + uuidstr, err->message); + virSecretFree (sec); + continue; + } + + virSecretFree (sec); + } else if (!xPathObjectIsEmpty (xpsecretusage)) { + virSecretUsageType usageType; + CLEANUP_FREE char *usagestr = NULL; + virSecretPtr sec; + + usagestr = xPathObjectGetString (doc, xpsecretusage); + debug (g, "disk[%zu]: secret type: %s; usage: %s", + i, typestr, usagestr); + if (STREQ (usagestr, "none")) + usageT...

Move the checks for empty xmlXPathObjectPtr, and for extracting the result string out of it, to a new helper functions. This is just code motion, there should be no behaviour changes. --- src/libvirt-domain.c | 122 +++++++++++++++++++++------------------------------ 1 file changed, 50 insertions(+), 72 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4d4142d..baab307

Hi gang, I was a little surprised to see that patch go by recently which fixed an endian bug. I went to see how sparse checking looked and it was.. broken. I got it going again in my Fedora environment. Most of the patches are just cleanups, but there *were* three real bugs lurking in all that sparse warning spam. So I maintain that it''s worth our time to keep it going and fix

...error (g, _("cannot get the value of the secret with UUID ‘%s’: %s"), uuidstr, err->message); virSecretFree (sec); continue; @@ -650,7 +650,7 @@ for_each_disk (guestfs_h *g, sec = virSecretLookupByUsage (conn, usageType, usagestr); if (sec == NULL) { err = virGetLastError (); - error (g, _("no secret for usage '%s': %s"), + error (g, _("no secret for usage ‘%s’: %s"), usagestr, err->message); continue;...