search for: uri_scheme

In previous discussion here: https://www.redhat.com/archives/libguestfs/2017-December/thread.html#00027 we preferred to use ssh://... URLs instead of server:/path. However the URL approach had the problem that the user had to replace spaces with %20 in the paths. However since using space gives an error, we can replace spaces with %20 safely in code, thus removing one obstacle from users.

On Friday, 8 December 2017 17:02:30 CET Richard W.M. Jones wrote: > This enhances the existing VMX input support allowing it to be > used over SSH to the ESXi server. > > The original command (for local .vmx files) was: > > $ virt-v2v -i vmx guest.vmx -o local -os /var/tmp > > Adding ‘-it ssh’ and using an SSH remote path gives the new syntax: > > $ virt-v2v \

...rse_uri arg - with Invalid_argument _ -> - error (f_"remote vmx ‘%s’ could not be parsed as a URI") arg in + try Xml.parse_nonstandard_uri uri + with exn -> + error (f_"could not parse URI: %s") (Printexc.to_string exn) in if uri.Xml.uri_scheme <> None && uri.Xml.uri_scheme <> Some "ssh" then error (f_"vmx URI start with ‘ssh://...’"); if uri.Xml.uri_server = None then diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index b2face339..4179245d6 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/vi...

The first four patches are straightforward. The final patch adds the -o rhv-upload output mode. It is still spooling into a temporary file because I've had some trouble getting streaming conversions working. There are other problems as outlined in the commit message, so this patch is not ready for upstream but is good for discussion. Also I hit this, which I'm assuming for now will be

...(* Ignore different architectures than the guest's. *) + if architecture <> arch then + false + else + try + (* Ignore invalid URLs, and non-file ones. *) + (match Xml.parse_uri location with + | { Xml.uri_scheme = Some scheme; + Xml.uri_path = Some _ } when scheme = "file" -> true + | _ -> false + ) + with Invalid_argument _ -> false + ) (os#get_device_drivers ()) in + let uri = Xml.parse_uri driver.Libosinfo.location in +...

...rse_uri arg - with Invalid_argument _ -> - error (f_"remote vmx ‘%s’ could not be parsed as a URI") arg in + try Xml.parse_nonstandard_uri uri + with exn -> + error (f_"could not parse URI: %s") (Printexc.to_string exn) in if uri.Xml.uri_scheme <> None && uri.Xml.uri_scheme <> Some "ssh" then error (f_"vmx URI start with ‘ssh://...’"); if uri.Xml.uri_server = None then diff --git a/v2v/virt-v2v-input-vmware.pod b/v2v/virt-v2v-input-vmware.pod index 636652e50..f73e1fb55 100644 --- a/v2v...

An alternate solution to: https://www.redhat.com/archives/libguestfs/2017-December/msg00035.html "[PATCH] v2v: -i vmx: Allow ssh URLs to use spaces." is to classify all URLs processed by libguestfs as either ordinary URLs or the special non-standard URLs that we use for things like ‘virt-v2v -i vmx’ and ‘guestfish --add’. For the non-standard URLs, provide a wrapper around

...t drivers = + List.filter ( + fun { Libosinfo.architecture; location; pre_installable } -> + if architecture <> arch || not pre_installable then + false + else + try + (match Xml.parse_uri location with + | { Xml.uri_scheme = Some scheme; + Xml.uri_path = Some _ } when scheme = "file" -> true + | _ -> false + ) + with Invalid_argument _ -> false + ) drivers in + (* Sort the drivers by priority, like libosinfo does. *) + let drivers = +...

..."] then ( + debug "rhv-upload: python binary: %s" python; + python + ) + else + loop rest + in + loop ["python3"; "python"] + +(* Parse the -oc URI. *) +let parse_output_conn oc = + let uri = Xml.parse_uri oc in + if uri.Xml.uri_scheme <> Some "https" then + error (f_"rhv-upload: -oc: URI must start with https://..."); + if uri.Xml.uri_server = None then + error (f_"rhv-upload: -oc: no remote server name in the URI"); + if uri.Xml.uri_path = None || uri.Xml.uri_path = Some "/"...

Previously posted: https://www.redhat.com/archives/libguestfs/2017-December/msg00046.html Rich.

...e +let set_prop (doc, node_ptr) = node_ptr_set_prop node_ptr external node_ptr_unlink_node : node_ptr -> unit = "v2v_xml_node_ptr_unlink_node" -let unlink_node (doc, node) = node_ptr_unlink_node node +let unlink_node (doc, node_ptr) = node_ptr_unlink_node node_ptr type uri = { - uri_scheme : string option; - uri_opaque : string option; - uri_authority : string option; - uri_server : string option; - uri_user : string option; - uri_port : int; - uri_path : string option; - uri_fragment : string option; - uri_query_raw : string option; -} + uri_scheme : string option; + u...

..."] then ( + debug "rhv-upload: python binary: %s" python; + python + ) + else + loop rest + in + loop ["python3"; "python"] + +(* Parse the -oc URI. *) +let parse_output_conn oc = + let uri = Xml.parse_uri oc in + if uri.Xml.uri_scheme <> Some "https" then + error (f_"rhv-upload: -oc: URI must start with https://..."); + if uri.Xml.uri_server = None then + error (f_"rhv-upload: -oc: no remote server name in the URI"); + if uri.Xml.uri_path = None || uri.Xml.uri_path = Some "/"...

This patch set is still for discussion only. See 3/3 for the current list of problems. However this will upload an image to an oVirt or RHV server, although you must have absolutely the latest snapshot version of 4.2 for it to work. Rich.

...binary: %s" python; > + python > + ) > + else > + loop rest > + in > + loop ["python3"; "python"] > + > +(* Parse the -oc URI. *) > +let parse_output_conn oc = > + let uri = Xml.parse_uri oc in > + if uri.Xml.uri_scheme <> Some "https" then > + error (f_"rhv-upload: -oc: URI must start with https://..."); > + if uri.Xml.uri_server = None then > + error (f_"rhv-upload: -oc: no remote server name in the URI"); > + if uri.Xml.uri_path = None || uri.Xml.uri_path...

Use -ip instead of --password-file, and various refactorings. It strikes me that we should probably deprecate and eventually remove virt-v2v-copy-to-local. With the introduction of the new SSH and VDDK transports, and with RHEL 5 Xen becoming more irrelevant, it's no longer needed. Rich.

v2 -> v3: - Lots of code cleanups. - Documentation. However this is still spooling the file into a temporary before the upload. It turns out that fixing this is going to require a small change to qemu. Rich.

This patch series integrates libosinfo in virt-v2v to get the list of files for Windows from libosinfo, if possible. The actual data is still from virtio-win, just unpacked. Pino Toscano (3): build: require libosinfo v2v: add a minimal libosinfo interface v2v: try to get windows driver files from libosinfo m4/guestfs-v2v.m4 | 3 + v2v/Makefile.am | 9 +-

...et_prop (doc_ptr, node_ptr) = node_ptr_set_prop node_ptr external node_ptr_unlink_node : node_ptr -> unit = "v2v_xml_node_ptr_unlink_node" -let unlink_node (doc, node) = node_ptr_unlink_node node +let unlink_node (doc_ptr, node_ptr) = node_ptr_unlink_node node_ptr type uri = { uri_scheme : string option; diff --git a/v2v/xml.mli b/v2v/xml.mli index 8029813..a3a9c01 100644 --- a/v2v/xml.mli +++ b/v2v/xml.mli @@ -40,7 +40,7 @@ val xpath_register_ns : xpathctx -> string -> string -> unit val xpathobj_nr_nodes : xpathobj -> int (** Get the number of nodes in the nodeset...

This patch series integrates libosinfo in virt-v2v to get the list of files for Windows from libosinfo, if possible. The actual data is still from virtio-win, just unpacked. Changes from v1: - adapt to use the priority in libosinfo 1.7.0+ - filter out non-pre-installable drivers - collect all the drivers matching the requirements, not just the first, sorting them by priority like libosinfo does

These patches add the --password-file parameter, allowing you to pass a single password via a file. https://bugzilla.redhat.com/show_bug.cgi?id=1158526 Rich.