search for: update_rating

https://bugs.freedesktop.org/show_bug.cgi?id=66022 Priority: medium Bug ID: 66022 Assignee: nouveau at lists.freedesktop.org Summary: pwm1[_enable] faults after hibernate/restore related to automatic (or otherwise) fan management QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

...iations. I know the point is to isolate the code being tested and remove external dependencies, but I''m not sure how to implement it. Can someone suggest how they would spec the code below: I have a Book model and Review model class Book < ActiveRecord::Base has_many :reviews def update_rating new_rating = 0.0 unless reviews.empty? reviews.each {|r| new_rating += r.rating} new_rating /= review.size end update_attribute(:rating, new_rating) end end The review class is just a standard model with a :rating attribute. Here''s the (empty) spec i came up...

On Wed, 3 Dec 2014 12:52:51 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > index 43b7e02..1e2a720 100644 > > --- a/hw/virtio/virtio-mmio.c > > +++ b/hw/virtio/virtio-mmio.c > > @@ -244,9 +244,13 @@ static

On Wed, 3 Dec 2014 12:52:51 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > index 43b7e02..1e2a720 100644 > > --- a/hw/virtio/virtio-mmio.c > > +++ b/hw/virtio/virtio-mmio.c > > @@ -244,9 +244,13 @@ static

On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 10:27:36 +0100 > Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > > > On Tue, 2 Dec 2014 21:03:45 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > >

On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 10:27:36 +0100 > Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > > > On Tue, 2 Dec 2014 21:03:45 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > >

On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 12:52:51 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > > index 43b7e02..1e2a720 100644 > > > ---

On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 12:52:51 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > > index 43b7e02..1e2a720 100644 > > > ---

From: poma <pomidorabelisima at gmail.com> Switch from "silly" S_* macros to "definitely more readable" octal "way" permissions, moreover to not "so restrictive" module parameters permissions. Suggested-by: Ilia Mirkin <imirkin at alum.mit.edu> Fixes: poma <pomidorabelisima at gmail.com> Tested-by: poma <pomidorabelisima at

https://bugs.freedesktop.org/show_bug.cgi?id=66177 Priority: medium Bug ID: 66177 Assignee: nouveau at lists.freedesktop.org Summary: pwm1 value not restored during hibernate/restore cycle in the event of manual fan management mode QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

This patch removes old code related to the old api and transforms the functions for the new api. It also adds the .write and .read operations. Signed-off-by: Oscar Salvador <osalvador.vilardaga at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 722 +++++++++++--------------------- 1 file changed, 249 insertions(+), 473 deletions(-) diff --git

Here is where most of the work is being done. We are replacing the old API with the new one, that means changing the functions layout and remove unnecessary code. We also set up the other operations: .read .write .read_string --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13 10:11:29.241000086 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-13 10:12:38.016055129

Hi, this patch replaces the old hwmon_device_register with the new hwmon_device_register_with_info. I've tested it on my laptop with a GeForceGT 425M and it doesn't break anything. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-11 18:27:15.477623009 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-11 18:45:41.918688215 +0200 @@ -1,5 +1,6 @@ /* - *

This v5 drops a check for attr_set. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in

Sorry for that. I'll split the patch and I'll come again ;) El dia 11/04/2017 22:12, "Karol Herbst" <karolherbst at gmail.com> va escriure: thanks for the work, but could you please split that patch? It looks like you are doing several things at once and it isn't really easy to review like this. And it isn't bisectable. If there are clean ups here, please do it

This v6 fixes some comments pointed out by Martin Peres. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for

Kbuild sent me an e-mail due to a fixup I introduced in v3. It complains due to an incompatible pointer type and it doesn't build. This version reverts it. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4:

Hi, this is version v3 with some fix-ups: Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here

This v8 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

This v7 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild