search for: update_r

https://bugs.freedesktop.org/show_bug.cgi?id=66022 Priority: medium Bug ID: 66022 Assignee: nouveau at lists.freedesktop.org Summary: pwm1[_enable] faults after hibernate/restore related to automatic (or otherwise) fan management QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

...iations. I know the point is to isolate the code being tested and remove external dependencies, but I''m not sure how to implement it. Can someone suggest how they would spec the code below: I have a Book model and Review model class Book < ActiveRecord::Base has_many :reviews def update_rating new_rating = 0.0 unless reviews.empty? reviews.each {|r| new_rating += r.rating} new_rating /= review.size end update_attribute(:rating, new_rating) end end The review class is just a standard model with a :rating attribute. Here''s the (empty) spec i ca...

...IO_MMIO_QUEUENUM: > > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > > virtio_queue_set_num(vdev, vdev->queue_sel, value); > > + /* Note: only call this function for legacy devices */ > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > + virtio_queue_update_rings(vdev, vd...

...IO_MMIO_QUEUENUM: > > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > > virtio_queue_set_num(vdev, vdev->queue_sel, value); > > + /* Note: only call this function for legacy devices */ > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > + virtio_queue_update_rings(vdev, vd...

...> case VIRTIO_MMIO_QUEUENUM: > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > virtio_queue_set_num(vdev, vdev->queue_sel, value); > + /* Note: only call this function for legacy devices */ > + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > + virtio_queue_update_rings(vdev, vdev->queue_sel); >...

...> case VIRTIO_MMIO_QUEUENUM: > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > virtio_queue_set_num(vdev, vdev->queue_sel, value); > + /* Note: only call this function for legacy devices */ > + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > + virtio_queue_update_rings(vdev, vdev->queue_sel); >...

...t; > > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > > > virtio_queue_set_num(vdev, vdev->queue_sel, value); > > > + /* Note: only call this function for legacy devices */ > > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > > break; > > > case VIRTIO_MMIO_QUEUEALIGN: > > > + /* Note: this is only valid for legacy devices */ > > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > > + virtio_qu...

...t; > > DPRINTF("mmio_queue write %d max %d\n", (int)value, VIRTQUEUE_MAX_SIZE); > > > virtio_queue_set_num(vdev, vdev->queue_sel, value); > > > + /* Note: only call this function for legacy devices */ > > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > > break; > > > case VIRTIO_MMIO_QUEUEALIGN: > > > + /* Note: this is only valid for legacy devices */ > > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > > + virtio_qu...

...static ssize_t nouveau_hwmon_show_name(struct device *dev, { return sprintf(buf, "nouveau\n"); } -static SENSOR_DEVICE_ATTR(name, S_IRUGO, nouveau_hwmon_show_name, NULL, 0); +static SENSOR_DEVICE_ATTR(name, 0444, nouveau_hwmon_show_name, NULL, 0); static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, struct device_attribute *attr, @@ -339,7 +339,7 @@ static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, { return sprintf(buf, "1000\n"); } -static SENSOR_DEVICE_ATTR(update_rate, S_IRUGO, +static SENSOR_DEVICE_ATTR(update_rate, 0444,...

...ass/hwmon/hwmon0/pwm1 pwm1=30 pwm1_enable=1 pwm1_max=100 pwm1_min=0 temp1_auto_point1_pwm=100 temp1_auto_point1_temp=90000 temp1_auto_point1_temp_hyst=3000 temp1_crit=115000 temp1_crit_hyst=2000 temp1_emergency=135000 temp1_emergency_hyst=5000 temp1_input=41000 temp1_max=95000 temp1_max_hyst=3000 update_rate=1000 and then do hibernate/restore, I get this: pwm1=100 pwm1_enable=1 pwm1_max=100 pwm1_min=0 temp1_auto_point1_pwm=100 temp1_auto_point1_temp=90000 temp1_auto_point1_temp_hyst=3000 temp1_crit=115000 temp1_crit_hyst=2000 temp1_emergency=135000 temp1_emergency_hyst=5000 temp1_input=37000 temp1...

...struct device_attribute *attr, - char *buf) -{ - return sprintf(buf, "nouveau\n"); + return therm->attr_get(therm, NVKM_THERM_ATTR_THRS_SHUTDOWN_HYST) * 1000; } -static SENSOR_DEVICE_ATTR(name, S_IRUGO, nouveau_hwmon_show_name, NULL, 0); -static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, - struct device_attribute *attr, - char *buf) +static int +nouveau_hwmon_show_update_rate(struct nouveau_drm *drm) { - return sprintf(buf, "1000\n"); + return 1000; } -static SENSOR_DEVICE_ATTR(update_rate, S_IRUGO, - nouveau_hwmon_show_upda...

...;nouveau\n"); + struct nvkm_therm *therm = nvxx_therm(&drm->client.device); + + return therm->attr_set(therm, NVKM_THERM_ATTR_THRS_SHUTDOWN_HYST, + val / 1000); } -static SENSOR_DEVICE_ATTR(name, S_IRUGO, nouveau_hwmon_show_name, NULL, 0); -static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, - struct device_attribute *attr, - char *buf) +static int +nouveau_hwmon_show_update_rate(struct nouveau_drm *drm) { - return sprintf(buf, "1000\n"); + return 1000; } -static SENSOR_DEVICE_ATTR(update_rate, S_IRUGO, - nouveau_hwmon_show_upda...

...au_hwmon_show_name(struct device *dev, - struct device_attribute *attr, - char *buf) -{ - return sprintf(buf, "nouveau\n"); + val / 1000); + return val; } -static SENSOR_DEVICE_ATTR(name, S_IRUGO, nouveau_hwmon_show_name, NULL, 0); -static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, - struct device_attribute *attr, - char *buf) +static int +nouveau_hwmon_show_update_rate(struct nouveau_drm *drm) { - return sprintf(buf, "1000\n"); + return 1000; } -static SENSOR_DEVICE_ATTR(update_rate, S_IRUGO, - nouveau_hwmon_show_upda...

This v5 drops a check for attr_set. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in

...char *buf) > -{ > - return sprintf(buf, "nouveau\n"); > + val / 1000); > + return val; > } > -static SENSOR_DEVICE_ATTR(name, S_IRUGO, nouveau_hwmon_show_name, NULL, 0); > > -static ssize_t nouveau_hwmon_show_update_rate(struct device *dev, > - struct device_attribute *attr, > - char *buf) > +static int > +nouveau_hwmon_show_update_rate(struct nouveau_drm *drm) > { > - return sprintf(buf, "1000\n"); > +...

This v6 fixes some comments pointed out by Martin Peres. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for

Kbuild sent me an e-mail due to a fixup I introduced in v3. It complains due to an incompatible pointer type and it doesn't build. This version reverts it. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4:

Hi, this is version v3 with some fix-ups: Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here

This v8 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

This v7 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild