search for: untemplate

...led with a > SmallString and then SmallString::str() is called, it returns "NaN\0". I > guess that this is not intended. Maybe it can be fixed by the simple patch > attached. Thanks for the diagnosis. Do you have a test case to go along with this? The simpler fix seems to be to untemplate this code & have "append" take a StringRef. We can just rely on the compiler to optimize away the strlen in StringRef's (const char*) ctor as we do across the rest of the codebase. That way this won't go awry if append is called with a large buffer or a string without a nul te...

Am 24.07.2012 18:50, schrieb David Blaikie: > Do you have a test case to go along with this? Unfortunately not. It just popped up as a result of a programming error made by me. > The simpler fix seems to be to untemplate this code& have "append" > take a StringRef. We can just rely on the compiler to optimize away > the strlen in StringRef's (const char*) ctor as we do across the rest > of the codebase. That way this won't go awry if append is called with > a large buffer or a str...

Hi @llvm, I stumbled over a strange behavior if a float containing a NaN is printed (e.g. in the clang rewriter). The local template method "append" in APFloat.cpp deduces the size from the char array, which for "NaN" is 4 (including the trailing zero). If APFloat::toString is called with a SmallString and then SmallString::str() is called, it returns "NaN\0". I

...y this so someone can add a MachineRegionInfo later? It would be useful for region based register allocation, etc. >> >> Thanks, >> >> Evan > > Hi Evan, > > ether did once a templated version and I would love to test and commit > it. I just wanted to import an untemplated version of the RegionInfo > pass first, as it was easier to review. > > @ether. Do you think you could port your templated version of the > RegionInfo pass to trunk? RegionInfo need PostDominatorTree and DominanceFrontier, do us have DominanceFrontier for MachineBB? > > Tobi >...