search for: unregister_chrdev

...ant zaptel.c:6396: warning: implicit declaration of function `rwlock_init' zaptel.c: In function `zt_cleanup': zaptel.c:6410: `KERN_INFO' undeclared (first use in this function) zaptel.c:6410: syntax error before string constant zaptel.c:6429: warning: implicit declaration of function `unregister_chrdev' zaptel.c: At top level: zaptel.c:6283: storage size of `zt_fops' isn't known /usr/include/linux/proc_fs.h:193: warning: `create_proc_read_entry' declared `static' but never defined make: *** [zaptel.o] Error 1 Any ideas what could be wrong? Thanks!

...stant zaptel.c:6134: warning: implicit declaration of function `rwlock_init' zaptel.c: In function `zt_cleanup': zaptel.c:6148: `KERN_INFO' undeclared (first use in this function) zaptel.c:6148: parse error before string constant zaptel.c:6167: warning: implicit declaration of function `unregister_chrdev' zaptel.c: At top level: zaptel.c:6021: storage size of `zt_fops' isn't known /usr/include/linux/proc_fs.h:193: warning: `create_proc_read_entry' declared `static' but never defined make: *** [zaptel.o] Error 1 I cannot modprobe wcfxo my card or even get this install to compl...

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console:

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console:

Hello, Here are two patches. One implements a virtio-serial device in qemu and the other is the driver for a guest kernel. While working on a vmchannel interface that is needed for communication between guest userspace and host userspace, I saw that most of the interface can be abstracted out as a "serial" device with "ports". Some requirements for a vmchannel are listed at

Hello, Here are two patches. One implements a virtio-serial device in qemu and the other is the driver for a guest kernel. While working on a vmchannel interface that is needed for communication between guest userspace and host userspace, I saw that most of the interface can be abstracted out as a "serial" device with "ports". Some requirements for a vmchannel are listed at

..., __func__, ret); + goto free_cdev; + } + INIT_LIST_HEAD(&port->readbuf_head); + init_waitqueue_head(&port->waitqueue); + + list_add_tail(&port->next, &virtserial.port_head); + + pr_info("virtio-serial port found at id %u\n", port_nr); + + return 0; +free_cdev: + unregister_chrdev(major, "virtio-serial"); + return ret; +} + +static u32 get_ports_map_size(u32 max_ports) +{ + return sizeof(u32) * ((max_ports + 31) / 32); +} + +static void virtio_serial_config_work_handler(struct work_struct *work) +{ + struct virtio_serial_config *virtserconf; + struct virtio_device...

..., __func__, ret); + goto free_cdev; + } + INIT_LIST_HEAD(&port->readbuf_head); + init_waitqueue_head(&port->waitqueue); + + list_add_tail(&port->next, &virtserial.port_head); + + pr_info("virtio-serial port found at id %u\n", port_nr); + + return 0; +free_cdev: + unregister_chrdev(major, "virtio-serial"); + return ret; +} + +static u32 get_ports_map_size(u32 max_ports) +{ + return sizeof(u32) * ((max_ports + 31) / 32); +} + +static void virtio_serial_config_work_handler(struct work_struct *work) +{ + struct virtio_serial_config *virtserconf; + struct virtio_device...

Hello, This is a new iteration of the patches that implement virtio-serial. Changes include: * Adding support for port hot-add * Creating ports at specific ids that can be bound to specific apps / usage * Cleanups This code still doesn't get rid of the support for assigning names to ports but it just has to be ripped out. Comments welcome. Thanks, Amit.

Hello, This is a new iteration of the patches that implement virtio-serial. Changes include: * Adding support for port hot-add * Creating ports at specific ids that can be bound to specific apps / usage * Cleanups This code still doesn't get rid of the support for assigning names to ports but it just has to be ripped out. Comments welcome. Thanks, Amit.

Hey Rusty, Here are a few fixes for virtio and virtio_console. The first patch ensures the data elements of vqs are properly initialised at allocation-time so that we don't trigger BUG_ONs. I found this when hot-unplugging ports and there was just one unused buffer. detach_unused_buffers() kept returning pointers that were invalid. I didn't catch this earlier as I had the in_vq filled

Hey Rusty, Here are a few fixes for virtio and virtio_console. The first patch ensures the data elements of vqs are properly initialised at allocation-time so that we don't trigger BUG_ONs. I found this when hot-unplugging ports and there was just one unused buffer. detach_unused_buffers() kept returning pointers that were invalid. I didn't catch this earlier as I had the in_vq filled

...lass_create(THIS_MODULE, "viotest"); + if (IS_ERR(viotest_class)) { + err = PTR_ERR(viotest_class); + goto failed_viotest; + } + + err = register_virtio_driver(&virtio_test); + if (err) { + class_destroy(viotest_class); + goto failed_viotest; + } + + return 0; + +failed_viotest: + unregister_chrdev(viotest_major, "virtio_test"); +out: + return err ? err : viotest_major; +} + +static void __exit fini(void) +{ + unregister_virtio_driver(&virtio_test); + class_destroy(viotest_class); + unregister_chrdev(viotest_major, "virtio_test"); +} + +module_init(init); +module_exit(...

...lass_create(THIS_MODULE, "viotest"); + if (IS_ERR(viotest_class)) { + err = PTR_ERR(viotest_class); + goto failed_viotest; + } + + err = register_virtio_driver(&virtio_test); + if (err) { + class_destroy(viotest_class); + goto failed_viotest; + } + + return 0; + +failed_viotest: + unregister_chrdev(viotest_major, "virtio_test"); +out: + return err ? err : viotest_major; +} + +static void __exit fini(void) +{ + unregister_virtio_driver(&virtio_test); + class_destroy(viotest_class); + unregister_chrdev(viotest_major, "virtio_test"); +} + +module_init(init); +module_exit(...

Hello all, This are the latest version of the patches. Lots of things have changed since the last submission. A few of which I remember: - VNC copy / paste works* (* conditions apply) - client vnc copies get propagated to guest port 3 (/dev/vmch3) - guest writes to port 3 (/dev/vmch3) go straight to client's clipboard - sysfs hooks to autodiscover ports - support for 64 ports in this

Hello all, This are the latest version of the patches. Lots of things have changed since the last submission. A few of which I remember: - VNC copy / paste works* (* conditions apply) - client vnc copies get propagated to guest port 3 (/dev/vmch3) - guest writes to port 3 (/dev/vmch3) go straight to client's clipboard - sysfs hooks to autodiscover ports - support for 64 ports in this

Hello, This is the patch that I have for adding support for multiple ports to virtio_console. It's pretty stable in my testing so far and the memory corruption that I had earlier has been resolved in linux-next so I'm proposing this for inclusion. This currently uses device major number 60 from the experimental range; Alan could you please reserve a new major number for virtio_console?

Hello, This is the patch that I have for adding support for multiple ports to virtio_console. It's pretty stable in my testing so far and the memory corruption that I had earlier has been resolved in linux-next so I'm proposing this for inclusion. This currently uses device major number 60 from the experimental range; Alan could you please reserve a new major number for virtio_console?