search for: unncessary

> BTW, adding explicit library dependencies will make the parallel builds > worse, because you know when a dependency is missing (the build fails) > but you don't know when a dependency is superfluous. Computing the dependencies creates a point in the build that depends on all libraries and all tools depend on it. The explicit dependencies would have to be in a really bad state to

...ies may affect almost all points. Second: if that is a problem, we can get rid of it by changing a single line [1]. IIRC, it is a remains of the implementation as it was when first created, when the dependencies were automatically generated and the build re-started in case of any change. Now it is unncessary. [1] I'm talking about the state of the cmake build as it was when I left. Maybe it was already removed.

remove load_cr3() from manage.c. It is unncessary and x86 dependent. Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp> --- drivers/xen/manage.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c index 2bb268e..e8db90c 100644 --- a/drivers/xen/manage.c +++ b/drivers/...

...utes) when it was trying to connect to the NUT daemon on the down > remote host... It eventually gave up - but since the 2 minute timeout was > pretty long - it also marked all other UPSes it was monitoring as "down" > (and then immediately "up" again). Causing a lot of unncessary > false alarms... Solved with a set_alarm()/clear_alarm() wrapper around the > upscl_connect() call. > thanks for your patch. I've got to check it more thoroughly, but it will at least need some rework. as an example, the "signal(SIGCHLD, SIG_IGN)" should be in "setup_s...

...t addr) > > -{ > > - if (!vring_use_dma_api(vq->vq.vdev)) > > - return 0; > > - > > - return dma_mapping_error(vring_dma_dev(vq), addr); > > -} > > It looks to me if you keep vring_mapping_error behind > vring_unmap_one_split(), lots of changes were unncessary. > [...] > > + } > > + /* That should have freed everything. */ > > + BUG_ON(vq->vq.num_free != vq->vring.num); > > + > > + END_USE(vq); > > + return NULL; > > +} > > I think the those copy-and-paste hunks could be avoided and the diff shou...

...ing_virtqueue *vq, > - dma_addr_t addr) > -{ > - if (!vring_use_dma_api(vq->vq.vdev)) > - return 0; > - > - return dma_mapping_error(vring_dma_dev(vq), addr); > -} It looks to me if you keep vring_mapping_error behind vring_unmap_one_split(), lots of changes were unncessary. > - > -static struct vring_desc *alloc_indirect(struct virtqueue *_vq, > - unsigned int total_sg, gfp_t gfp) > +static struct vring_desc *alloc_indirect_split(struct virtqueue *_vq, > + unsigned int total_sg, > + gfp_t gfp) > { > struct vrin...

...ing_virtqueue *vq, > - dma_addr_t addr) > -{ > - if (!vring_use_dma_api(vq->vq.vdev)) > - return 0; > - > - return dma_mapping_error(vring_dma_dev(vq), addr); > -} It looks to me if you keep vring_mapping_error behind vring_unmap_one_split(), lots of changes were unncessary. > - > -static struct vring_desc *alloc_indirect(struct virtqueue *_vq, > - unsigned int total_sg, gfp_t gfp) > +static struct vring_desc *alloc_indirect_split(struct virtqueue *_vq, > + unsigned int total_sg, > + gfp_t gfp) > { > struct vrin...

I just did a clean install of Fedora 9 onto a Pentium 4 machine. It is actually running SELinux enforcing, but I haven't found any errors related to that so far. It is running Samba 3.2.3-0.20. I am trying to migrate a Windows NT 4.0 domain with about 30 users and 30 computers onto a pure Samba setup, using Samba as the PDC and tdbsam. I have read the HOWTO guide extensively, and

...MB + * [L] pn->locked [RmW] pn->state = vcpu_running + * + * Matches the xchg() from pv_kick_node(). + */ + (void)xchg(&pn->state, vcpu_halted); + + if (!READ_ONCE(node->locked)) + pv_wait(&pn->state, vcpu_halted); + + /* + * Reset the vCPU state to avoid unncessary CPU kicking + */ + WRITE_ONCE(pn->state, vcpu_running); + + /* + * If the locked flag is still not set after wakeup, it is a + * spurious wakeup and the vCPU should wait again. However, + * there is a pretty high overhead for CPU halting and kicking. + * So it is better to spin for a...

...MB + * [L] pn->locked [RmW] pn->state = vcpu_running + * + * Matches the xchg() from pv_kick_node(). + */ + (void)xchg(&pn->state, vcpu_halted); + + if (!READ_ONCE(node->locked)) + pv_wait(&pn->state, vcpu_halted); + + /* + * Reset the vCPU state to avoid unncessary CPU kicking + */ + WRITE_ONCE(pn->state, vcpu_running); + + /* + * If the locked flag is still not set after wakeup, it is a + * spurious wakeup and the vCPU should wait again. However, + * there is a pretty high overhead for CPU halting and kicking. + * So it is better to spin for a...

...MB + * [L] pn->locked [RmW] pn->state = vcpu_running + * + * Matches the xchg() from pv_kick_node(). + */ + (void)xchg(&pn->state, vcpu_halted); + + if (!READ_ONCE(node->locked)) + pv_wait(&pn->state, vcpu_halted); + + /* + * Reset the vCPU state to avoid unncessary CPU kicking + */ + WRITE_ONCE(pn->state, vcpu_running); + + /* + * If the locked flag is still not set after wakeup, it is a + * spurious wakeup and the vCPU should wait again. However, + * there is a pretty high overhead for CPU halting and kicking. + * So it is better to spin for a...

Hi everyone! I''m planning to migrate a little firm''s Windows server to a HVM machine. The test setup woks fine (it''s basically an MSSQL server tied pack of programs for an accountancy office), all programs can reach the mssql from the outside on the hvm windows. If fact it turned out to be so good, that I''m even planning to simply copy the win image(s) to the

On Tue, Mar 22, 2016 at 11:55:45PM +0900, Minchan Kim wrote: > On Tue, Mar 22, 2016 at 02:50:37PM +0900, Joonsoo Kim wrote: > > On Mon, Mar 21, 2016 at 03:31:02PM +0900, Minchan Kim wrote: > > > We have allowed migration for only LRU pages until now and it was > > > enough to make high-order pages. But recently, embedded system(e.g., > > > webOS, android) uses

On Tue, Mar 22, 2016 at 11:55:45PM +0900, Minchan Kim wrote: > On Tue, Mar 22, 2016 at 02:50:37PM +0900, Joonsoo Kim wrote: > > On Mon, Mar 21, 2016 at 03:31:02PM +0900, Minchan Kim wrote: > > > We have allowed migration for only LRU pages until now and it was > > > enough to make high-order pages. But recently, embedded system(e.g., > > > webOS, android) uses

v15->v16: - Remove the lfsr patch and use linear probing as lfsr is not really necessary in most cases. - Move the paravirt PV_CALLEE_SAVE_REGS_THUNK code to an asm header. - Add a patch to collect PV qspinlock statistics which also supersedes the PV lock hash debug patch. - Add PV qspinlock performance numbers. v14->v15: - Incorporate PeterZ's v15 qspinlock patch and improve

v15->v16: - Remove the lfsr patch and use linear probing as lfsr is not really necessary in most cases. - Move the paravirt PV_CALLEE_SAVE_REGS_THUNK code to an asm header. - Add a patch to collect PV qspinlock statistics which also supersedes the PV lock hash debug patch. - Add PV qspinlock performance numbers. v14->v15: - Incorporate PeterZ's v15 qspinlock patch and improve

Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost (RFC v4): https://lkml.org/lkml/2018/5/16/501 Both of ping and netperf worked as expected w/ EVENT_IDX disabled. Ping worked as expected w/ EVENT_IDX enabled, but netperf didn't (A hack has been added in the driver to

Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost (RFC v4): https://lkml.org/lkml/2018/5/16/501 Both of ping and netperf worked as expected w/ EVENT_IDX disabled. Ping worked as expected w/ EVENT_IDX enabled, but netperf didn't (A hack has been added in the driver to