search for: unlock_pag

Hello. That's what I've got from ld: /usr/lib/libxenguest.a(xg_private.o): In function `unlock_pages': (.text+0x490): multiple definition of `unlock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.text+0x6a0): first defined here /usr/lib/libxenguest.a(xg_private.o): In function `lock_pages': (.text+0x4d0): multiple definition of `lock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.tex...

Currently ocfs2_start_trans/ocfs2_commit_trans are in lock_page/unlock_page. This may cause dead lock. Here is the situation: write -> lock_page -> ocfs2_start_trans -> ocfs2_commit_trans -> unlock_page ocfs2_start_trans/ocfs2_commit_trans calls jbd2_journal_start/jbd2_journal_stop which may also call lock_page. So if the page operated is unfortunately the sa...

fix lock_pages()/unlock_pages(). The resion is sometimes wrongly calculated. It results in unexpected hypercall failure. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel

...ly one > + * holding a reference to the 'page' at this point. If we are not, then > + * memory corruption is possible and we should stop execution. > + */ > + BUG_ON(!trylock_page(page)); > + list_del(&page->lru); > + balloon_page_insert(b_dev_info, page); > + unlock_page(page); > + __count_vm_event(BALLOON_INFLATE); > +} > + > +/** > + * balloon_page_list_enqueue() - inserts a list of pages into the balloon page > + * list. > + * @b_dev_info: balloon device descriptor where we will insert a new page to > + * @pages: pages to enqueue - a...

...nal references. We should be the only one + * holding a reference to the 'page' at this point. If we are not, then + * memory corruption is possible and we should stop execution. + */ + BUG_ON(!trylock_page(page)); + list_del(&page->lru); + balloon_page_insert(b_dev_info, page); + unlock_page(page); + __count_vm_event(BALLOON_INFLATE); +} + +/** + * balloon_page_list_enqueue() - inserts a list of pages into the balloon page + * list. + * @b_dev_info: balloon device descriptor where we will insert a new page to + * @pages: pages to enqueue - allocated using balloon_page_alloc. + * +...

...nal references. We should be the only one + * holding a reference to the 'page' at this point. If we are not, then + * memory corruption is possible and we should stop execution. + */ + BUG_ON(!trylock_page(page)); + list_del(&page->lru); + balloon_page_insert(b_dev_info, page); + unlock_page(page); + __count_vm_event(BALLOON_INFLATE); +} + +/** + * balloon_page_list_enqueue() - inserts a list of pages into the balloon page + * list. + * @b_dev_info: balloon device descriptor where we will insert a new page to + * @pages: pages to enqueue - allocated using balloon_page_alloc. + * +...

...lding a reference to the 'page' at this point. > + */ > + if (!trylock_page(page)) { > + WARN_ONCE(1, "balloon inflation failed to enqueue page\n"); > + return -EFAULT; > + } > + list_del(&page->lru); > + balloon_page_insert(b_dev_info, page); > + unlock_page(page); > + __count_vm_event(BALLOON_INFLATE); > + return 0; > +} > + > +/** > + * balloon_page_list_enqueue() - inserts a list of pages into the balloon page > + * list. > + * @b_dev_info: balloon device descriptor where we will insert a new page to > + * @pages: pag...

...{ > + WARN_ONCE(1, "balloon inflation failed to enqueue page\n"); > + return -EFAULT; Looks like all callers bug on a failure. So let's just do it here, and then make this void? > + } > + list_del(&page->lru); > + balloon_page_insert(b_dev_info, page); > + unlock_page(page); > + __count_vm_event(BALLOON_INFLATE); > + return 0; > +} > + > +/** > + * balloon_page_list_enqueue() - inserts a list of pages into the balloon page > + * list. > + * @b_dev_info: balloon device descriptor where we will insert a new page to > + * @pages: pag...

Hi all, this series removes most users of the write_one_page API. These helpers internally call ->writepage which we are gradually removing from the kernel. Changes since v2: - more minix error handling fixes Changes since v1: - drop the btrfs changes (queue up in the btrfs tree) - drop the finaly move to jfs (can't be done without the btrfs patches) - fix the existing minix code to

...le definition of `lock_pages'' /usr/lib/gcc/x86_64-linux-gnu/4.2.3/../../../../lib/libxenguest.a(xg_private.o):/home/sthibault/xen-unstable-stubdom.hg/tools/libxc/xg_private.c:15: first defined here /usr/lib/gcc/x86_64-linux-gnu/4.2.3/../../../../lib/libxenctrl.a(xc_private.o): In function `unlock_pages'': /home/sthibault/xen-unstable-stubdom.hg/tools/libxc/xc_private.c:142: multiple definition of `unlock_pages'' /usr/lib/gcc/x86_64-linux-gnu/4.2.3/../../../../lib/libxenguest.a(xg_private.o):/home/sthibault/xen-unstable-stubdom.hg/tools/libxc/xg_private.c:24: first defined here...

...lloon_dev_info *b_dev_info) > continue; > } > #endif > - spin_lock_irqsave(&b_dev_info->pages_lock, flags); > balloon_page_delete(page); > __count_vm_event(BALLOON_DEFLATE); > - spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > unlock_page(page); > dequeued_page = true; > break; > } > } > + spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > if (!dequeued_page) { > /* I think this will cause deadlocks. pages_lock now nests within page lock, balloon_page_putback nests them...

...lloon_dev_info *b_dev_info) > continue; > } > #endif > - spin_lock_irqsave(&b_dev_info->pages_lock, flags); > balloon_page_delete(page); > __count_vm_event(BALLOON_DEFLATE); > - spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > unlock_page(page); > dequeued_page = true; > break; > } > } > + spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > if (!dequeued_page) { > /* I think this will cause deadlocks. pages_lock now nests within page lock, balloon_page_putback nests them...

From: Gioh Kim <gurugio at hanmail.net> Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes even order-3 page allocation failed. It has memory size 512MB ~ 1024MB. 30% ~ 40% memory is consumed for graphic processing and 20~30 memory is reserved for

From: Gioh Kim <gurugio at hanmail.net> Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes even order-3 page allocation failed. It has memory size 512MB ~ 1024MB. 30% ~ 40% memory is consumed for graphic processing and 20~30 memory is reserved for

Hi Minchan, [auto build test WARNING on next-20160318] [cannot apply to v4.5-rc7 v4.5-rc6 v4.5-rc5 v4.5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Minchan-Kim/Support-non-lru-page-migration/20160321-143339 coccinelle warnings: (new ones prefixed by >>) >>

Hi Minchan, [auto build test WARNING on next-20160318] [cannot apply to v4.5-rc7 v4.5-rc6 v4.5-rc5 v4.5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Minchan-Kim/Support-non-lru-page-migration/20160321-143339 coccinelle warnings: (new ones prefixed by >>) >>

...p;& > + page->mapping->a_ops->isolatepage) { > + ret = page->mapping->a_ops->isolatepage(page, > + mode); > + unlock_page(page); > + return ret; > + } > + unlock_page(page); > + } > + put_page(page); > + } > + return false; > +} > + > +static inline void putback_mobilepage(st...

...p;& > + page->mapping->a_ops->isolatepage) { > + ret = page->mapping->a_ops->isolatepage(page, > + mode); > + unlock_page(page); > + return ret; > + } > + unlock_page(page); > + } > + put_page(page); > + } > + return false; > +} > + > +static inline void putback_mobilepage(st...

...gt; > > #endif > > > - spin_lock_irqsave(&b_dev_info->pages_lock, flags); > > > balloon_page_delete(page); > > > __count_vm_event(BALLOON_DEFLATE); > > > - spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > > unlock_page(page); > > > dequeued_page = true; > > > break; > > > } > > > } > > > + spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > > > > > if (!dequeued_page) { > > > /* > > > > I think...

...gt; > > #endif > > > - spin_lock_irqsave(&b_dev_info->pages_lock, flags); > > > balloon_page_delete(page); > > > __count_vm_event(BALLOON_DEFLATE); > > > - spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > > unlock_page(page); > > > dequeued_page = true; > > > break; > > > } > > > } > > > + spin_unlock_irqrestore(&b_dev_info->pages_lock, flags); > > > > > > if (!dequeued_page) { > > > /* > > > > I think...