search for: uniontype

On Jan 6, 2010, at 12:45 PM, Talin wrote: > This patch adds a UnionType to DerivedTypes.h. Cool. When proposing an IR extension, it is usually best to start with a LangRef.html patch so that we can discuss the semantics of the extension. Please do write this before you get much farther. I assume that you want unions usable in the same situations as a struct. Howev...

This patch adds a UnionType to DerivedTypes.h. It also adds code to the bitcode reader / writer and the assembly parser for the new type, as well as a tiny .ll test file in test/Assembler. It does not contain any code related to code generation or type layout - I wanted to see if this much was acceptable before I proceeded an...

...g..) ===================================================== #include <stdio.h> struct MyString { char *chars; int length; }; struct LongestMember { char *chars; char charlength; int empty1; int empty2; }; typedef union { MyString string; LongestMember mt; } UnionType; int main() { UnionType original; UnionType *pointerToUnion; UnionType buffer; pointerToUnion = &buffer; original.string.chars = "mystring"; original.string.length = 8000; *pointerToUnion = original; printf("from pointerToUnion: chars %s, len...

...// expressions. You have a couple of these things which revert a recent patch, please don't :) Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and implementation missing :) In UnionValType methods, please use "UT" instead of "ST" as an acronym. +bool UnionType::isValidElementType(const Type *ElemTy) { + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != LabelTyID && + ElemTy->getTypeID() != MetadataTyID && ! isa<FunctionType>(ElemTy); +} Please use "!ElemTy->isVoidTy()" etc....

...bid this? As far as constants go, as long as the initializer is an exact match for one of the member types, it should be no problem. On Fri, Jan 8, 2010 at 11:00 PM, Chris Lattner <clattner at apple.com> wrote: > > On Jan 6, 2010, at 12:45 PM, Talin wrote: > > This patch adds a UnionType to DerivedTypes.h. > > > Cool. When proposing an IR extension, it is usually best to start with a > LangRef.html patch so that we can discuss the semantics of the extension. > Please do write this before you get much farther. I assume that you want > unions usable in the same s...

...these things which revert a recent patch, please don't > :) > > > Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and > implementation missing :) > > In UnionValType methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!Elem...

...Vector::get(&NewOps[0], NewOps.size()); } else { @@ -1015,6 +1017,11 @@ Elts.push_back(ValueList.getConstantFwdRef(Record[i], STy->getElementType(i))); V = ConstantStruct::get(STy, Elts); + } else if (const UnionType *UnTy = dyn_cast<UnionType>(CurTy)) { + uint64_t Index = Record[0]; + Constant *Val = ValueList.getConstantFwdRef(Record[1], + UnTy->getElementType(Index)); + V = ConstantUnion::get(UnTy, Val); } else if (const ArrayType *A...

Hello, I noticed a bit of a gap in the current code for unions: a ConstantUnion cannot be written out to .ll. Hopefully I'm not stepping on Talin's toes by posting this, it's a fairly straightforward adaptation of the code for structs just above. Tim. -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. --------------

...patch, please >> don't :) >> >> >> Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and >> implementation missing :) >> >> In UnionValType methods, please use "UT" instead of "ST" as an acronym. >> >> +bool UnionType::isValidElementType(const Type *ElemTy) { >> + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != >> LabelTyID && >> + ElemTy->getTypeID() != MetadataTyID && >> !isa<FunctionType>(ElemTy); >> +} >> &gt...

...these things which revert a recent patch, please don't > :) > > > Funky indentation in ConstantUnion::replaceUsesOfWithOnConstant and > implementation missing :) > > In UnionValType methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!Elem...

...39;t. There are a couple instances of this. +void ConstantUnion::replaceUsesOfWithOnConstant(Value *From, Value *To, + Use *U) { + assert(false && "Implement replaceUsesOfWithOnConstant for unions"); +} + Still not implemented? +UnionType *UnionType::get(const Type *type, ...) { + va_list ap; + std::vector<const llvm::Type*> UnionFields; + va_start(ap, type); Please use smallvector. +bool UnionType::isValidElementType(const Type *ElemTy) { + return !ElemTy->isVoidTy() && !ElemTy->isLabelTy() && +...

OK here's the patch for real this time :) On Fri, Jan 15, 2010 at 4:36 PM, Talin <viridia at gmail.com> wrote: > Here's a work in progress of the union patch. Note that the test "union.ll" > does not work, so you probably don't want to check this in as is. However, > I'd be interested in any feedback you're willing to give. > > -- > -- Talin

...ctionality up to the DAG building stage. I am not sure if this would work so perhaps I could get some opinions. My thoughts were as follows- introduce a new CompositeType called union (possibly refactoring some stuff into a common parent class from StructType). Recycle GEP (using RTTI) to handle UnionType field lookups as well. Add type codes into bitreader/bitwriter which would cope with the new union type. Add u { ... } into the AsmParser. Revise some of the target classes to cope with the unusual data layout and report back correct size for the union type. Add support for DAG generation into the...

Here's a work in progress of the union patch. Note that the test "union.ll" does not work, so you probably don't want to check this in as is. However, I'd be interested in any feedback you're willing to give. -- -- Talin -------------- next part -------------- An HTML attachment was scrubbed... URL:

...re if this would work so perhaps I could > get some opinions. > > > > My thoughts were as follows- introduce a new > CompositeType called union (possibly refactoring some stuff > into a common parent class from StructType). > > > > Recycle GEP (using RTTI) to handle UnionType field > lookups as well. Add type codes into bitreader/bitwriter > which would cope with the new union type. Add u { ... } into > the AsmParser. > > > > Revise some of the target classes to cope with the > unusual data layout and report back correct size for the > union t...

...-as: Constants.cpp:67: static llvm::Constant* llvm::Constant::getNullValue(const llvm::Type*): Assertion `!"Cannot create a null constant of that type!"' failed. The comment just above that line is: default: // Function, Label, or Opaque type? Which implies no one was expecting a UnionType there... Also, if I generate the object code directly, llc fails too... Is there any plan to implement the union type? The work-around is quite ugly... cheers, --renato http://systemcall.org/ [1] http://llvm.org/docs/LangRef.html#t_union

...the DAG building stage. I am not sure if this would work so perhaps I could get some opinions. > > My thoughts were as follows- introduce a new CompositeType called union (possibly refactoring some stuff into a common parent class from StructType). > > Recycle GEP (using RTTI) to handle UnionType field lookups as well. Add type codes into bitreader/bitwriter which would cope with the new union type. Add u { ... } into the AsmParser. > > Revise some of the target classes to cope with the unusual data layout and report back correct size for the union type. Add support for DAG generation...

...haps I could >> get some opinions. >> > >> > My thoughts were as follows- introduce a new >> CompositeType called union (possibly refactoring some stuff >> into a common parent class from StructType). >> > >> > Recycle GEP (using RTTI) to handle UnionType field >> lookups as well. Add type codes into bitreader/bitwriter >> which would cope with the new union type. Add u { ... } into >> the AsmParser. >> > >> > Revise some of the target classes to cope with the >> unusual data layout and report back correct s...

On Mon, Mar 29, 2010 at 01:15:30PM +0100, Renato Golin wrote: > Hi All, > > Which implies no one was expecting a UnionType there... > > Also, if I generate the object code directly, llc fails too... > > Is there any plan to implement the union type? The work-around is quite ugly... Sorry to Renato for getting two copeis of this, I cocked up the reply first time. Anyway, here's a patch for this issue...

...m, Value *To, > + Use *U) { > + assert(false && "Implement replaceUsesOfWithOnConstant for unions"); > +} > + > > Still not implemented? > > Not in this patch - as you say, it's too large already. > +UnionType *UnionType::get(const Type *type, ...) { > + va_list ap; > + std::vector<const llvm::Type*> UnionFields; > + va_start(ap, type); > > Please use smallvector. > Done - although I was just copying from what Struct does. > > +bool UnionType::isValidElementType(const T...