search for: unconditin

On Sun, 12 Apr 2015 17:00:48 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > likely define an incompatible interface with a different ID and > different semantics. But for now, it's not a big effort to support a > transitional balloon device: this has the advantage of

On Sun, 12 Apr 2015 17:00:48 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > likely define an incompatible interface with a different ID and > different semantics. But for now, it's not a big effort to support a > transitional balloon device: this has the advantage of

...point is to avoid setting bad precedent for virtio 1 devices. It does have a bit of cost for transitional devices. > Without that, you wouldn't need the above change at all, > would you? I think so, yes. BTW I suspect the stats code is broken for cross-endian platforms: it should do LE unconditinally, should it not? > Also, doesn't get_features need to be modified as well so that > VERSION_1 is advertised? virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. -- MST