Displaying 5 results from an estimated 5 matches for "uncommented_definit".
2016 Dec 01
1
[PATCH v4 1/1] crypto: add virtio-crypto driver
...on.
Looks like a bug in checkpatch.pl:
# check for spinlock_t definitions without a comment.
if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
$line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
my $which = $1;
if (!ctx_has_comment($first_line, $linenr)) {
CHK("UNCOMMENTED_DEFINITION",
"$1 definition without comment\n" . $herecurr);
}
}
Since your mutex definition has the 'static' keyword in front of it
checkpatch.pl misses it!
Andy: Is this checkpatch.pl behavior intentional?
Stefan
-------------- next part -------------...
2016 Dec 01
1
[PATCH v4 1/1] crypto: add virtio-crypto driver
...on.
Looks like a bug in checkpatch.pl:
# check for spinlock_t definitions without a comment.
if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
$line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
my $which = $1;
if (!ctx_has_comment($first_line, $linenr)) {
CHK("UNCOMMENTED_DEFINITION",
"$1 definition without comment\n" . $herecurr);
}
}
Since your mutex definition has the 'static' keyword in front of it
checkpatch.pl misses it!
Andy: Is this checkpatch.pl behavior intentional?
Stefan
-------------- next part -------------...
2020 Aug 18
0
[PATCH v6 0/3] Support virtio cross-device resources
...const struct virtio_dma_buf_ops *ops = container_of(
total: 0 errors, 1 warnings, 7 checks, 144 lines checked
76c9c2abbe6b virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature
9c3f3edd1cc4 (HEAD -> drm-qemu-next, kraxel.org/drm-qemu-next) drm/virtio: Support virtgpu exported resources
-:53: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#53: FILE: drivers/gpu/drm/virtio/virtgpu_drv.h:222:
+ spinlock_t resource_export_lock;
-:250: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#250: FILE: drivers/gpu/drm/virtio/virtgpu_vq.c:1118:
+ uint32_t resp_type =...
2016 Nov 30
3
[PATCH v4 1/1] crypto: add virtio-crypto driver
On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c
> new file mode 100644
> index 0000000..08b077f
> --- /dev/null
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -0,0 +1,518 @@
> + /* Algorithms supported by virtio crypto device
> + *
> + * Authors:
2016 Nov 30
3
[PATCH v4 1/1] crypto: add virtio-crypto driver
On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c
> new file mode 100644
> index 0000000..08b077f
> --- /dev/null
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -0,0 +1,518 @@
> + /* Algorithms supported by virtio crypto device
> + *
> + * Authors: