search for: umount_all

umount_all() and shutdown() are performed by guestfs automatically on close(), so drop explicit calls to them right before close(). Also umount_all() in the middle of processing doesn't look justified so drop it, too. (The only step following it is do_fstrim() which does mounting/umounting on its own)....

...tfs: trace: set_autosync true libguestfs: trace: set_autosync = 0 libguestfs: trace: list_devices libguestfs: trace: list_devices = ["/dev/sda", "/dev/sdb"] libguestfs: trace: mount_ro "/dev/sda" "/" libguestfs: trace: mount_ro = -1 (error) libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: mount_ro "/dev/sdb" "/" libguestfs: trace: mount_ro = 0 libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: list_partitions libguestfs: trace: list_partitions = ["/dev/sda1", "/dev...

On Monday, 17 July 2017 18:55:24 CEST Richard W.M. Jones wrote: > Unlike previous ‘daemon: Reimplement ...’ patches, this does not > reimplement the umount_all API completely (yet, but this > implementation could be completed in future and then replace the C > one). However it is necessary to have a version of umount_all which > we can call from the OCaml inspection code. > --- Wouldn't it be easier to wrap the C implementation, for now?...

Unlike previous ‘daemon: Reimplement ...’ patches, this does not reimplement the umount_all API completely (yet, but this implementation could be completed in future and then replace the C one). However it is necessary to have a version of umount_all which we can call from the OCaml inspection code. --- daemon/mount.ml | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ daem...

Unlike previous ‘daemon: Reimplement ...’ patches, this does not reimplement the umount_all API completely (yet, but this implementation could be completed in future and then replace the C one). However it is necessary to have a version of umount_all which we can call from the OCaml inspection code. --- daemon/mount.ml | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ daem...

...realpath.ml \ diff --git a/daemon/inspect.ml b/daemon/inspect.ml index 6d4b17815..ce62c17f2 100644 --- a/daemon/inspect.ml +++ b/daemon/inspect.ml @@ -27,7 +27,7 @@ open Inspect_types let re_primary_partition = PCRE.compile "^/dev/(?:h|s|v)d.[1234]$" let rec inspect_os () = - Mount.umount_all (); + Mount_utils.umount_all (); (* Iterate over all detected filesystems. Inspect each one in turn. *) let fses = Listfs.list_filesystems () in diff --git a/daemon/inspect_fs.ml b/daemon/inspect_fs.ml index 02e2060b9..da98946af 100644 --- a/daemon/inspect_fs.ml +++ b/daemon/inspect_fs.ml...

...hat we include lsof in > the appliance already. > --- > daemon/mount.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/daemon/mount.c b/daemon/mount.c > index c5b7d89..e139482 100644 > --- a/daemon/mount.c > +++ b/daemon/mount.c > @@ -424,6 +424,10 @@ do_umount_all (void) > r = command (NULL, &err, str_umount, mounts.argv[i], NULL); > if (r == -1) { > reply_with_error ("umount: %s: %s", mounts.argv[i], err); > + if (verbose) { > + /* Try running lsof to see what is holding the mountpoint open. */ >...

Useful for debugging unmount failures. Note that we include lsof in the appliance already. --- daemon/mount.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/daemon/mount.c b/daemon/mount.c index c5b7d89..e139482 100644 --- a/daemon/mount.c +++ b/daemon/mount.c @@ -424,6 +424,10 @@ do_umount_all (void) r = command (NULL, &err, str_umount, mounts.argv[i], NULL); if (r == -1) { reply_with_error ("umount: %s: %s", mounts.argv[i], err); + if (verbose) { + /* Try running lsof to see what is holding the mountpoint open. */ + command (NULL, NULL,...

...eady. > > --- > > daemon/mount.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/daemon/mount.c b/daemon/mount.c > > index c5b7d89..e139482 100644 > > --- a/daemon/mount.c > > +++ b/daemon/mount.c > > @@ -424,6 +424,10 @@ do_umount_all (void) > > r = command (NULL, &err, str_umount, mounts.argv[i], NULL); > > if (r == -1) { > > reply_with_error ("umount: %s: %s", mounts.argv[i], err); > > + if (verbose) { > > + /* Try running lsof to see what is holding the...

...13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl index 1ab8fdc..726cd50 100755 --- a/v2v/virt-v2v.pl +++ b/v2v/virt-v2v.pl @@ -414,11 +414,18 @@ sub close_guest_handle $guestos = undef; if (defined($g)) { - $g->umount_all(); - $g->sync(); - my $retval = $?; + eval { + $g->umount_all(); + $g->sync(); + }; + if ($@) { + warn(user_message(__x("Error cleaning up guest handle: {error}", + error =&gt...

Hi, Now with the new libguestfs-1.27.55-1.1 I have this new issue : libguestfs: trace: is_file = 0 libguestfs: trace: is_file "/freedos/freedos.ico" libguestfs: trace: is_file = 0 libguestfs: trace: is_file "/boot/loader.rc" libguestfs: trace: is_file = 0 libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: vfs_type "/dev/sda2" libguestfs: trace: vfs_type = "ntfs" libguestfs: trace: internal_parse_mountable "/dev/sda2" libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> libguestfs:...

...later?). I believe this sometimes causes my image edits to clobber each other and corrupt the image now and then. Each image edit usually amounts to: g = guestfs.GuestFS() g.add_drive(image_file) g.launch() g.mount("/dev/vda1", "/") g.write(file_name, file_contents) g.sync() g.umount_all() g.close() del g As I understand things, there is a reference count that should close "g" once the reference count = 0. However, I can't seem to make that happen inside of my python daemon which continues to run. Any clues on how I might accomplish this or what I'm doing wrong...

...g error on shutdown: (in cleanup) umount: /tmp/transferb7icam: umount: /sysroot/tmp/transferb7icam: not found at /home/mbooth/src/virt-v2v/blib/lib/Sys/VirtV2V/GuestOS/RedHat.pm line 1171. This was because the GuestOS::RedHat cleanup was being called implicitly on exit, which is after umount_all has been called explicitly on the libguestfs handle. This change garbage collects the guestos explicitly before the libguestfs handle. --- v2v/virt-v2v.pl | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl index 08f1c8d..c7ebad3 100755 ---...

...= "/var/tmp" libguestfs: trace: get_sockdir libguestfs: trace: get_sockdir = "/tmp" libguestfs: trace: get_backend_setting "gdb" libguestfs: trace: get_backend_setting = NULL (error) libguestfs: trace: launch = 0 libguestfs: trace: inspect_os libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: list_filesystems libguestfs: trace: feature_available "lvm2" libguestfs: trace: internal_feature_available "lvm2" libguestfs: trace: internal_feature_available = 0 libguestfs: trace: feature_available = 1 libguestfs: tr...

...estfs: trace: get_sockdir > libguestfs: trace: get_sockdir = "/tmp" > libguestfs: trace: get_backend_setting "gdb" > libguestfs: trace: get_backend_setting = NULL (error) > libguestfs: trace: launch = 0 > libguestfs: trace: inspect_os > libguestfs: trace: umount_all > libguestfs: trace: umount_all = 0 > libguestfs: trace: list_filesystems > libguestfs: trace: feature_available "lvm2" > libguestfs: trace: internal_feature_available "lvm2" > libguestfs: trace: internal_feature_available = 0 > libguestfs: trace: feature...

https://bugzilla.redhat.com/show_bug.cgi?id=836710 https://bugzilla.redhat.com/show_bug.cgi?id=836913 There are at least two related bugs going on: (1) Linux sync(2) system call doesn't send a write barrier to the disk, so in effect it doesn't force the hard disk to flush its cache. libguestfs used sync(2) to force changes to disk. We didn't expect that qemu was caching anything

It works, but I should delete if (guestfs_umount_all (destg) == -1) ??? exit (EXIT_FAILURE); inmain() function and /* Clean up. */ ? if (guestfs_umount_all (srcg) == -1) { ??? pthread_cancel (threaddata->mainthread); ??? exit (EXIT_FAILURE); ? } in the start_scrthread() function or it will return an error after the program finish: libguestfs:...

...-1.27.55-1.1 I have this new issue : > > libguestfs: trace: is_file = 0 > libguestfs: trace: is_file "/freedos/freedos.ico" > libguestfs: trace: is_file = 0 > libguestfs: trace: is_file "/boot/loader.rc" > libguestfs: trace: is_file = 0 > libguestfs: trace: umount_all > libguestfs: trace: umount_all = 0 > libguestfs: trace: vfs_type "/dev/sda2" > libguestfs: trace: vfs_type = "ntfs" > libguestfs: trace: internal_parse_mountable "/dev/sda2" > libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mou...

...sockdir >> libguestfs: trace: get_sockdir = "/tmp" >> libguestfs: trace: get_backend_setting "gdb" >> libguestfs: trace: get_backend_setting = NULL (error) >> libguestfs: trace: launch = 0 >> libguestfs: trace: inspect_os >> libguestfs: trace: umount_all >> libguestfs: trace: umount_all = 0 >> libguestfs: trace: list_filesystems >> libguestfs: trace: feature_available "lvm2" >> libguestfs: trace: internal_feature_available "lvm2" >> libguestfs: trace: internal_feature_available = 0 >> libguest...

...dir = "/tmp" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" libguestfs: trace: launch = 0 libguestfs: trace: list_devices libguestfs: trace: list_devices = ["/dev/sda", "/dev/sdb"] libguestfs: trace: inspect_os libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: list_devices libguestfs: trace: list_devices = ["/dev/sda", "/dev/sdb"] libguestfs: trace: vfs_type "/dev/sda" libguestfs: trace: vfs_type = "" libguestfs: trace: isoinfo_device "/dev/sda" libgues...