search for: umac_fin

The mac_compute() function in openssh calls umac_final() to prepend a tag to a buffer. Umac_final() calls pdf_gen_xor() on the tag as its final operation, and as implemented, pdf_gen_xor() assumes an appropriate alignment for 64-bit operations on its buffer. However, the buffer is declared in mac_compute() as a static u_char array, and the linker d...

...AFAIK, there is no assurance, that a static char array will be double-word aligned. And indeed, when compiled using Solaris Studio 12.1 cc, the variable address (0x909ac) is only word-aligned: 58588: 37 00 02 42 sethi %hi(0x90800), %i3 5858c: 40 00 18 1a call 5e5f4 <umac_final> 58590: 92 06 e1 ac add %i3, 0x1ac, %o1 ! 909ac <Bbss.bss> This later causes a crash in: pdf_gen_xor+0x68: ldx [0x909ac], %o5 I am proposing two alternatives for the fix (please, see attached): umac_align-pragma.patch - Solaris Studio specific pragma umac_align-union.p...