search for: ullberg

Thank you Mark. I agree and have now updated the pull request with a new commit, addressing your comments. Please take a look. /Gustaf On Fri, 5 Apr 2019 at 11:41, Mark Harris <mark.hsj at gmail.com> wrote: > On 2019-04-01 3:37, Gustaf Ullberg wrote: > > Hi everyone, > > > > Some time ago, I sent a pull request > > <https://github.com/xiph/opus/pull/107> to the Opus github page. > > Jean-Marc asked me to post it to the mailing list so everyone can have a > > look at it. > > > > You ca...

...~~~~~~~~~ Subnet = 192.168.1.0/24 Address = 10.0.1.1 Port = 655 -----BEGIN RSA PUBLIC KEY----- MIGJAoGBAKJUPnmLQeZ+0A8TFamdFsoxGLJd9GpBY1w3whdrljOLvpv0ah2pCyHQ -SNIP- JEI8zS7mOhuRTuIJcxzOMDZBVYdvxcAqN4har/XZ5Nxe6+zoUwATAgMA//8= -----END RSA PUBLIC KEY----- ~~~~~~~~~~~~ Any ideas? Thanks, Magnus Ullberg Network Coordinator Area Bancshares Corporation Networking Department 230 Frederica St. Owensboro, KY 42301 about:%53%54%55%50%49%44 Tinc: Discussion list about the tinc VPN daemon Archive: http://mail.nl.linux.org/lists/ Tinc site: http://tinc.nl.linux.org/

Yes, good point. I added the checking of prev_mode for Silk DTX to avoid using stale data from the Silk state. The PR is updated, and I'm attaching an updated patch. /Gustaf On Tue, 9 Apr 2019 at 12:42, Mark Harris <mark.hsj at gmail.com> wrote: > On 2019-04-08 4:55, Gustaf Ullberg wrote: > > Thank you Mark. > > > > I agree and have now updated the pull request with a new commit, > > addressing your comments. > > Please take a look. > > > > /Gustaf > > I think you will also need to check the mode of the previous frame > (st-&...

...ll request <https://github.com/xiph/opus/pull/107> to the Opus github page. Jean-Marc asked me to post it to the mailing list so everyone can have a look at it. You can find the description and code changes below. Please let me know if you have any questions or concerns. Best regards Gustaf Ullberg In WebRTC, we would like to be able to differentiate between "normal" frames and the comfort noise update frames that are encoded before and in-between DTX frames. These CNG update frames could then be flagged for routing or statistics reasons. Such flagging could also make it easier for...

On 2019-04-01 3:37, Gustaf Ullberg wrote: > Hi everyone, > > Some time ago, I sent a pull request > <https://github.com/xiph/opus/pull/107> to the Opus github page. > Jean-Marc asked me to post it to the mailing list so everyone can have a > look at it. > > You can find the description and code change...

On 2019-04-08 4:55, Gustaf Ullberg wrote: > Thank you Mark. > > I agree and have now updated the pull request with a new commit, > addressing your comments. > Please take a look. > > /Gustaf I think you will also need to check the mode of the previous frame (st->prev_mode) before using internal SILK encode...

On 2019-04-10 3:27, Gustaf Ullberg wrote: > Yes, good point. I added the checking of prev_mode for Silk DTX to avoid > using stale data from the Silk state. > The PR is updated, and I'm attaching an updated patch. > > /Gustaf Thanks. This looks good to me. - Mark

Hi, When running opus_demo with FEC enabled, there is a bug related to the length of FEC frames. The FEC frames will be decoded with a length of max_frame_size and the resulting output file will be much longer than the input file.

We (WebRTC) found a bug in the current implementation of OPUS_GET_IN_DTX and I just created a pull request for a fix on the Opus GitHub page. It would be great if maintainers could take a look. https://github.com/xiph/opus/pull/156 Patch attached. Best regards Gustaf >From the PR: The current implementation of OPUS_GET_IN_DTX does not properly handle the case when only the middle channel is