Displaying 20 results from an estimated 36 matches for "ufo_fragid_set".
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
.../skbuff.h
> > > +++ b/include/linux/skbuff.h
> > > @@ -605,7 +605,8 @@ struct sk_buff {
> > > __u8 ipvs_property:1;
> > > __u8 inner_protocol_type:1;
> > > __u8 remcsum_offload:1;
> > > - /* 3 or 5 bit hole */
> > > + __u8 ufo_fragid_set:1;
> > [...]
> >
> > Doesn't the flag belong in struct skb_shared_info, rather than struct
> > sk_buff? Otherwise this looks fine.
> >
> > Ben.
>
> Hmm we seem to be out of tx flags.
> Maybe ip6_frag_id == 0 should mean "not set".
Mayb...
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
.../skbuff.h
> > > +++ b/include/linux/skbuff.h
> > > @@ -605,7 +605,8 @@ struct sk_buff {
> > > __u8 ipvs_property:1;
> > > __u8 inner_protocol_type:1;
> > > __u8 remcsum_offload:1;
> > > - /* 3 or 5 bit hole */
> > > + __u8 ufo_fragid_set:1;
> > [...]
> >
> > Doesn't the flag belong in struct skb_shared_info, rather than struct
> > sk_buff? Otherwise this looks fine.
> >
> > Ben.
>
> Hmm we seem to be out of tx flags.
> Maybe ip6_frag_id == 0 should mean "not set".
Mayb...
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...ux/skbuff.h
> >>>> @@ -605,7 +605,8 @@ struct sk_buff {
> >>>> __u8 ipvs_property:1;
> >>>> __u8 inner_protocol_type:1;
> >>>> __u8 remcsum_offload:1;
> >>>> - /* 3 or 5 bit hole */
> >>>> + __u8 ufo_fragid_set:1;
> >>> [...]
> >>>
> >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> >>> sk_buff? Otherwise this looks fine.
> >>>
> >>> Ben.
> >>
> >> Hmm we seem to be out of tx flags.
>...
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...ux/skbuff.h
> >>>> @@ -605,7 +605,8 @@ struct sk_buff {
> >>>> __u8 ipvs_property:1;
> >>>> __u8 inner_protocol_type:1;
> >>>> __u8 remcsum_offload:1;
> >>>> - /* 3 or 5 bit hole */
> >>>> + __u8 ufo_fragid_set:1;
> >>> [...]
> >>>
> >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> >>> sk_buff? Otherwise this looks fine.
> >>>
> >>> Ben.
> >>
> >> Hmm we seem to be out of tx flags.
>...
2015 Jan 26
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...--git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 85ab7d7..3ad5203 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -605,7 +605,8 @@ struct sk_buff {
__u8 ipvs_property:1;
__u8 inner_protocol_type:1;
__u8 remcsum_offload:1;
- /* 3 or 5 bit hole */
+ __u8 ufo_fragid_set:1;
+ /* 2 or 4 bit hole */
#ifdef CONFIG_NET_SCHED
__u16 tc_index; /* traffic control index */
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 4292929..ca6137b 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -671,7 +671,9 @@ static inline int ipv6_addr_diff(const struc...
2015 Jan 26
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...--git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 85ab7d7..3ad5203 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -605,7 +605,8 @@ struct sk_buff {
__u8 ipvs_property:1;
__u8 inner_protocol_type:1;
__u8 remcsum_offload:1;
- /* 3 or 5 bit hole */
+ __u8 ufo_fragid_set:1;
+ /* 2 or 4 bit hole */
#ifdef CONFIG_NET_SCHED
__u16 tc_index; /* traffic control index */
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 4292929..ca6137b 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -671,7 +671,9 @@ static inline int ipv6_addr_diff(const struc...
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...x/skbuff.h
> index 85ab7d7..3ad5203 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -605,7 +605,8 @@ struct sk_buff {
> __u8 ipvs_property:1;
> __u8 inner_protocol_type:1;
> __u8 remcsum_offload:1;
> - /* 3 or 5 bit hole */
> + __u8 ufo_fragid_set:1;
[...]
Doesn't the flag belong in struct skb_shared_info, rather than struct
sk_buff? Otherwise this looks fine.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: ap...
2015 Jan 27
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...x/skbuff.h
> index 85ab7d7..3ad5203 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -605,7 +605,8 @@ struct sk_buff {
> __u8 ipvs_property:1;
> __u8 inner_protocol_type:1;
> __u8 remcsum_offload:1;
> - /* 3 or 5 bit hole */
> + __u8 ufo_fragid_set:1;
[...]
Doesn't the flag belong in struct skb_shared_info, rather than struct
sk_buff? Otherwise this looks fine.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: ap...
2015 Jan 27
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>>> +++ b/include/linux/skbuff.h
>>>> @@ -605,7 +605,8 @@ struct sk_buff {
>>>> __u8 ipvs_property:1;
>>>> __u8 inner_protocol_type:1;
>>>> __u8 remcsum_offload:1;
>>>> - /* 3 or 5 bit hole */
>>>> + __u8 ufo_fragid_set:1;
>>> [...]
>>>
>>> Doesn't the flag belong in struct skb_shared_info, rather than struct
>>> sk_buff? Otherwise this looks fine.
>>>
>>> Ben.
>>
>> Hmm we seem to be out of tx flags.
>> Maybe ip6_frag_id == 0 should mean...
2015 Jan 27
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>>> +++ b/include/linux/skbuff.h
>>>> @@ -605,7 +605,8 @@ struct sk_buff {
>>>> __u8 ipvs_property:1;
>>>> __u8 inner_protocol_type:1;
>>>> __u8 remcsum_offload:1;
>>>> - /* 3 or 5 bit hole */
>>>> + __u8 ufo_fragid_set:1;
>>> [...]
>>>
>>> Doesn't the flag belong in struct skb_shared_info, rather than struct
>>> sk_buff? Otherwise this looks fine.
>>>
>>> Ben.
>>
>> Hmm we seem to be out of tx flags.
>> Maybe ip6_frag_id == 0 should mean...
2015 Jan 28
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...@@ struct sk_buff {
> > > >>>> __u8 ipvs_property:1;
> > > >>>> __u8 inner_protocol_type:1;
> > > >>>> __u8 remcsum_offload:1;
> > > >>>> - /* 3 or 5 bit hole */
> > > >>>> + __u8 ufo_fragid_set:1;
> > > >>> [...]
> > > >>>
> > > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > > >>> sk_buff? Otherwise this looks fine.
> > > >>>
> > > >>> Ben.
> &...
2015 Jan 28
3
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...@@ struct sk_buff {
> > > >>>> __u8 ipvs_property:1;
> > > >>>> __u8 inner_protocol_type:1;
> > > >>>> __u8 remcsum_offload:1;
> > > >>>> - /* 3 or 5 bit hole */
> > > >>>> + __u8 ufo_fragid_set:1;
> > > >>> [...]
> > > >>>
> > > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > > >>> sk_buff? Otherwise this looks fine.
> > > >>>
> > > >>> Ben.
> &...
2015 Jan 27
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>> @@ -605,7 +605,8 @@ struct sk_buff {
> > >>>> __u8 ipvs_property:1;
> > >>>> __u8 inner_protocol_type:1;
> > >>>> __u8 remcsum_offload:1;
> > >>>> - /* 3 or 5 bit hole */
> > >>>> + __u8 ufo_fragid_set:1;
> > >>> [...]
> > >>>
> > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > >>> sk_buff? Otherwise this looks fine.
> > >>>
> > >>> Ben.
> > >>
> > >>...
2015 Jan 27
0
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>> @@ -605,7 +605,8 @@ struct sk_buff {
> > >>>> __u8 ipvs_property:1;
> > >>>> __u8 inner_protocol_type:1;
> > >>>> __u8 remcsum_offload:1;
> > >>>> - /* 3 or 5 bit hole */
> > >>>> + __u8 ufo_fragid_set:1;
> > >>> [...]
> > >>>
> > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > >>> sk_buff? Otherwise this looks fine.
> > >>>
> > >>> Ben.
> > >>
> > >>...
2015 Jan 28
7
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>>> __u8 ipvs_property:1;
> > > > > >>>> __u8 inner_protocol_type:1;
> > > > > >>>> __u8 remcsum_offload:1;
> > > > > >>>> - /* 3 or 5 bit hole */
> > > > > >>>> + __u8 ufo_fragid_set:1;
> > > > > >>> [...]
> > > > > >>>
> > > > > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > > > > >>> sk_buff? Otherwise this looks fine.
> > > > > &g...
2015 Jan 28
7
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
...>>> __u8 ipvs_property:1;
> > > > > >>>> __u8 inner_protocol_type:1;
> > > > > >>>> __u8 remcsum_offload:1;
> > > > > >>>> - /* 3 or 5 bit hole */
> > > > > >>>> + __u8 ufo_fragid_set:1;
> > > > > >>> [...]
> > > > > >>>
> > > > > >>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> > > > > >>> sk_buff? Otherwise this looks fine.
> > > > > &g...
2015 Jan 26
7
[PATCH 0/3] Restore UFO support to virtio_net devices
commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4
Author: Ben Hutchings <ben at decadent.org.uk>
Date: Thu Oct 30 18:27:12 2014 +0000
drivers/net: Disable UFO through virtio
Turned off UFO support to virtio-net based devices due to issues
with IPv6 fragment id generation for UFO packets. The issue
was that IPv6 UFO/GSO implementation expects the fragment id
to be supplied in
2015 Jan 26
7
[PATCH 0/3] Restore UFO support to virtio_net devices
commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4
Author: Ben Hutchings <ben at decadent.org.uk>
Date: Thu Oct 30 18:27:12 2014 +0000
drivers/net: Disable UFO through virtio
Turned off UFO support to virtio-net based devices due to issues
with IPv6 fragment id generation for UFO packets. The issue
was that IPv6 UFO/GSO implementation expects the fragment id
to be supplied in
2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._u8 ipvs_property:1;
> >>>>>>>>>> __u8 inner_protocol_type:1;
> >>>>>>>>>> __u8 remcsum_offload:1;
> >>>>>>>>>> - /* 3 or 5 bit hole */
> >>>>>>>>>> + __u8 ufo_fragid_set:1;
> >>>>>>>>> [...]
> >>>>>>>>>
> >>>>>>>>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> >>>>>>>>> sk_buff? Otherwise this looks fine.
> >&g...
2015 Jan 28
2
[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.
..._u8 ipvs_property:1;
> >>>>>>>>>> __u8 inner_protocol_type:1;
> >>>>>>>>>> __u8 remcsum_offload:1;
> >>>>>>>>>> - /* 3 or 5 bit hole */
> >>>>>>>>>> + __u8 ufo_fragid_set:1;
> >>>>>>>>> [...]
> >>>>>>>>>
> >>>>>>>>> Doesn't the flag belong in struct skb_shared_info, rather than struct
> >>>>>>>>> sk_buff? Otherwise this looks fine.
> >&g...