search for: ufo6

Hello. On 12/17/2014 09:20 PM, Vladislav Yasevich wrote: > Since UFO6 packets can now be identified by SKB_GSO_UDP6, add proper checks > to handel UFO6 flows. > Legacy applications may still have UFO6 packets identified by SKB_GSO_UDP, > so we need to continue to handle them correclty. > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> &g...

Hello. On 12/17/2014 09:20 PM, Vladislav Yasevich wrote: > Since UFO6 packets can now be identified by SKB_GSO_UDP6, add proper checks > to handel UFO6 flows. > Legacy applications may still have UFO6 packets identified by SKB_GSO_UDP, > so we need to continue to handle them correclty. > Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> &g...

Since UFO6 packets can now be identified by SKB_GSO_UDP6, add proper checks to handel UFO6 flows. Legacy applications may still have UFO6 packets identified by SKB_GSO_UDP, so we need to continue to handle them correclty. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- net/openvswitch/d...

Since UFO6 packets can now be identified by SKB_GSO_UDP6, add proper checks to handel UFO6 flows. Legacy applications may still have UFO6 packets identified by SKB_GSO_UDP, so we need to continue to handle them correclty. Signed-off-by: Vladislav Yasevich <vyasevic at redhat.com> --- net/openvswitch/d...

...ernel applies to both IPv4 and IPv6 protocols > with the same device feature. However some devices may not be able > to support one of the offloads. For this we split the UFO offload > feature into 2 pieces. NETIF_F_UFO now controlls the IPv4 part and > this series introduces NETIF_F_UFO6. > > As a result of this work, we can now re-enable NETIF_F_UFO on > virtio_net devices and restore UDP over IPv4 performance for guests. > We also continue to support legacy guests that assume that UFO6 > support included into UFO(4). > > Without this work, migrating a guest...

...ernel applies to both IPv4 and IPv6 protocols > with the same device feature. However some devices may not be able > to support one of the offloads. For this we split the UFO offload > feature into 2 pieces. NETIF_F_UFO now controlls the IPv4 part and > this series introduces NETIF_F_UFO6. > > As a result of this work, we can now re-enable NETIF_F_UFO on > virtio_net devices and restore UDP over IPv4 performance for guests. > We also continue to support legacy guests that assume that UFO6 > support included into UFO(4). > > Without this work, migrating a guest...

...- packet socket tx patch (get user) 2. Put back UFO flag everywhere: virtio,tun,macvtap,packet, since we can handle IPv6 now even if it's suboptimal. Above two seem like smalling patches, appropriate for stable. Next, work on a new feature to pass fragment ID in virtio header: 3. split UFO/UFO6 as you did here, but add code in above 4 places to convert UDP to UDP6, additionally, add code in - virtio net tx path - tun tx path (get user) - macvtap rx patch (put user) - packet socket rx patch (put user) to convert UDP6 to UDP. step 3 needs to be bisect-clean, somehow. 4. add new field...

...- packet socket tx patch (get user) 2. Put back UFO flag everywhere: virtio,tun,macvtap,packet, since we can handle IPv6 now even if it's suboptimal. Above two seem like smalling patches, appropriate for stable. Next, work on a new feature to pass fragment ID in virtio header: 3. split UFO/UFO6 as you did here, but add code in above 4 places to convert UDP to UDP6, additionally, add code in - virtio net tx path - tun tx path (get user) - macvtap rx patch (put user) - packet socket rx patch (put user) to convert UDP6 to UDP. step 3 needs to be bisect-clean, somehow. 4. add new field...

...; > since we can handle IPv6 now even if it's suboptimal. > > > > Above two seem like smalling patches, appropriate for stable. > > OK. > > > > > Next, work on a new feature to pass > > fragment ID in virtio header: > > > > 3. split UFO/UFO6 as you did here, but add code > > in above 4 places to convert UDP to UDP6, > > Doing so will adversely impact IPv6 UFO performance for legacy > guests. I know how many times I've seen mail wrt patch xyz caused > %X regression in my setup and how we've reverted or tried...

...; > since we can handle IPv6 now even if it's suboptimal. > > > > Above two seem like smalling patches, appropriate for stable. > > OK. > > > > > Next, work on a new feature to pass > > fragment ID in virtio header: > > > > 3. split UFO/UFO6 as you did here, but add code > > in above 4 places to convert UDP to UDP6, > > Doing so will adversely impact IPv6 UFO performance for legacy > guests. I know how many times I've seen mail wrt patch xyz caused > %X regression in my setup and how we've reverted or tried...

UFO support in the kernel applies to both IPv4 and IPv6 protocols with the same device feature. However some devices may not be able to support one of the offloads. For this we split the UFO offload feature into 2 pieces. NETIF_F_UFO now controlls the IPv4 part and this series introduces NETIF_F_UFO6. As a result of this work, we can now re-enable NETIF_F_UFO on virtio_net devices and restore UDP over IPv4 performance for guests. We also continue to support legacy guests that assume that UFO6 support included into UFO(4). Without this work, migrating a guest to a 3.18 kernel fails. Vladislav...

UFO support in the kernel applies to both IPv4 and IPv6 protocols with the same device feature. However some devices may not be able to support one of the offloads. For this we split the UFO offload feature into 2 pieces. NETIF_F_UFO now controlls the IPv4 part and this series introduces NETIF_F_UFO6. As a result of this work, we can now re-enable NETIF_F_UFO on virtio_net devices and restore UDP over IPv4 performance for guests. We also continue to support legacy guests that assume that UFO6 support included into UFO(4). Without this work, migrating a guest to a 3.18 kernel fails. Vladislav...

...--- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -48,8 +48,9 @@ enum { NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ NETIF_F_GSO_MPLS_BIT, /* ... MPLS segmentation */ + NETIF_F_UFO6_BIT, /* ... UDPv6 fragmentation */ /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ - NETIF_F_GSO_MPLS_BIT, + NETIF_F_UFO6_BIT, NETIF_F_FCOE_CRC_BIT, /* FCoE CRC32 */ NETIF_F_SCTP_CSUM_BIT, /* SCTP checksum offload */ @@ -109,6 +110,7 @@ enum { #define NETIF_F_TSO_ECN __NETIF_F(T...

...--- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -48,8 +48,9 @@ enum { NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ NETIF_F_GSO_MPLS_BIT, /* ... MPLS segmentation */ + NETIF_F_UFO6_BIT, /* ... UDPv6 fragmentation */ /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ - NETIF_F_GSO_MPLS_BIT, + NETIF_F_UFO6_BIT, NETIF_F_FCOE_CRC_BIT, /* FCoE CRC32 */ NETIF_F_SCTP_CSUM_BIT, /* SCTP checksum offload */ @@ -109,6 +110,7 @@ enum { #define NETIF_F_TSO_ECN __NETIF_F(T...

...include/linux/netdev_features.h >> @@ -48,8 +48,9 @@ enum { >> NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ >> NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ >> NETIF_F_GSO_MPLS_BIT, /* ... MPLS segmentation */ >> + NETIF_F_UFO6_BIT, /* ... UDPv6 fragmentation */ >> /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ >> - NETIF_F_GSO_MPLS_BIT, >> + NETIF_F_UFO6_BIT, >> >> NETIF_F_FCOE_CRC_BIT, /* FCoE CRC32 */ >> NETIF_F_SCTP_CSUM_BIT, /* SCTP checksum offload */ >> @...

...include/linux/netdev_features.h >> @@ -48,8 +48,9 @@ enum { >> NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ >> NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ >> NETIF_F_GSO_MPLS_BIT, /* ... MPLS segmentation */ >> + NETIF_F_UFO6_BIT, /* ... UDPv6 fragmentation */ >> /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ >> - NETIF_F_GSO_MPLS_BIT, >> + NETIF_F_UFO6_BIT, >> >> NETIF_F_FCOE_CRC_BIT, /* FCoE CRC32 */ >> NETIF_F_SCTP_CSUM_BIT, /* SCTP checksum offload */ >> @...

...res & NETIF_F_IP_CSUM)) { You can use !(features & NETIF_F_V4_CSUM) instead of the last two terms. > + netdev_dbg(dev, > + "Dropping NETIF_F_UFO since no checksum offload features.\n"); > + features &= ~NETIF_F_UFO; > + } > + if ((features & NETIF_F_UFO6) && !(features & NETIF_F_GEN_CSUM) && > + !(features & NETIF_F_IPV6_CSUM)) { [...] Similarly you can use !(features & NETIF_F_V6_CSUM) instead of the last two terms. Aside from those minor points, this looks fine. Ben. -- Ben Hutchings Absolutum obsoletum. (...

...res & NETIF_F_IP_CSUM)) { You can use !(features & NETIF_F_V4_CSUM) instead of the last two terms. > + netdev_dbg(dev, > + "Dropping NETIF_F_UFO since no checksum offload features.\n"); > + features &= ~NETIF_F_UFO; > + } > + if ((features & NETIF_F_UFO6) && !(features & NETIF_F_GEN_CSUM) && > + !(features & NETIF_F_IPV6_CSUM)) { [...] Similarly you can use !(features & NETIF_F_V6_CSUM) instead of the last two terms. Aside from those minor points, this looks fine. Ben. -- Ben Hutchings Absolutum obsoletum. (...

...ack UFO flag everywhere: virtio,tun,macvtap,packet, > since we can handle IPv6 now even if it's suboptimal. > > Above two seem like smalling patches, appropriate for stable. OK. > > Next, work on a new feature to pass > fragment ID in virtio header: > > 3. split UFO/UFO6 as you did here, but add code > in above 4 places to convert UDP to UDP6, Doing so will adversely impact IPv6 UFO performance for legacy guests. I know how many times I've seen mail wrt patch xyz caused %X regression in my setup and how we've reverted or tried to fixed things to solve...

...ack UFO flag everywhere: virtio,tun,macvtap,packet, > since we can handle IPv6 now even if it's suboptimal. > > Above two seem like smalling patches, appropriate for stable. OK. > > Next, work on a new feature to pass > fragment ID in virtio header: > > 3. split UFO/UFO6 as you did here, but add code > in above 4 places to convert UDP to UDP6, Doing so will adversely impact IPv6 UFO performance for legacy guests. I know how many times I've seen mail wrt patch xyz caused %X regression in my setup and how we've reverted or tried to fixed things to solve...