search for: uaccess

...4_bo.c: In function 'vc4_create_shader_bo_ioctl': drivers/gpu/drm/vc4/vc4_bo.c:502:2: error: implicit declaration of function 'u64_to_user_ptr' [-Werror=implicit-function-declaration] if (copy_from_user(bo->base.vaddr, ^ In file included from arch/m68k/include/asm/uaccess.h:4:0, from include/linux/uaccess.h:5, from include/linux/highmem.h:8, from include/drm/drmP.h:40, from drivers/gpu/drm/vc4/vc4_drv.h:9, from drivers/gpu/drm/vc4/vc4_bo.c:21: >> arch/m68k/inclu...

Use the newly added u64_to_user_pointer a bit more frequently. Signed-off-by: Joe Perches <joe at perches.com> --- drivers/gpu/drm/armada/armada_gem.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 7 ++++--- drivers/gpu/drm/tegra/drm.c | 15 ++++++++------- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- drivers/gpu/drm/vc4/vc4_gem.c | 10 +++++-----

Use the newly added u64_to_user_pointer a bit more frequently. Signed-off-by: Joe Perches <joe at perches.com> --- drivers/gpu/drm/armada/armada_gem.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 7 ++++--- drivers/gpu/drm/tegra/drm.c | 15 ++++++++------- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- drivers/gpu/drm/vc4/vc4_gem.c | 10 +++++-----

...en in linux-next apparently with no ill effects. The following changes since commit 99975cc6ada0d5f2675e83abecae05aba5f437d2: vhost/net: length miscalculation (2015-01-07 12:22:00 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/uaccess_for_upstream for you to fetch changes up to 0795cb1b46e7938ed679ccd48f933e75272b30e3: sparc32: nocheck uaccess coding style tweaks (2015-01-13 15:24:14 +0200) ---------------------------------------------------------------- uaccess: fix sparse warning on get/put_user for bitwise types At the...

...en in linux-next apparently with no ill effects. The following changes since commit 99975cc6ada0d5f2675e83abecae05aba5f437d2: vhost/net: length miscalculation (2015-01-07 12:22:00 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/uaccess_for_upstream for you to fetch changes up to 0795cb1b46e7938ed679ccd48f933e75272b30e3: sparc32: nocheck uaccess coding style tweaks (2015-01-13 15:24:14 +0200) ---------------------------------------------------------------- uaccess: fix sparse warning on get/put_user for bitwise types At the...

...config && make dep' to configure the kernel" /usr/src/linux/include/linux/version.h:12:2: #error "for that configuration." In file included from /usr/src/linux/include/linux/poll.h:11, from zaptel.h:853, from zaptel.c:82: /usr/include/asm/uaccess.h: At top level: /usr/include/asm/uaccess.h:102: error: parse error before '*' token /usr/include/asm/uaccess.h: In function `verify_area': /usr/include/asm/uaccess.h:104: error: `addr' undeclared (first use in this function) /usr/include/asm/uaccess.h:104: error: `size' undecla...

On 2016?11?24? 18:25, Mark Rutland wrote: > As a step towards killing off ACCESS_ONCE, use {READ,WRITE}_ONCE() for the > virtio tools uaccess primitives, pulling these in from <linux/compiler.h>. > > With this done, we can kill off the now-unused ACCESS_ONCE() definition. > > Signed-off-by: Mark Rutland <mark.rutland at arm.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: Michael S. Tsirkin <mst...

As a step towards killing off ACCESS_ONCE, use {READ,WRITE}_ONCE() for the virtio tools uaccess primitives, pulling these in from <linux/compiler.h>. With this done, we can kill off the now-unused ACCESS_ONCE() definition. Signed-off-by: Mark Rutland <mark.rutland at arm.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: linux...

...-generic/pci.h:21: error: dereferencing pointer to incomplete type /usr/include/asm-generic/pci.h:22: error: dereferencing pointer to incomplete type In file included from /usr/src/linux/include/linux/poll.h:11, from zaptel.h:862, from zaptel.c:82: /usr/include/asm/uaccess.h: At top level: /usr/include/asm/uaccess.h:102: error: parse error before '*' token /usr/include/asm/uaccess.h: In function `verify_area': /usr/include/asm/uaccess.h:104: error: `addr' undeclared (first use in this function) /usr/include/asm/uaccess.h:104: error: `size' undecla...

On Thu, Nov 1, 2018 at 4:00 PM Kees Cook <keescook at chromium.org> wrote: > > + memset(&rsp, 0, sizeof(rsp)); > + rsp.response = VIRTIO_SCSI_S_FUNCTION_REJECTED; > + resp = vq->iov[out].iov_base; > + ret = __copy_to_user(resp, &rsp, sizeof(rsp)); > > Is it actually safe to trust that iov_base has passed an earlier > access_ok()

On Thu, Nov 1, 2018 at 4:00 PM Kees Cook <keescook at chromium.org> wrote: > > + memset(&rsp, 0, sizeof(rsp)); > + rsp.response = VIRTIO_SCSI_S_FUNCTION_REJECTED; > + resp = vq->iov[out].iov_base; > + ret = __copy_to_user(resp, &rsp, sizeof(rsp)); > > Is it actually safe to trust that iov_base has passed an earlier > access_ok()

...udio_kern.c @@ -3,13 +3,13 @@ * Licensed under the GPL */ -#include "linux/module.h" -#include "linux/init.h" -#include "linux/slab.h" -#include "linux/fs.h" -#include "linux/sound.h" -#include "linux/soundcard.h" -#include "asm/uaccess.h" +#include <linux/module.h> +#include <linux/init.h> +#include <linux/slab.h> +#include <linux/fs.h> +#include <linux/sound.h> +#include <linux/soundcard.h> +#include <asm/uaccess.h> #include "kern_util.h" #include "init.h" #in...

...udio_kern.c @@ -3,13 +3,13 @@ * Licensed under the GPL */ -#include "linux/module.h" -#include "linux/init.h" -#include "linux/slab.h" -#include "linux/fs.h" -#include "linux/sound.h" -#include "linux/soundcard.h" -#include "asm/uaccess.h" +#include <linux/module.h> +#include <linux/init.h> +#include <linux/slab.h> +#include <linux/fs.h> +#include <linux/sound.h> +#include <linux/soundcard.h> +#include <asm/uaccess.h> #include "kern_util.h" #include "init.h" #in...

On Thu, 24 Nov 2016 10:25:14 +0000 Mark Rutland <mark.rutland at arm.com> wrote: > As a step towards killing off ACCESS_ONCE, use {READ,WRITE}_ONCE() for the > virtio tools uaccess primitives, pulling these in from <linux/compiler.h>. > > With this done, we can kill off the now-unused ACCESS_ONCE() definition. > > Signed-off-by: Mark Rutland <mark.rutland at arm.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: Michael S. Tsirkin <m...

In preparation to virtio header changes, include uaccess.h directly as this file is using copy to/from user. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index 205e...

...equire some manual intervention. This series moves the virtio and vringh code over to {READ,WRITE}_ONCE(), in the process fixing a bug in the virtio headers. Thanks, Mark. Mark Rutland (3): tools/virtio: fix READ_ONCE() vringh: kill off ACCESS_ONCE() tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h drivers/vhost/vringh.c | 5 +++-- tools/virtio/linux/compiler.h | 2 +- tools/virtio/linux/uaccess.h | 9 +++++---- 3 files changed, 9 insertions(+), 7 deletions(-) -- 2.7.4

...equire some manual intervention. This series moves the virtio and vringh code over to {READ,WRITE}_ONCE(), in the process fixing a bug in the virtio headers. Thanks, Mark. Mark Rutland (3): tools/virtio: fix READ_ONCE() vringh: kill off ACCESS_ONCE() tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h drivers/vhost/vringh.c | 5 +++-- tools/virtio/linux/compiler.h | 2 +- tools/virtio/linux/uaccess.h | 9 +++++---- 3 files changed, 9 insertions(+), 7 deletions(-) -- 2.7.4

...t use copy_to_user() instead? > > > > Good point. > > > > We really should have removed those double-underscore things ages ago. > > FWIW, on arm64 we always check/sanitize the user address as a result of > our sanitization of speculated values. Almost all of our uaccess > routines have an explicit access_ok(). > > All our uaccess routines mask the user pointer based on addr_limit, > which prevents speculative or architectural uaccess to kernel addresses > when addr_limit it USER_DS: > > 4d8efc2d5ee4c9cc ("arm64: Use pointer masking...

...t use copy_to_user() instead? > > > > Good point. > > > > We really should have removed those double-underscore things ages ago. > > FWIW, on arm64 we always check/sanitize the user address as a result of > our sanitization of speculated values. Almost all of our uaccess > routines have an explicit access_ok(). > > All our uaccess routines mask the user pointer based on addr_limit, > which prevents speculative or architectural uaccess to kernel addresses > when addr_limit it USER_DS: > > 4d8efc2d5ee4c9cc ("arm64: Use pointer masking...

...s are I think ... container_of_const() is in 6.2. > > > --- > > tools/include/linux/types.h | 1 - > > tools/virtio/linux/compiler.h | 2 ++ > > tools/virtio/linux/kernel.h | 5 +---- > > tools/virtio/linux/module.h | 1 - > > tools/virtio/linux/uaccess.h | 11 ++--------- > > 5 files changed, 5 insertions(+), 15 deletions(-) > > > > diff --git a/tools/include/linux/types.h b/tools/include/linux/types.h > > index 051fdeaf2670..f1896b70a8e5 100644 > > --- a/tools/include/linux/types.h > > +++ b/tools/include/li...