search for: u64_stats_syncp

Displaying 5 results from an estimated 5 matches for "u64_stats_syncp".

Did you mean: u64_stats_sync
2018 Jul 31
2
[PATCH net-next 2/2] virtio-net: get rid of unnecessary container of rq stats
...q_stat_items { > u64 kicks; > }; > > -struct virtnet_rq_stats { > - struct u64_stats_sync syncp; > - struct virtnet_rq_stat_items items; > -}; I'm not thinking removing sq stat is needed but even if it is I want to keep virtnet_rq_stats to avoid allocating unnecessary u64_stats_syncp on stack in virtnet_receive. I would just remove virtnet_rx_stats if necessary. > - > -struct virtnet_rx_stats { > - struct virtnet_rq_stat_items rx; > -}; > - -- Toshiaki Makita
2018 Jul 31
2
[PATCH net-next 2/2] virtio-net: get rid of unnecessary container of rq stats
...q_stat_items { > u64 kicks; > }; > > -struct virtnet_rq_stats { > - struct u64_stats_sync syncp; > - struct virtnet_rq_stat_items items; > -}; I'm not thinking removing sq stat is needed but even if it is I want to keep virtnet_rq_stats to avoid allocating unnecessary u64_stats_syncp on stack in virtnet_receive. I would just remove virtnet_rx_stats if necessary. > - > -struct virtnet_rx_stats { > - struct virtnet_rq_stat_items rx; > -}; > - -- Toshiaki Makita
2018 Aug 01
0
[PATCH net-next 2/2] virtio-net: get rid of unnecessary container of rq stats
...t;> }; >> >> -struct virtnet_rq_stats { >> - struct u64_stats_sync syncp; >> - struct virtnet_rq_stat_items items; >> -}; > I'm not thinking removing sq stat is needed but even if it is I want to > keep virtnet_rq_stats to avoid allocating unnecessary u64_stats_syncp on > stack in virtnet_receive. I would just remove virtnet_rx_stats if necessary. It's a nop on 64bit machines. And an unsigned on 32bit. So it's overhead could be ignored I think. Thanks >> - >> -struct virtnet_rx_stats { >> - struct virtnet_rq_stat_items rx; >&...
2018 Jul 31
8
[PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters
Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing
2018 Jul 31
8
[PATCH net-next 1/2] virtio-net: correctly update XDP_TX counters
Commit 5b8f3c8d30a6 ("virtio_net: Add XDP related stats") tries to count TX XDP stats in virtnet_receive(). This will cause several issues: - virtnet_xdp_sq() was called without checking whether or not XDP is set. This may cause out of bound access when there's no enough txq for XDP. - Stats were updated even if there's no XDP/XDP_TX. Fixing this by reusing