Displaying 2 results from an estimated 2 matches for "tysizeinbyt".
Did you mean:
tysizeinbytes
2019 May 06
2
RFC: On removing magic numbers assuming 8-bit bytes
...tion of the code that we want to
modify is using the byte terminology today. An example of unmodified
code from my showcase patch set:
assert(!(Shift & 0x7) == 0 &&
"Shifts not aligned on Bytes are not supported.");
uint64_t Offset = Shift / 8;
unsigned TySizeInBytes = Origin->getValueSizeInBits(0) / 8;
assert(!(Origin->getValueSizeInBits(0) & 0x7) == 0 &&
"The size of the original loaded type is not a
"multiple of a byte.");
How would you prefer we handle this? If we only remove the magic
numbers u...
2019 May 03
2
RFC: On removing magic numbers assuming 8-bit bytes
Jeroen Dobbelaere via llvm-dev <llvm-dev at lists.llvm.org> writes:
> Hi Jesper,
>
>> Thanks, these are interesting differences. The CHAR_BIT and byte
>> relation is established in the C standard and I would prefer the byte
>> terminology. It means the same thing as addressable unit but is a bit
>> shorter and probably more widely known.
>
> Looking