search for: type_size

...ang/svn/llvm-gcc/gcc/../include -I/home/ang/svn/llvm-gcc/gcc/../libcp p/include -I/home/ang/svn/llvm-gcc/gcc/../libdecnumber -I../libdecnumber -I/hom e/ang/build/llvm/include -I/home/ang/svn/llvm/include -DL_powixf2 -c /home/ang/s vn/llvm-gcc/gcc/libgcc2.c -o libgcc/./_powixf2.o assertion "(!TYPE_SIZE(Tr) || !Ty->isSized() || !isInt64(TYPE_SIZE(Tr), true) || getInt64(TYPE_SIZE(Tr), true) == getTargetData().getTypeAllocSizeInBits(Ty)) && "LLVM type size doesn't match GCC type size!"" failed: file "/home/ang/svn/llvm -gcc/gcc/llvm-types.cpp", line 83 This...

...object_class = SWFDEC_AS_OBJECT_CLASS (klass); - - object_class->dispose = swfdec_as_function_dispose; - - asobject_class->mark = swfdec_as_function_mark; } static void swfdec_as_function_init (SwfdecAsFunction *function) { - function->type = SWFDEC_TYPE_AS_OBJECT; - function->type_size = sizeof (SwfdecAsObject); } SwfdecAsFunction * -swfdec_as_function_do_create (SwfdecAsContext *context) +swfdec_as_function_create (SwfdecAsContext *context, GType type, guint size) { SwfdecAsValue val; SwfdecAsObject *fun; - if (!swfdec_as_context_use_mem (context, sizeof (SwfdecAsF...

...MPILER_GCC) # define _LIBCPP_HAS_GCC_ATOMIC_IMP #endif To implement atomic_ref, it might be cleaner to use the gcc builtins. By doing so, we avoid depending on the internals of the c11 atomic builtins. The required alignment of referenced variables would always be the first power of 2 >= max(type_size, type_alignment). Alternatively, we could use the c11 atomic builtins when available if it is enough to require that the input reference is aligned as the atomic type would be. What are your thoughts? Regards, Ben -------------- next part -------------- An HTML attachment was scrubbed... URL: <...

Hi Chandler, > void > foo () { > float x __attribute__ ((mode (XF))); > } nice reduction. I don't see any problem on x86-32, and I don't have access to an x86-64 box right now. Can you please open a PR for this, and also run in the debugger. When you hit the abort, use "up" to go up a stack frame or two or three, and print out the gcc types [use: call

...(gdb) up #1 0x00002b709e48ca00 in abort () from /lib/libc.so.6 (gdb) up #2 0x00002b709e4843df in __assert_fail () from /lib/libc.so.6 (gdb) up #3 0x0000000000a84d3b in llvm_set_type (Tr=0x2b709d6f8790, Ty=0x166c210) at /home/chandlerc/code/compilers/llvm-gcc/gcc/llvm-types.cpp:78 78 assert((!TYPE_SIZE(Tr) || !Ty->isSized() || !isInt64(TYPE_SIZE(Tr), true) || (gdb) Ty->dump() Undefined command: "Ty->dump". Try "help". (gdb) call Ty->dump() x86_fp80 (gdb) call debug_tree(type) No symbol "type" in current context. (gdb) up #4 0x0000000000a86501 in TypeCon...

Please review this patch for PR3510 (and <rdar://problem/6564697>). The bug is a failure to handle a "hole" inside an initialized structure, where the hole may be induced by a designated initializer or by alignment: http://llvm.org/bugs/show_bug.cgi?id=3510 The original code was greatly simplified by using FieldNo to index the LLVM fields and the initializer in

...e defined to be (3), the maximum number of bits that may be overwritten by a store [except that it's in bytes]. This means changing the implementation for APInts, but not for other types. Clearly getABITypeSize corresponds to (5) [except that it's in bytes]. This corresponds to gcc's TYPE_SIZE. Currently getABITypeSizeInBits returns 36 for i36, and otherwise 8*getABITypeSize. It seems to me that this is clearly wrong for APInts, and that it should always return 8*getABITypeSize (in which case it can be eliminated). If no one objects, I will delete it as redundant. Finally, looking thr...

Bam. This is about as reduced as it gets. I think I can spot the problem point: chandlerc at osiris ~/code/compilers/build/llvm-gcc $ cat testcase.i void foo () { float x __attribute__ ((mode (XF))); } chandlerc at osiris ~/code/compilers/build/llvm-gcc $ ./gcc/cc1 -fpreprocessed -march=k8 testcase.i -o /dev/null foocc1: /home/chandlerc/code/compilers/llvm-gcc/gcc/llvm-types.cpp:81: const

...entation for APInts, but not for other types. To me getTypeSize is getTypeSizeInBits divided by 8 and rounded up. I think renaming it to getTypeSizeInBytes make sense. > > Clearly getABITypeSize corresponds to (5) [except that it's in > bytes]. This > corresponds to gcc's TYPE_SIZE. Right. > > Currently getABITypeSizeInBits returns 36 for i36, and otherwise > 8*getABITypeSize. > It seems to me that this is clearly wrong for APInts, and that it > should always > return 8*getABITypeSize (in which case it can be eliminated). If > no one objects, &gt...

I do not have a strong opinion on the naming of the various size functions, or on how to deal with APInt's of sizes that are not multiples of a byte. I do think loading and storing more bytes than necessary is generally a bad idea, especially if you're getting uninitialized bits. (If you incorrectly cross a page boundary, you might fault, for one thing. Watch out for packed

...might be less bits (36 for an i36) so you may make wrong conclusions. I would rather define it as (3), since that has a pretty clear meaning, and seems useful. > > Clearly getABITypeSize corresponds to (5) [except that it's in > > bytes]. This > > corresponds to gcc's TYPE_SIZE. > > Right. > > > > > Currently getABITypeSizeInBits returns 36 for i36, and otherwise > > 8*getABITypeSize. > > It seems to me that this is clearly wrong for APInts, and that it > > should always > > return 8*getABITypeSize (in which case it can b...

...ns: getTypeSizeInBits - actual size getABITypeSizeInBits - ABI size when used in a larger structure getStorageTypeSizeInBits - size of load / store > >>> Clearly getABITypeSize corresponds to (5) [except that it's in >>> bytes]. This >>> corresponds to gcc's TYPE_SIZE. >> >> Right. >> >>> >>> Currently getABITypeSizeInBits returns 36 for i36, and otherwise >>> 8*getABITypeSize. >>> It seems to me that this is clearly wrong for APInts, and that it >>> should always >>> return 8*getABITypeSize...