search for: twine_tripl

...g suspicion that while the test passed, it didn't actually expose this case to the common Twine use cases. Perhaps only explicitly invoking the Twine ctor would've got the char-as-number behavior previously) -------------- next part -------------- A non-text attachment was scrubbed... Name: twine_triple.diff Type: application/octet-stream Size: 3732 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110721/8cd5b77a/attachment.obj>

...I'm still tossing it around as something to try)) it'd be more practical to use it as the go-to argument for anything that needs a string. Looking forward to hearing anyone's thoughts on this. - David -------------- next part -------------- A non-text attachment was scrubbed... Name: twine_triple.diff Type: application/octet-stream Size: 3201 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110721/eab246db/attachment.obj>

...er concatenation without my > change, so I have a sneaking suspicion that while the test passed, it > didn't actually expose this case to the common Twine use cases. > Perhaps only explicitly invoking the Twine ctor would've got the > char-as-number behavior previously) > <twine_triple.diff> The dangerous part of this is that characters are integers, so "foo" + 'x' is very likely to cause serious problems. This is the reason that the integer versions of the twine ctor are marked 'explicit'. I'm ok with the Twine class changes in this patch if...

On Jul 18, 2011, at 12:38 PM, David Blaikie wrote: > I'm attempting to do some amount of mass migration from const std::string& (& const char*) to StringRef. Great! > In doing so I stumbled across the fact that while StringRef has no op+ to speak of (well, it has += and I added a manual StringRef+std::string and std::string+StringRef for now - though I'm thinking perhaps

I'm attempting to do some amount of mass migration from const std::string& (& const char*) to StringRef. In doing so I stumbled across the fact that while StringRef has no op+ to speak of (well, it has += and I added a manual StringRef+std::string and std::string+StringRef for now - though I'm thinking perhaps they can be skipped in favor of Twine operations), Twine does provide a