search for: tvvf

...cleanup_fn rm -f $files > > -# Create a tar file containing the disk image. > -tar cf tar.tar disk > +# Create a tar file containing the disk image plus some other random > +# files that hopefully will be ignored. > +tar cf tar.tar test-tar.sh Makefile disk Makefile.am > +tar tvvf tar.tar > > # Run nbdkit. > start_nbdkit -P tar.pid -U $sock tar tar=tar.tar file=disk > > -# Now see if we can open the disk from the tar file. > -guestfish -x --ro --format=raw -a "nbd://?socket=$sock" -m /dev/sda1 <<EOF > +# Now see if we can open, read and...

Seems our current libarchive? That support FreeBSD's tar implementation has a bug where it can create archives it cant read back. This can be seen by simply creating an empty tar.gz file and then trying to expand or list it. In doing the above you get the following error: tar: Unrecognized archive format: Inappropriate file type or format N.B. gtar can list and expand the created file

For context see these threads: https://lists.gnu.org/archive/html/qemu-discuss/2020-06/threads.html#00053 https://lists.gnu.org/archive/html/qemu-block/2020-06/threads.html#01496 Rich.

...tar.tar $sock" rm -f $files cleanup_fn rm -f $files -# Create a tar file containing the disk image. -tar cf tar.tar disk +# Create a tar file containing the disk image plus some other random +# files that hopefully will be ignored. +tar cf tar.tar test-tar.sh Makefile disk Makefile.am +tar tvvf tar.tar # Run nbdkit. start_nbdkit -P tar.pid -U $sock tar tar=tar.tar file=disk -# Now see if we can open the disk from the tar file. -guestfish -x --ro --format=raw -a "nbd://?socket=$sock" -m /dev/sda1 <<EOF +# Now see if we can open, read and write the disk from the tar fi...

...img info --output=json $nbd' > $out cat $out # Check various fields in the input. diff --git a/tests/test-tar.sh b/tests/test-tar.sh index 3164b826..8f6422cf 100755 --- a/tests/test-tar.sh +++ b/tests/test-tar.sh @@ -49,7 +49,7 @@ tar cf tar.tar test-tar.sh Makefile disk Makefile.am tar tvvf tar.tar # Run nbdkit. -start_nbdkit -P tar.pid -U $sock tar tar=tar.tar file=disk +start_nbdkit -P tar.pid -U $sock file tar.tar --filter=tar tar-entry=disk # Now see if we can open, read and write the disk from the tar file. guestfish -x --format=raw -a "nbd://?socket=$sock" -m /d...

For review only, this needs some clean up and more tests. My eyes are going cross-eyed looking at the calculate_offset_of_entry function, so time to take a break ... Rich.