search for: tun_f_csum

...;> + feature_mask |= NETIF_F_SCTP_CRC; > >>>> + > >>> > >>> so this still affects TX, shouldn't this affect RX instead? > >> > >> There is no bit to set on the RX path just like there is no bit to set on the RX patch > >> for TUN_F_CSUM. > >> > >> We only invert TSO offloads, not checksum offloads as the comment below states. > >> For checksum, macvtap has to compute the checksum itself in tap_handle_frame() above. > >> It uses tx feature bits to see if needs do to the checksum. > >> &...

...gt;> + if (arg & TUN_F_SCTP_CSUM) > >> + feature_mask |= NETIF_F_SCTP_CRC; > >> + > > > > so this still affects TX, shouldn't this affect RX instead? > > There is no bit to set on the RX path just like there is no bit to set on the RX patch > for TUN_F_CSUM. > > We only invert TSO offloads, not checksum offloads as the comment below states. > For checksum, macvtap has to compute the checksum itself in tap_handle_frame() above. > It uses tx feature bits to see if needs do to the checksum. > > If you think we need another flag to ma...

...gt;> + if (arg & TUN_F_SCTP_CSUM) > >> + feature_mask |= NETIF_F_SCTP_CRC; > >> + > > > > so this still affects TX, shouldn't this affect RX instead? > > There is no bit to set on the RX path just like there is no bit to set on the RX patch > for TUN_F_CSUM. > > We only invert TSO offloads, not checksum offloads as the comment below states. > For checksum, macvtap has to compute the checksum itself in tap_handle_frame() above. > It uses tx feature bits to see if needs do to the checksum. > > If you think we need another flag to ma...

...; TUN_F_SCTP_CSUM) >>>> + feature_mask |= NETIF_F_SCTP_CRC; >>>> + >>> >>> so this still affects TX, shouldn't this affect RX instead? >> >> There is no bit to set on the RX path just like there is no bit to set on the RX patch >> for TUN_F_CSUM. >> >> We only invert TSO offloads, not checksum offloads as the comment below states. >> For checksum, macvtap has to compute the checksum itself in tap_handle_frame() above. >> It uses tx feature bits to see if needs do to the checksum. >> >> If you think we n...

...e TSO bit means that the userspace wants to > * accept TSO frames and turning it off means that user space > @@ -1077,7 +1079,7 @@ static long tap_ioctl(struct file *file, unsigned int cmd, > case TUNSETOFFLOAD: > /* let the user check for future flags */ > if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > - TUN_F_TSO_ECN | TUN_F_UFO)) > + TUN_F_TSO_ECN | TUN_F_UFO | TUN_F_SCTP_CSUM)) > return -EINVAL; > > rtnl_lock(); > -- > 2.9.5

...e TSO bit means that the userspace wants to > * accept TSO frames and turning it off means that user space > @@ -1077,7 +1079,7 @@ static long tap_ioctl(struct file *file, unsigned int cmd, > case TUNSETOFFLOAD: > /* let the user check for future flags */ > if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > - TUN_F_TSO_ECN | TUN_F_UFO)) > + TUN_F_TSO_ECN | TUN_F_UFO | TUN_F_SCTP_CSUM)) > return -EINVAL; > > rtnl_lock(); > -- > 2.9.5

The problem with introducing checksum offload and gso to tun is they need to set dev->features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. Unfortunately, TUNSETIFF has always just ignored flags it doesn't understand, so there's no good way of detecting whether the kernel supports new IFF_ flags. This patch

The problem with introducing checksum offload and gso to tun is they need to set dev->features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. Unfortunately, TUNSETIFF has always just ignored flags it doesn't understand, so there's no good way of detecting whether the kernel supports new IFF_ flags. This patch

The problem with introducing checksum offload and gso to tun is they need to set dev->features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. Unfortunately, TUNSETIFF has always just ignored flags it doesn't understand, so there's no good way of detecting whether the kernel supports new IFF_ flags. This patch

The problem with introducing checksum offload and gso to tun is they need to set dev->features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. Unfortunately, TUNSETIFF has always just ignored flags it doesn't understand, so there's no good way of detecting whether the kernel supports new IFF_ flags. This patch

...> } >> } >> >> + if (arg & TUN_F_SCTP_CSUM) >> + feature_mask |= NETIF_F_SCTP_CRC; >> + > > so this still affects TX, shouldn't this affect RX instead? There is no bit to set on the RX path just like there is no bit to set on the RX patch for TUN_F_CSUM. We only invert TSO offloads, not checksum offloads as the comment below states. For checksum, macvtap has to compute the checksum itself in tap_handle_frame() above. It uses tx feature bits to see if needs do to the checksum. If you think we need another flag to macvtap to control RXCSUM, that...

...F_TSO6 | NETIF_F_UFO) fixing this probably should be a separate patch before your series, and Cc stable. > @@ -1066,7 +1074,7 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, > case TUNSETOFFLOAD: > /* let the user check for future flags */ > if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > - TUN_F_TSO_ECN)) > + TUN_F_TSO_ECN | TUN_F_UFO)) > return -EINVAL; > > rtnl_lock(); > -- > 1.9.3

...F_TSO6 | NETIF_F_UFO) fixing this probably should be a separate patch before your series, and Cc stable. > @@ -1066,7 +1074,7 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, > case TUNSETOFFLOAD: > /* let the user check for future flags */ > if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > - TUN_F_TSO_ECN)) > + TUN_F_TSO_ECN | TUN_F_UFO)) > return -EINVAL; > > rtnl_lock(); > -- > 1.9.3

Now that we have SCTP offload capabilities in the kernel, we can add them to virtio as well. First step is SCTP checksum. We need a new freature in virtio to negotiate this support since SCTP is excluded with the stardard checksum and requires a little bit extra. This series proposes VIRTIO_NET_F_SCTP_CSUM feature bit. As the "little bit extra", the kernel uses a new bit in the skb

...;t handle TSO packets, it might get them anyway? > > > > > >> @@ -1066,7 +1074,7 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, > >> case TUNSETOFFLOAD: > >> /* let the user check for future flags */ > >> if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > >> - TUN_F_TSO_ECN)) > >> + TUN_F_TSO_ECN | TUN_F_UFO)) > >> return -EINVAL; > >> > >> rtnl_lock(); > >> -- > >> 1.9.3

...;t handle TSO packets, it might get them anyway? > > > > > >> @@ -1066,7 +1074,7 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, > >> case TUNSETOFFLOAD: > >> /* let the user check for future flags */ > >> if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | > >> - TUN_F_TSO_ECN)) > >> + TUN_F_TSO_ECN | TUN_F_UFO)) > >> return -EINVAL; > >> > >> rtnl_lock(); > >> -- > >> 1.9.3

On Tue, Nov 11, 2014 at 12:17:26PM +0000, Ben Hutchings wrote: > On Tue, 2014-11-11 at 10:58 +0000, Stefan Hajnoczi wrote: > > Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ("drivers/net: Disable > > UFO through virtio") breaks live migration of KVM guests from older to > > newer host kernels: > > > >

On Tue, Nov 11, 2014 at 12:17:26PM +0000, Ben Hutchings wrote: > On Tue, 2014-11-11 at 10:58 +0000, Stefan Hajnoczi wrote: > > Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ("drivers/net: Disable > > UFO through virtio") breaks live migration of KVM guests from older to > > newer host kernels: > > > >

...ds, where * setting the TSO bit means that the userspace wants to * accept TSO frames and turning it off means that user space @@ -1077,7 +1079,7 @@ static long tap_ioctl(struct file *file, unsigned int cmd, case TUNSETOFFLOAD: /* let the user check for future flags */ if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | - TUN_F_TSO_ECN | TUN_F_UFO)) + TUN_F_TSO_ECN | TUN_F_UFO | TUN_F_SCTP_CSUM)) return -EINVAL; rtnl_lock(); -- 2.9.5

...ature_mask & (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_UFO)) features |= RX_OFFLOADS; else features &= ~RX_OFFLOADS; @@ -1066,7 +1074,7 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, case TUNSETOFFLOAD: /* let the user check for future flags */ if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 | - TUN_F_TSO_ECN)) + TUN_F_TSO_ECN | TUN_F_UFO)) return -EINVAL; rtnl_lock(); -- 1.9.3