search for: tu1

Hi, We recently narrowed down a clang regression to the following testcase: struct S { static const int x; }; template<typename T> struct U { static const int k; }; template<typename T> const int U<T>::k = T::x; #ifdef TU1 extern int f(); const int S::x = 42; int main() { return f() + U<S>::k; } #endif #ifdef TU2 int f() { return U<S>::k; } #endif /* Steps to repro: clang repro.cpp -DTU1 -c -o tu1.o clang repro.cpp -DTU2 -c -o tu2.o clang tu1.o tu2.o ./a.out */ This segfaults, because... in TU1, we...

...011 23:19, Richard Smith wrote: > We recently narrowed down a clang regression to the following testcase: > > struct S { static const int x; }; > template<typename T> struct U { static const int k; }; > template<typename T> const int U<T>::k = T::x; > > #ifdef TU1 > extern int f(); > const int S::x = 42; > int main() { return f() + U<S>::k; } > #endif > > #ifdef TU2 > int f() { return U<S>::k; } > #endif > > /* Steps to repro: > > clang repro.cpp -DTU1 -c -o tu1.o > clang repro.cpp -DTU2 -c -o tu2.o > cla...

...te: >> We recently narrowed down a clang regression to the following testcase: >> >> struct S { static const int x; }; >> template<typename T> struct U { static const int k; }; >> template<typename T> const int U<T>::k = T::x; >> >> #ifdef TU1 >> extern int f(); >> const int S::x = 42; >> int main() { return f() + U<S>::k; } >> #endif >> >> #ifdef TU2 >> int f() { return U<S>::k; } >> #endif >> >> /* Steps to repro: >> >> clang repro.cpp -DTU1 -c -o tu1.o...

...move from the source code (unless there were some configuration that was not compiled). Is this reasonable? I started to play around with some toy examples and got stuck on the very beginning not being able to figure out where the unused functions are actually getting removed. Here is what I did: tu1.cpp: int unused(int a); int probably_inlined(int a); int main(int argc, const char *argv[]) { return probably_inlined(argc); } tu2.cpp: int unused(int a) { return a + 1; } int probably_inlined(int a) { return a + 2; } I produced two object files with bitcode: clang -c -flto tu1.cpp -o tu1.o...

...as not compiled). Is this >> reasonable? >> >> I started to play around with some toy examples and got stuck on the very >> beginning not being able to figure out where the unused functions are >> actually getting removed. >> >> Here is what I did: >> tu1.cpp: >> int unused(int a); >> int probably_inlined(int a); >> int main(int argc, const char *argv[]) { >> return probably_inlined(argc); >> } >> >> tu2.cpp: >> int unused(int a) { >> return a + 1; >> } >> int probably_inlined(int...

> I see. Using two comdats would still cause the same problem for us, > no? So the solution in the end is to emit: > > TU1: > -------------------------------- > @_ZN1UI1SE1kE = weak_odr constant i32 42, align 4, comdat _ZN1UI1SE1kE > @_ZGVN1UI1SE1kE = weak_odr global i64 1, comdat _ZN1UI1SE1kE > -------------------------------- > > TU2: > ----------------------------------- > @_ZN1UI1SE1kE = wea...

...bjects. > > We also need the IL linker itself needs to work on COMDATs too > otherwise this bug would still exist when doing LTO. > > In the "extended" example we would output > > @_ZN1UI1SE1kE = weak_odr constant i32 42, align 4, comdat _ZN1UI1SE1kE > > for TU1 and > > @_ZN1UI1SE1kE = weak_odr global i32 0, align 4, comdat _ZN1UI1SE1kE > ... > define internal void @_GLOBAL__I_a() nounwind section ".text.startup" > comdat _ZN1UI1SE1kE { > .... > } > > for TU2. Unfortunately, making the comdat be for the entire funct...

...t the variable > and its guard in different comdats or you put them in a single comdat > named for the variable.  It also doesn't actually help unless we disable > inlining. I see. Using two comdats would still cause the same problem for us, no? So the solution in the end is to emit: TU1: -------------------------------- @_ZN1UI1SE1kE = weak_odr constant i32 42, align 4, comdat _ZN1UI1SE1kE @_ZGVN1UI1SE1kE = weak_odr global i64 1, comdat _ZN1UI1SE1kE -------------------------------- TU2: ----------------------------------- @_ZN1UI1SE1kE = weak_odr global i32 0, align 4, comdat _ZN...

I tried a small variation: struct S { static const int x; }; template<typename T> struct U { static const int k; }; template<typename T> const int U<T>::k = T::x; #ifdef TU1 extern int f(); const int S::x = 42; int main() { return f() + reinterpret_cast<long>(&U<S>::k); } #endif #ifdef TU2 int f() { return U<S>::k; } #endif and it crashes with gcc too :-( The original testcase works because gcc folds the value into main even at -O0. If we are...

...create trivial COMDATs in codegen for weak objects. We also need the IL linker itself needs to work on COMDATs too otherwise this bug would still exist when doing LTO. In the "extended" example we would output @_ZN1UI1SE1kE = weak_odr constant i32 42, align 4, comdat _ZN1UI1SE1kE for TU1 and @_ZN1UI1SE1kE = weak_odr global i32 0, align 4, comdat _ZN1UI1SE1kE ... define internal void @_GLOBAL__I_a() nounwind section ".text.startup" comdat _ZN1UI1SE1kE { .... } for TU2. > Mach-O doesn't support anything like COMDAT, but the Darwin linker > apparently gives sig...

On Nov 7, 2011, at 9:47 AM, Richard Smith wrote: >> In cases where the C++ standard requires static initialization, >> introducing a write violates the guarantees of the C++ standard for static >> initialization. Therefore, I'm not sure the whole "make the constant >> writable" approach is actually viable. > > There is another problem which afflicts

...afael Espíndola <rafael.espindola at gmail.com>: > I tried a small variation: > > struct S { >  static const int x; > }; > template<typename T> struct U { >  static const int k; > }; > template<typename T> const int U<T>::k = T::x; > > #ifdef TU1 > extern int f(); > const int S::x = 42; > int main() { >  return f() + reinterpret_cast<long>(&U<S>::k); > } > #endif > #ifdef TU2 > int f() { return U<S>::k; } > #endif > > and it crashes with gcc too :-( The original testcase works because &...

Dear All Salam, Please go through the cfg file: Target[IP_Tu1]: Tunnel1:community at IP: SetEnv[IP_Tu1]: MRTG_INT_IP="IP" MRTG_INT_DESCR="Tunnel1" MaxBytes[IP_Tu1]: 1125 Title[IP_Tu1]: Tunnel1 -- yourdomain.com PageTop[IP_Tu1]: <H1>Tunnel1 -- yourdomain.com</H1> <TABLE> <TR><TD>System:</TD> <T...

...in different comdats or you put them in a single comdat >> named for the variable. It also doesn't actually help unless we disable >> inlining. > > I see. Using two comdats would still cause the same problem for us, > no? So the solution in the end is to emit: > > TU1: > -------------------------------- > @_ZN1UI1SE1kE = weak_odr constant i32 42, align 4, comdat _ZN1UI1SE1kE > @_ZGVN1UI1SE1kE = weak_odr global i64 1, comdat _ZN1UI1SE1kE > -------------------------------- > > TU2: > ----------------------------------- > @_ZN1UI1SE1kE = we...

...a at gmail.com>: >> I tried a small variation: >> >> >> struct S {  static const int x; >> }; >> template<typename T> struct U {  static const int k; >> }; >> template<typename T> const int U<T>::k = T::x; >> >> #ifdef TU1 >> extern int f(); const int S::x = 42; int main() {  return f() + >> reinterpret_cast<long>(&U<S>::k); >> } >> #endif >> #ifdef TU2 >> int f() { return U<S>::k; } #endif >> >> >> and it crashes with gcc too :-( The origina...

> >> On 2016-Apr-15, at 17:12, David Blaikie <dblaikie at gmail.com> wrote: >> >> >> >> On Fri, Apr 15, 2016 at 4:04 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: >> >> > On 2016-Apr-15, at 14:53, David Blaikie <dblaikie at gmail.com> wrote: >> > >> > >> > >> >> On Fri, Apr

v1 was here: https://www.redhat.com/archives/libguestfs/2018-December/thread.html#00123 v2: - Document "-" instead of "script=-" and use it in the test; and verify this also works on FreeBSD; and verify that it doesn't depend on the particular behaviour of our wrapper script and should work with installed nbdkit too. - Fix handling of zero flags parameter. -

Some feature additions to the shell script plugin allow us to test the export flags field reasonably easily. Rich.

...g for broken inet_ntoa... no checking for secure mkstemp... yes checking for sysconf(_SC_NGROUPS_MAX)... yes checking for root... yes checking for iface AIX... no checking for iface ifconf... got 3 interfaces: lo0 IP=127.0.0.1 NETMASK=255.0.0.0 tu0 IP=192.168.1.7 NETMASK=255.255.255.0 tu1 IP=192.168.250.1 NETMASK=255.255.255.0 yes checking for setresuid... no checking for setreuid... OK yes checking for working mmap... yes checking for ftruncate needs root... no checking for fcntl locking... yes checking for broken (glibc2.1/x86) 64 bit fcntl locking... no checking for 64 bit...

...dpJJBKJRBKGSMB113VhiPR9P0gUkkikPlMvoT3XO0U/HdOU +dljqH8mkUgkEokZ2AHUYXCEIRL2+akqqHJIpL5Sl6A94rzTh18dNYf2dDqVkeo2tMNR8GgT kEgkEqk7gj4WeloajkfLxu4nQlynCiGRVhFo11ERt5kiKVtAOxyCP0a0OqIJQkkkEqlEsd4V O1uCxt4LhkWe2JmfTLPZhL+wTxeFRFo1oX20iN0C2pHYGahTOyGRSKTuGXuxiyZu77GgzmFM ZNUOf+FjY6RwRUKqKxJpVYP20R0UjKCdETu1EBKJROpZLw19L1VFz4TOn2yk830fKN1xHHRu h7+wDyEQTnVFIhG09ye0M2cYah4kEonU446a/Nt7JqBx/ikJEZ3HeNhHjKe6IpHGGbRnTuoy RqGdiJ1EIpFGq6+meugZtPO13Ww2AdH54Q/2IQTCqa5IpHEP7f02EGhCO/lVkkgk0mj11eQh 00to5wc7ZmlnIWRpJ5HGAbTLJl0Upl6UTd7If5s+JJ1OZiKacdhAoD6EV66dh/2kSDZ5EolE Kldkae+ZhMlhmE87DnDwl3zaSaSxDu3AvczSrl4ISfZt...