Displaying 11 results from an estimated 11 matches for "ttm_bo_pin".
Did you mean:
ttm_bo_api
2020 Sep 29
2
[PATCH v2 4/4] drm/qxl: use qxl pin function
...-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index d3635e3e3267..eb45267d51db 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -145,7 +145,7 @@ int qxl_bo_create(struct qxl_device *qdev,
return r;
}
if (pinned)
- ttm_bo_pin(&bo->tbo);
+ qxl_bo_pin(bo);
*bo_ptr = bo;
return 0;
}
--
2.27.0
2020 Sep 29
2
[PATCH v2 4/4] drm/qxl: use qxl pin function
...-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index d3635e3e3267..eb45267d51db 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -145,7 +145,7 @@ int qxl_bo_create(struct qxl_device *qdev,
return r;
}
if (pinned)
- ttm_bo_pin(&bo->tbo);
+ qxl_bo_pin(bo);
*bo_ptr = bo;
return 0;
}
--
2.27.0
2020 Sep 29
0
[PATCH v2 4/4] drm/qxl: use qxl pin function
..._object.c b/drivers/gpu/drm/qxl/qxl_object.c
> index d3635e3e3267..eb45267d51db 100644
> --- a/drivers/gpu/drm/qxl/qxl_object.c
> +++ b/drivers/gpu/drm/qxl/qxl_object.c
> @@ -145,7 +145,7 @@ int qxl_bo_create(struct qxl_device *qdev,
> return r;
> }
> if (pinned)
> - ttm_bo_pin(&bo->tbo);
> + qxl_bo_pin(bo);
I think this is now after ttm_bo_init, and at that point the object is
visible to lru users and everything. So I do think you need to grab locks
here instead of just incrementing the pin count alone.
It's also I think a bit racy, since ttm_bo_init dro...
2020 Oct 07
2
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...quite
> a bit of the vram helper code for this more generic stuff. I also might
> have missed some special-cases here, but from a quick look everything
> just pins the buffer to the current location and that's it.
>
> Also this obviously requires Christian's generic ttm_bo_pin rework
> first.
>
> - roll the above out to drivers.
>
> Christian/Thomas, thoughts on this?
I agree on the goals, but what is the immediate objective here?
Adding ttm_bo_vmap() does not work out easily, as struct ttm_bo_kmap_obj
is a central part of the internals of TTM. struc...
2020 Oct 02
1
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...ite
> a bit of the vram helper code for this more generic stuff. I also might
> have missed some special-cases here, but from a quick look everything
> just pins the buffer to the current location and that's it.
>
> Also this obviously requires Christian's generic ttm_bo_pin rework
> first.
>
> - roll the above out to drivers.
>
> Christian/Thomas, thoughts on this?
Calling this vmap instead of kmap certainly makes sense.
Not 100% sure about the generic helpers, but it sounds like this should
indeed look rather clean in the end.
Christian.
>
&...
2020 Oct 07
2
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...helper code for this more generic stuff. I also might
>>> have missed some special-cases here, but from a quick look everything
>>> just pins the buffer to the current location and that's it.
>>>
>>> Also this obviously requires Christian's generic ttm_bo_pin rework
>>> first.
>>>
>>> - roll the above out to drivers.
>>>
>>> Christian/Thomas, thoughts on this?
>>
>> I agree on the goals, but what is the immediate objective here?
>>
>> Adding ttm_bo_vmap() does not work out easily, as...
2020 Sep 30
3
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
On Wed, Sep 30, 2020 at 2:34 PM Christian K?nig
<christian.koenig at amd.com> wrote:
>
> Am 30.09.20 um 11:47 schrieb Daniel Vetter:
> > On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian K?nig wrote:
> >> Am 30.09.20 um 10:19 schrieb Thomas Zimmermann:
> >>> Hi
> >>>
> >>> Am 30.09.20 um 10:05 schrieb Christian K?nig:
>
2020 Oct 07
1
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...f. I also might
> >>>> have missed some special-cases here, but from a quick look everything
> >>>> just pins the buffer to the current location and that's it.
> >>>>
> >>>> Also this obviously requires Christian's generic ttm_bo_pin rework
> >>>> first.
> >>>>
> >>>> - roll the above out to drivers.
> >>>>
> >>>> Christian/Thomas, thoughts on this?
> >>> I agree on the goals, but what is the immediate objective here?
> >>>
>...
2020 Oct 02
0
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...should allow us to ditch quite
a bit of the vram helper code for this more generic stuff. I also might
have missed some special-cases here, but from a quick look everything
just pins the buffer to the current location and that's it.
Also this obviously requires Christian's generic ttm_bo_pin rework
first.
- roll the above out to drivers.
Christian/Thomas, thoughts on this?
I think for the immediate need of rolling this out for vram helpers and
fbdev code we should be able to do this, but just postpone the driver wide
roll-out for now.
Cheers, Daniel
> -Daniel
>
> >...
2020 Oct 07
0
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...of the vram helper code for this more generic stuff. I also might
> > have missed some special-cases here, but from a quick look everything
> > just pins the buffer to the current location and that's it.
> >
> > Also this obviously requires Christian's generic ttm_bo_pin rework
> > first.
> >
> > - roll the above out to drivers.
> >
> > Christian/Thomas, thoughts on this?
>
> I agree on the goals, but what is the immediate objective here?
>
> Adding ttm_bo_vmap() does not work out easily, as struct ttm_bo_kmap_obj
> is...
2020 Oct 07
0
[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion
...is more generic stuff. I also might
>>>> have missed some special-cases here, but from a quick look everything
>>>> just pins the buffer to the current location and that's it.
>>>>
>>>> Also this obviously requires Christian's generic ttm_bo_pin rework
>>>> first.
>>>>
>>>> - roll the above out to drivers.
>>>>
>>>> Christian/Thomas, thoughts on this?
>>> I agree on the goals, but what is the immediate objective here?
>>>
>>> Adding ttm_bo_vmap() does...