search for: ttm_bo_manager

Commit a55409066 ("drm/nv50-: map TTM_PL_SYSTEM through a BAR for CPU access") made it possible to work with tiled memory. However mem->mm_node is not a nouveau_mem for AGP-using pre-NV50 cards, but a drm_mm_node, as created by the ttm_bo_manager_func. As such, extend the untiled check to explicitly include all pre-nv50 cards. Reported-by: Ronald <ronald645 at gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74613 Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- Hmmm... this seems like a really fragile...

...not make any assumption about what bo->mem.start actually contains. > OK. What about something like ttm_bo_pg_offset()? Same code without the > shift. Would also make it clear that it's a page offset. That is a rather good idea. We could name that ttm_bo_man_offset() and put it into ttm_bo_manager.c next to the manager which allocates them. It's just that this manager is not used by everybody, so amdgpu, radeon and nouveau would still need a separate function. Christian. > > Best regards > Thomas > >> Regards, >> Christian. >> >>> Best regards &...

...m/ttm/Makefile > index caea2a099496..aa772b198012 100644 > --- a/drivers/gpu/drm/ttm/Makefile > +++ b/drivers/gpu/drm/ttm/Makefile > @@ -5,7 +5,7 @@ > ttm-y := ttm_memory.o ttm_tt.o ttm_bo.o \ > ttm_bo_util.o ttm_bo_vm.o ttm_module.o \ > ttm_execbuf_util.o ttm_page_alloc.o ttm_bo_manager.o > -ttm-$(CONFIG_AGP) += ttm_agp_backend.o > +ttm-$(CONFIG_DRM_TTM_AGP) += ttm_agp_backend.o > ttm-$(CONFIG_DRM_TTM_DMA_PAGE_POOL) += ttm_page_alloc_dma.o > > obj-$(CONFIG_DRM_TTM) += ttm.o > -- > 2.17.1 > > _______________________________________________ > dri-...

...u/drm/ttm/Makefile b/drivers/gpu/drm/ttm/Makefile index caea2a099496..aa772b198012 100644 --- a/drivers/gpu/drm/ttm/Makefile +++ b/drivers/gpu/drm/ttm/Makefile @@ -5,7 +5,7 @@ ttm-y := ttm_memory.o ttm_tt.o ttm_bo.o \ ttm_bo_util.o ttm_bo_vm.o ttm_module.o \ ttm_execbuf_util.o ttm_page_alloc.o ttm_bo_manager.o -ttm-$(CONFIG_AGP) += ttm_agp_backend.o +ttm-$(CONFIG_DRM_TTM_AGP) += ttm_agp_backend.o ttm-$(CONFIG_DRM_TTM_DMA_PAGE_POOL) += ttm_page_alloc_dma.o obj-$(CONFIG_DRM_TTM) += ttm.o -- 2.17.1

...about what bo->mem.start actually contains. > > OK. What about something like ttm_bo_pg_offset()? Same code without the > > shift. Would also make it clear that it's a page offset. > > That is a rather good idea. We could name that ttm_bo_man_offset() and put > it into ttm_bo_manager.c next to the manager which allocates them. > > It's just that this manager is not used by everybody, so amdgpu, radeon and > nouveau would still need a separate function. Let me pile on with my bikeshed color choice :-) I'd do this a wrapper, but for drivers individually. And o...

Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in functionality since drivers will just fallback to the driver specific PCI GART. For now just deprecate the code and don't enable the AGP GART in TTM even when general AGP support is available. Please comment, Christian.

Am 18.02.20 um 19:16 schrieb Thomas Zimmermann: > Hi > > Am 18.02.20 um 18:13 schrieb Nirmoy: >> On 2/18/20 1:44 PM, Christian K?nig wrote: >>> Am 18.02.20 um 13:40 schrieb Thomas Zimmermann: >>>> Hi >>>> >>>> Am 17.02.20 um 16:04 schrieb Nirmoy Das: >>>>> GPU address handling is device specific and should be handle by its

Hi guys, Well let's face it AGP is a total headache to maintain and dead for at least 10+ years. We have a lot of x86 specific stuff in the architecture independent graphics memory management to get the caching right, abusing the DMA API on multiple occasions, need to distinct between AGP and driver specific page tables etc etc... So the idea here is to just go ahead and remove the support