search for: ttm_bo_kmap_obj

...<drm/drm_hashtab.h> > #include <drm/drm_vma_manager.h> > +#include <linux/dma-buf-map.h> > #include <linux/kref.h> > #include <linux/list.h> > #include <linux/wait.h> > @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct ttm_bo_kmap_obj *map, > return map->virtual; > } > > +/** > + * ttm_kmap_obj_to_dma_buf_map > + * > + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. > + * @map: Returns the mapping as struct dma_buf_map > + * > + * Converts struct ttm_bo_kmap_obj to struct dma...

...<drm/drm_hashtab.h> > #include <drm/drm_vma_manager.h> > +#include <linux/dma-buf-map.h> > #include <linux/kref.h> > #include <linux/list.h> > #include <linux/wait.h> > @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct ttm_bo_kmap_obj *map, > return map->virtual; > } > > +/** > + * ttm_kmap_obj_to_dma_buf_map > + * > + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. > + * @map: Returns the mapping as struct dma_buf_map > + * > + * Converts struct ttm_bo_kmap_obj to struct dma...

...<drm/drm_hashtab.h> > #include <drm/drm_vma_manager.h> > +#include <linux/dma-buf-map.h> > #include <linux/kref.h> > #include <linux/list.h> > #include <linux/wait.h> > @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct ttm_bo_kmap_obj *map, > return map->virtual; > } > > +/** > + * ttm_kmap_obj_to_dma_buf_map > + * > + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. > + * @map: Returns the mapping as struct dma_buf_map > + * > + * Converts struct ttm_bo_kmap_obj to struct dma...

...gt;>> +#include <linux/dma-buf-map.h> >>>> ? #include <linux/kref.h> >>>> ? #include <linux/list.h> >>>> ? #include <linux/wait.h> >>>> @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct >>>> ttm_bo_kmap_obj *map, >>>> ????? return map->virtual; >>>> ? } >>>> ? +/** >>>> + * ttm_kmap_obj_to_dma_buf_map >>>> + * >>>> + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. >>>> + * @map: Returns the mapping as s...

...>>>>>>>> itself uses VRAM helpers and doesn't touch the function directly. >>>>>>> Ah, ok can we have that then only in the VRAM helpers? >>>>>>> >>>>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj >>>>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. >>>>>>> >>>>>>> What I want to avoid is to have another conversion function in TTM because >>>>>>> what happens here is that we already convert from...

...and qxl. If we don't put it here, we > have to duplicate the functionality in each if these drivers. Bochs > itself uses VRAM helpers and doesn't touch the function directly. Ah, ok can we have that then only in the VRAM helpers? Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. What I want to avoid is to have another conversion function in TTM because what happens here is that we already convert from ttm_bus_placement to ttm_bo_kmap_obj and then to dma_buf_map. Thanks, Christian. > > Best regards >...

...in each if these drivers. Bochs >>>>>> itself uses VRAM helpers and doesn't touch the function directly. >>>>> Ah, ok can we have that then only in the VRAM helpers? >>>>> >>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj >>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. >>>>> >>>>> What I want to avoid is to have another conversion function in TTM because >>>>> what happens here is that we already convert from ttm_bus_placement to >>&g...

...t here, we > > have to duplicate the functionality in each if these drivers. Bochs > > itself uses VRAM helpers and doesn't touch the function directly. > > Ah, ok can we have that then only in the VRAM helpers? > > Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > > What I want to avoid is to have another conversion function in TTM because > what happens here is that we already convert from ttm_bus_placement to > ttm_bo_kmap_obj and then to dma_buf_map. Hm I'm not really seei...

...duplicate the functionality in each if these drivers. Bochs > >>> itself uses VRAM helpers and doesn't touch the function directly. > >> Ah, ok can we have that then only in the VRAM helpers? > >> > >> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > >> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > >> > >> What I want to avoid is to have another conversion function in TTM because > >> what happens here is that we already convert from ttm_bus_placement to > >> ttm_bo_kmap_obj and then...

...t;> itself uses VRAM helpers and doesn't touch the function directly. > >>>>>>>> Ah, ok can we have that then only in the VRAM helpers? > >>>>>>>> > >>>>>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > >>>>>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > >>>>>>>> > >>>>>>>> What I want to avoid is to have another conversion function in TTM because > >>>>>>>> what happens...

...; ? #include <drm/drm_vma_manager.h> >> +#include <linux/dma-buf-map.h> >> ? #include <linux/kref.h> >> ? #include <linux/list.h> >> ? #include <linux/wait.h> >> @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct >> ttm_bo_kmap_obj *map, >> ????? return map->virtual; >> ? } >> ? +/** >> + * ttm_kmap_obj_to_dma_buf_map >> + * >> + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. >> + * @map: Returns the mapping as struct dma_buf_map >> + * >> + * Converts str...

...;>>>>> itself uses VRAM helpers and doesn't touch the function directly. >>>>>>>> Ah, ok can we have that then only in the VRAM helpers? >>>>>>>> >>>>>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj >>>>>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. >>>>>>>> >>>>>>>> What I want to avoid is to have another conversion function in TTM because >>>>>>>> what happens here is that we alre...

...ivers. Bochs > >>>>>> itself uses VRAM helpers and doesn't touch the function directly. > >>>>> Ah, ok can we have that then only in the VRAM helpers? > >>>>> > >>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > >>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > >>>>> > >>>>> What I want to avoid is to have another conversion function in TTM because > >>>>> what happens here is that we already convert from ttm_bus_pla...

...in each if these drivers. Bochs >>>>>> itself uses VRAM helpers and doesn't touch the function directly. >>>>> Ah, ok can we have that then only in the VRAM helpers? >>>>> >>>>> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj >>>>> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. >>>>> >>>>> What I want to avoid is to have another conversion function in TTM because >>>>> what happens here is that we already convert from ttm_bus_placement to >>&g...

...>>> have to duplicate the functionality in each if these drivers. Bochs >>> itself uses VRAM helpers and doesn't touch the function directly. >> Ah, ok can we have that then only in the VRAM helpers? >> >> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj >> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. >> >> What I want to avoid is to have another conversion function in TTM because >> what happens here is that we already convert from ttm_bus_placement to >> ttm_bo_kmap_obj and then to dma_buf_map. > Hm...

...e <drm/drm_gem.h> #include <drm/drm_hashtab.h> #include <drm/drm_vma_manager.h> +#include <linux/dma-buf-map.h> #include <linux/kref.h> #include <linux/list.h> #include <linux/wait.h> @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct ttm_bo_kmap_obj *map, return map->virtual; } +/** + * ttm_kmap_obj_to_dma_buf_map + * + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. + * @map: Returns the mapping as struct dma_buf_map + * + * Converts struct ttm_bo_kmap_obj to struct dma_buf_map. If the memory + * is not mapped, the return...

...> #include <drm/drm_vma_manager.h> > > +#include <linux/dma-buf-map.h> > > #include <linux/kref.h> > > #include <linux/list.h> > > #include <linux/wait.h> > > @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct ttm_bo_kmap_obj *map, > > return map->virtual; > > } > > > > +/** > > + * ttm_kmap_obj_to_dma_buf_map > > + * > > + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. > > + * @map: Returns the mapping as struct dma_buf_map > > + * > >...

...ionality in each if these drivers. Bochs > > >>> itself uses VRAM helpers and doesn't touch the function directly. > > >> Ah, ok can we have that then only in the VRAM helpers? > > >> > > >> Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > > >> directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > > >> > > >> What I want to avoid is to have another conversion function in TTM because > > >> what happens here is that we already convert from ttm_bus_placement to > > >>...

...a_manager.h> >>> +#include <linux/dma-buf-map.h> >>> ? #include <linux/kref.h> >>> ? #include <linux/list.h> >>> ? #include <linux/wait.h> >>> @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(struct >>> ttm_bo_kmap_obj *map, >>> ????? return map->virtual; >>> ? } >>> ? +/** >>> + * ttm_kmap_obj_to_dma_buf_map >>> + * >>> + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. >>> + * @map: Returns the mapping as struct dma_buf_map >&gt...

...ated set of helpers to map an invidual page (again using the > dma_buf_map stuff). From a quick look, I'd say it should be possible to have the same interface for kmap/kunmap as for vmap/vunmap (i.e., parameters are bo and dma-buf-map). All mapping state can be deduced from this. And struct ttm_bo_kmap_obj can be killed off entirely. Best regards Thomas > > I'll let Christian with the details, but at a high level this is > definitely > > Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > Thanks a lot for doing all this. > -Daniel > > > > >...