search for: transfer_map

...fer_state doesn't allow an error to be returned. Should I >> just print a warning and move on? > > Yes, because you have no other choice. > >> >> I guess I'm still not 100% on all the terminology -- what do you mean >> exactly by bind/unbind? Do you mean the transfer_map/unmap stuff? So >> basically I would blit once on set_framebuffer_state, and then blit >> back and forth on resource map/unmap, and only ever render to the >> "temporary" buffer without worrying about blitting wihle rendering? > > "bind" is when a buffer...

...uffer which matches the colorbuffer format. When unbinding, > blit back. set_framebuffer_state doesn't allow an error to be returned. Should I just print a warning and move on? I guess I'm still not 100% on all the terminology -- what do you mean exactly by bind/unbind? Do you mean the transfer_map/unmap stuff? So basically I would blit once on set_framebuffer_state, and then blit back and forth on resource map/unmap, and only ever render to the "temporary" buffer without worrying about blitting wihle rendering? > > You can also drop support for 16-bit formats. I assumed tha...

...uld I >>>> just print a warning and move on? >>> >>> Yes, because you have no other choice. >>> >>>> >>>> I guess I'm still not 100% on all the terminology -- what do you mean >>>> exactly by bind/unbind? Do you mean the transfer_map/unmap stuff? So >>>> basically I would blit once on set_framebuffer_state, and then blit >>>> back and forth on resource map/unmap, and only ever render to the >>>> "temporary" buffer without worrying about blitting wihle rendering? >>> >&gt...

...back. > > set_framebuffer_state doesn't allow an error to be returned. Should I > just print a warning and move on? Yes, because you have no other choice. > > I guess I'm still not 100% on all the terminology -- what do you mean > exactly by bind/unbind? Do you mean the transfer_map/unmap stuff? So > basically I would blit once on set_framebuffer_state, and then blit > back and forth on resource map/unmap, and only ever render to the > "temporary" buffer without worrying about blitting wihle rendering? "bind" is when a buffer is set, "unbind&...

...an error to be returned. Should I >>> just print a warning and move on? >> >> Yes, because you have no other choice. >> >>> >>> I guess I'm still not 100% on all the terminology -- what do you mean >>> exactly by bind/unbind? Do you mean the transfer_map/unmap stuff? So >>> basically I would blit once on set_framebuffer_state, and then blit >>> back and forth on resource map/unmap, and only ever render to the >>> "temporary" buffer without worrying about blitting wihle rendering? >> >> "bind&quo...

...+ const void *data, int data_size) +{ + struct nv04_resource *buf = nv04_resource(res); + struct pipe_transfer *pt; + struct pipe_box box; + unsigned elements, i; + + elements = size / data_size; + + u_box_1d(0, size, &box); + + uint8_t *map = buf->vtbl->transfer_map(pipe, res, 0, PIPE_TRANSFER_WRITE, + &box, &pt); + + for (i = 0; i < elements; ++i) + memcpy(&map[i*data_size], data, data_size); + + buf->vtbl->transfer_unmap(pipe, pt); +} + +static void +nvc0_clear_buffer(struct pipe_context...

...const void *data, int data_size) +{ + struct nv04_resource *buf = nv04_resource(res); + struct pipe_transfer *pt; + struct pipe_box box; + unsigned elements, i; + + elements = size / data_size; + + u_box_1d(0, size, &box); + + uint8_t *tf_map = buf->vtbl->transfer_map(pipe, res, + 0, PIPE_TRANSFER_WRITE, &box, &pt); + + for (i = 0; i < elements ; ++i) { + memcpy(&tf_map[i*data_size], data, data_size); + } + buf->vtbl->transfer_unmap(pipe, pt); +} + +static void +nvc0_clear_buffer(struct pipe_context *pipe, +...

Hi, please review the following patch! Thanks, Tobias Klausmann

https://bugs.freedesktop.org/show_bug.cgi?id=97568 Bug ID: 97568 Summary: read pixels of MSAAx8 surface stretched horizontally/vertically Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium

...+ nouveau_fence_wait(buf->fence_wr); + + memcpy(&color.ui, data, 12); + memset(&color.ui[3], 0, 4); + + elements = size / data_size; + + memset(&pb, 0, sizeof(pb)); + pb.height = elements; + pb.width = 1; + + uint8_t *tf_map = buf->vtbl->transfer_map(pipe, res, + 0, PIPE_TRANSFER_WRITE, &pb, &pt); + + for (i = 0; i < elements ; ++i) { + memcpy(&tf_map[i*12],color.f,12); + } + buf->vtbl->transfer_unmap(pipe, pt); +} + +static void +nvc0_clear_buffer(struct pipe_context *pipe, +...

Hello, I attempted doing this a while back, before I really understood what was going on. I got some advice that went totally over my head, and I dropped the issue. I think I'm much better-prepared to tackle the issue this time around. To recap, nv30 (and nv40) hw can't handle certain color/depth format combinations. Specifically, a 16-bit color format must be paired with a 16-bit depth

..._surface(pscreen, tx_tex, - face, level, zslice, + 0, 0, 0, pipe_transfer_buffer_flags(&tx->base)); pipe_texture_reference(&tx_tex, NULL); @@ -150,13 +156,22 @@ nv04_transfer_map(struct pipe_screen *pscreen, struct pipe_transfer *ptx) struct nv04_transfer *tx = (struct nv04_transfer *)ptx; struct nv04_surface *ns = (struct nv04_surface *)tx->surface; struct nv04_miptree *mt = (struct nv04_miptree *)tx->surface->texture; - void *map = pipe_buffer_map(pscreen,...

..._surface(pscreen, tx_tex, - face, level, zslice, + 0, 0, 0, pipe_transfer_buffer_flags(&tx->base)); pipe_texture_reference(&tx_tex, NULL); @@ -150,13 +156,22 @@ nv04_transfer_map(struct pipe_screen *pscreen, struct pipe_transfer *ptx) struct nv04_transfer *tx = (struct nv04_transfer *)ptx; struct nv04_surface *ns = (struct nv04_surface *)tx->surface; struct nv04_miptree *mt = (struct nv04_miptree *)tx->surface->texture; - void *map = pipe_buffer_map(pscreen,...

...ce) > +{ > + struct tegra_resource *resource = to_tegra_resource(presource); > + struct tegra_context *context = to_tegra_context(pcontext); > + > + context->gpu->flush_resource(context->gpu, resource->gpu); > +} > + > +static void * > +tegra_transfer_map(struct pipe_context *pcontext, > + struct pipe_resource *presource, > + unsigned level, > + unsigned usage, > + const struct pipe_box *box, > + struct pipe_transfer **ptransfer) > +{ > +...

...t pipe_context *pcontext, + struct pipe_resource *presource) +{ + struct tegra_resource *resource = to_tegra_resource(presource); + struct tegra_context *context = to_tegra_context(pcontext); + + context->gpu->flush_resource(context->gpu, resource->gpu); +} + +static void * +tegra_transfer_map(struct pipe_context *pcontext, + struct pipe_resource *presource, + unsigned level, + unsigned usage, + const struct pipe_box *box, + struct pipe_transfer **ptransfer) +{ + struct tegra_resource *resource = to_tegra_resource(presource); + struct tegra_context *context = to_tegra...

https://bugs.freedesktop.org/show_bug.cgi?id=102349 Bug ID: 102349 Summary: nv4x crashing with plasmashell - gdb log included Product: xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker Priority: medium Component: Driver/nouveau