search for: transaction_kthread

upstream commit 2ad49887150894b9ed6a87a76b409adceee6b074 Motivated from the commit, I found that cleaner_kthread() and transaction_kthread() can result similar error since these two function can exit even though kthread_should_stop() is not true. In order to resolve the bug, break statements are changed into continue statements in order to wait until kthread_should_stop() becomes true. --- a/fs/btrfs/async-thread.c +++ b/fs/btrfs/a...

...info->system_alloc_profile = fs_info->metadata_alloc_profile; fs_info->cleaner_kthread = kthread_run(cleaner_kthread, tree_root, "btrfs-cleaner"); - if (!fs_info->cleaner_kthread) + if (IS_ERR(fs_info->cleaner_kthread)) goto fail_csum_root; fs_info->transaction_kthread = kthread_run(transaction_kthread, tree_root, "btrfs-transaction"); - if (!fs_info->transaction_kthread) + if (IS_ERR(fs_info->transaction_kthread)) goto fail_cleaner; if (btrfs_super_log_root(disk_super) != 0) { -- To unsubscribe from this list: send the...

...May 5 14:15:14 mail kernel: [13560.752122] [<ffffffffa0860fa3>] btrfs_commit_transaction+0x263/0x750 [btrfs] May 5 14:15:14 mail kernel: [13560.752126] [<ffffffff81079ff0>] ? autoremove_wake_function+0x0/0x40 May 5 14:15:14 mail kernel: [13560.752131] [<ffffffffa085a9bd>] transaction_kthread+0x26d/0x290 [btrfs] May 5 14:15:14 mail kernel: [13560.752137] [<ffffffffa085a750>] ? transaction_kthread+0x0/0x290 [btrfs] May 5 14:15:14 mail kernel: [13560.752139] [<ffffffff81079717>] kthread+0x87/0x90 May 5 14:15:14 mail kernel: [13560.752142] [<ffffffff8100bc24>] ke...

...fff811e7f6b>] ? btrfs_run_delayed_refs+0x10d/0x289 kernel: [<ffffffff811f4ec6>] ? btrfs_commit_transaction+0x3a5/0x93c kernel: [<ffffffff810427f0>] ? abort_exclusive_wait+0x79/0x79 kernel: [<ffffffff811f5a8c>] ? start_transaction+0x311/0x408 kernel: [<ffffffff811eed7e>] ? transaction_kthread+0xd1/0x16d kernel: [<ffffffff811eecad>] ? btrfs_alloc_root+0x34/0x34 kernel: [<ffffffff810420b3>] ? kthread+0xad/0xb5 kernel: [<ffffffff81042006>] ? __kthread_parkme+0x5e/0x5e kernel: [<ffffffff814315ac>] ? ret_from_fork+0x7c/0xb0 kernel: [<ffffffff81042006>] ? __kthre...

...} else { - smp_mb(); - if (root->fs_info->closing) - break; set_current_state(TASK_INTERRUPTIBLE); - schedule(); + if (!kthread_should_stop()) + schedule(); __set_current_state(TASK_RUNNING); } } while (!kthread_should_stop()); @@ -1504,36 +1498,39 @@ static int transaction_kthread(void *arg struct btrfs_root *root = arg; struct btrfs_trans_handle *trans; struct btrfs_transaction *cur; + u64 transid; unsigned long now; unsigned long delay; int ret; do { - smp_mb(); - if (root->fs_info->closing) - break; - delay = HZ * 30; vfs_check_frozen(root-...

...0 [btrfs] Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffff815a7dbe>] ? mutex_lock+0x1e/0x50 Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffff81085b70>] ? autoremove_wake_function+0x0/0x40 Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffffa01f3762>] transaction_kthread+0x242/0x250 [btrfs] Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffffa01f3520>] ? transaction_kthread+0x0/0x250 [btrfs] Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffff81085497>] kthread+0x97/0xa0 Jan 6 16:58:36 repository kernel: [ 146.190020] [<ffffffff8100...

...ction+0x363/0x760 > >>>> Feb 14 00:39:20 lupus kernel: [ 2951.854344]  [<ffffffff81067ea0>] > ? > >>>> autoremove_wake_function+0x0/0x30 > >>>> Feb 14 00:39:20 lupus kernel: [ 2951.854364]  [<ffffffff81305bc3>] > ? > >>>> transaction_kthread+0x283/0x2a0 > >>>> Feb 14 00:39:20 lupus kernel: [ 2951.854383]  [<ffffffff81305940>] > ? > >>>> transaction_kthread+0x0/0x2a0 > >>>> Feb 14 00:39:20 lupus kernel: [ 2951.854401]  [<ffffffff81305940>] > ? > >>>> transacti...

...gt;] commit_fs_roots.isra.24+0x99/0x153 [<ffffffff814c1ed6>] ? _raw_spin_lock+0x1b/0x1f [<ffffffff814c2059>] ? _raw_spin_unlock+0x27/0x32 [<ffffffff811e47e8>] btrfs_commit_transaction+0x45a/0x954 [<ffffffff8105d4be>] ? add_wait_queue+0x44/0x44 [<ffffffff811de8a6>] transaction_kthread+0xe7/0x18a [<ffffffff811de7bf>] ? try_to_freeze+0x33/0x33 [<ffffffff8105cc31>] kthread+0x88/0x90 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0x39 [<ffffffff814c6b3c>] ret_from_fork+0x7c/0xb0 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0...

Hi, Recently, I made a btrfs to use. And I met slowness problem. Trying to diag it. I found this: 1. dd if=/dev/zero of=test count=1024 bs=1MB This is fast, at about 25MB/s, and reasonable iowait. 2. dd if=/dev/zero of=test count=1 bs=1GB This is pretty slow, at about 1.5MB/s, and 90%+ iowait, constantly. May I know why it works like this? Thanks. -- To unsubscribe from this list: send the

...ates a huge amount of btrfs_delalloc_work structures, and I start seeing OOM messages in the kernel log, killing processes etc. During that time this transaction commit is stuck, so, for example, other requests to create snapshot (that must wait for this transaction to commit first) get stuck. The transaction_kthread also gets stuck in attempt to commit the transaction. Is this an intended behavior? Shouldn''t we ensure that every inode in the delalloc list gets handled at most once? If the delalloc work is processed asynchronously, maybe the delalloc list can be locked once and traversed once? Josef,...

...trfs] Apr 29 12:59:31 ewzw032 kernel: [ 6275.016598] [<ffffffffa00cc4ec>] btrfs_commit_transaction+0x62c/0xb00 [btrfs] Apr 29 12:59:31 ewzw032 kernel: [ 6275.016601] [<ffffffff81080070>] ? finish_wait+0x80/0x80 Apr 29 12:59:31 ewzw032 kernel: [ 6275.016610] [<ffffffffa00c54cd>] transaction_kthread+0x1ad/0x230 [btrfs] Apr 29 12:59:31 ewzw032 kernel: [ 6275.016620] [<ffffffffa00c5320>] ? write_dev_flush.part.107+0xc0/0xc0 [btrfs] Apr 29 12:59:31 ewzw032 kernel: [ 6275.016622] [<ffffffff8107f890>] kthread+0xc0/0xd0 Apr 29 12:59:31 ewzw032 kernel: [ 6275.016624] [<ffffffff8107f...

Hello, I got a kernel bug error, my guess from BTRFS. Here is the report, Oct 22 20:44:43 localhost kernel: [25554.947970] BUG: unable to handle kernel NULL pointer dereference at 0000000000000030 Oct 22 20:44:43 localhost kernel: [25554.948002] IP: [<ffffffffa01ab027>] btrfs_print_leaf+0x37/0x880 [btrfs] Oct 22 20:44:43 localhost kernel: [25554.948037] PGD bfa44067 PUD bfa43067 PMD 0 Oct

...7] 0000000000000000 00000000af2b0560 ffff8801aff2ce60 ffff8801b13ab000 [11558.528863] Call Trace: [11558.528879] [<ffffffff81088d80>] ? abort_exclusive_wait+0xb0/0xb0 [11558.528910] [<ffffffffa014ccd4>] ? start_transaction+0x94/0x2b0 [btrfs] [11558.528940] [<ffffffffa0144e6d>] transaction_kthread+0x26d/0x290 [btrfs] [11558.528971] [<ffffffffa0144c00>] ? btrfs_congested_fn+0xd0/0xd0 [btrfs] [11558.528996] [<ffffffff8108843c>] kthread+0x8c/0xa0 [11558.529018] [<ffffffff8145feb4>] kernel_thread_helper+0x4/0x10 [11558.529040] [<ffffffff810883b0>] ? kthread_worker_fn+...

Running an Ubuntu Raring VM which was built a week ago that is now running 3.8-rc6, I was booting it last night when it hung. After a few forced reboots, it came back up and I found the attached in kern.log. Mostly, the VM has been used for testing anisble deployment, so not a lot of work, just upgrading and installing software, then rebooting. Are these reports useful? Is there any

.../0x3d0 [btrfs] [ 386.319281] [<ffffffffa00db100>] btrfs_run_delayed_refs+0xf0/0x2d0 [btrfs] [ 386.319317] [<ffffffffa00ec555>] btrfs_commit_transaction+0xa5/0x9c0 [btrfs] [ 386.319325] [<ffffffff8107ccd0>] ? add_wait_queue+0x60/0x60 [ 386.319359] [<ffffffffa00e6a65>] transaction_kthread+0x1b5/0x230 [btrfs] [ 386.319393] [<ffffffffa00e68b0>] ? btrfs_destroy_delayed_refs.isra.103+0x210/0x210 [btrfs] [ 386.319400] [<ffffffff8107c3f3>] kthread+0x93/0xa0 [ 386.319407] [<ffffffff816a7a84>] kernel_thread_helper+0x4/0x10 [ 386.319414] [<ffffffff8107c360>] ?...

..._write+0x9a/0xf0 [ 413.409157] [<ffffffff8104e2d7>] ? remove_wait_queue+0x3a/0x3a [ 413.409157] [<ffffffffa019018e>] btrfs_run_defrag_inodes+0x20a/0x327 [btrfs] [ 413.409157] [<ffffffffa017a6c1>] cleaner_kthread+0x95/0x122 [btrfs] [ 413.409157] [<ffffffffa017a62c>] ? transaction_kthread+0x1a0/0x1a0 [btrfs] [ 413.409157] [<ffffffff8104da7c>] kthread+0xba/0xc2 [ 413.409157] [<ffffffff8104d9c2>] ? kthread_freezable_should_stop+0x52/0x52 [ 413.409157] [<ffffffff8161fd1c>] ret_from_fork+0x7c/0xb0 [ 413.409157] [<ffffffff8104d9c2>] ? kthread_freezable_sho...

...[btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffffa050448f>] btrfs_commit_transaction+0x3bf/0x840 [btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8108c230>] ? add_wait_queue+0x60/0x60 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffffa04fd3b5>] transaction_kthread+0x265/0x280 [btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffffa04fd150>] ? btrfs_congested_fn+0xb0/0xb0 [btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8108b78c>] kthread+0x8c/0xa0 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8166ae74>] ker...

...0x17c [btrfs] [<ffffffffa02f8467>] ? btrfs_commit_transaction+0x38f/0x709 [btrfs] [<ffffffff8136f6e6>] ? _raw_spin_lock+0xe/0x10 [<ffffffffa02f79fe>] ? join_transaction.clone.23+0xc1/0x200 [btrfs] [<ffffffff81068ffb>] ? wake_up_bit+0x2a/0x2a [<ffffffffa02f28fd>] ? transaction_kthread+0x175/0x22a [btrfs] [<ffffffffa02f2788>] ? btrfs_congested_fn+0x86/0x86 [btrfs] [<ffffffff81068b2c>] ? kthread+0x82/0x8a [<ffffffff81376124>] ? kernel_thread_helper+0x4/0x10 [<ffffffff81068aaa>] ? kthread_worker_fn+0x14c/0x14c [<ffffffff81376120>] ? gs_change+0x13...

I noticed a huge problem with the free space cache that was presenting as an early ENOSPC. Turns out when writing the free space cache out I forgot to take into account pinned extents and more importantly clusters. This would result in us leaking free space everytime we unmounted the filesystem and remounted it. I fix this by making sure to check and see if the current block group has a cluster

...nel: [121691.704328]  [] ? btrfs_run_delayed_refs+0xcd/0x1c0 [btrfs] Mar  9 23:59:47 ftp2 kernel: [121691.704343]  [] ? btrfs_commit_transaction+0x7e/0x61e [btrfs] Mar  9 23:59:47 ftp2 kernel: [121691.704349]  [] ? autoremove_wake_function+0x0/0x2a Mar  9 23:59:47 ftp2 kernel: [121691.704363]  [] ? transaction_kthread+0x16d/0x214 [btrfs] Mar  9 23:59:47 ftp2 kernel: [121691.704376]  [] ? transaction_kthread+0x0/0x214 [btrfs] Mar  9 23:59:47 ftp2 kernel: [121691.704389]  [] ? transaction_kthread+0x0/0x214 [btrfs] Mar  9 23:59:47 ftp2 kernel: [121691.704394]  [] ? kthread+0x7a/0x82 Mar  9 23:59:47 ftp2 kernel: [12...