search for: trace_virtio_transport_alloc_pkt

On 2016?12?06? 23:41, Michael S. Tsirkin wrote: > virtio_transport_alloc_pkt is only used locally, make it static. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c

On 2016?12?06? 23:41, Michael S. Tsirkin wrote: > virtio_transport_alloc_pkt is only used locally, make it static. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c

...nsport); > > } > > -struct virtio_vsock_pkt * > > +static struct virtio_vsock_pkt * > > virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > > size_t len, > > u32 src_cid, > > Git grep shows it was used by tracing. True but trace_virtio_transport_alloc_pkt is also local to virtio_transport_common.c -- MST

...+ buf = kmalloc(len, GFP_KERNEL); + if (!buf) goto out_pkt; - err = memcpy_from_msg(pkt->buf, info->msg, len); + err = memcpy_from_msg(buf, info->msg, len); if (err) goto out; + + pkt->vec[0].iov_base = buf; + pkt->vec[0].iov_len = len; + pkt->nr_vecs = 1; } trace_virtio_transport_alloc_pkt(src_cid, src_port, @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) return pkt; out: - kfree(pkt->buf); + kfree(buf); out_pkt: kfree(pkt); return NULL; @@ -92,6 +97,7 @@ static struct sk_buff *virtio_transport_build_skb(void *opaque) struct virtio...

...+ buf = kmalloc(len, GFP_KERNEL); + if (!buf) goto out_pkt; - err = memcpy_from_msg(pkt->buf, info->msg, len); + err = memcpy_from_msg(buf, info->msg, len); if (err) goto out; + + pkt->vec[0].iov_base = buf; + pkt->vec[0].iov_len = len; + pkt->nr_vecs = 1; } trace_virtio_transport_alloc_pkt(src_cid, src_port, @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) return pkt; out: - kfree(pkt->buf); + kfree(buf); out_pkt: kfree(pkt); return NULL; @@ -92,6 +97,7 @@ static struct sk_buff *virtio_transport_build_skb(void *opaque) struct virtio...

...g(pkt->buf, info->msg, len); >> + err = memcpy_from_msg(buf, info->msg, len); >> if (err) >> goto out; >> + >> + pkt->vec[0].iov_base = buf; >> + pkt->vec[0].iov_len = len; >> + pkt->nr_vecs = 1; >> } >> >> trace_virtio_transport_alloc_pkt(src_cid, src_port, >> @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) >> return pkt; >> >> out: >> - kfree(pkt->buf); >> + kfree(buf); >> out_pkt: >> kfree(pkt); >> return NULL; >> @@ -92,6...

...g(pkt->buf, info->msg, len); >> + err = memcpy_from_msg(buf, info->msg, len); >> if (err) >> goto out; >> + >> + pkt->vec[0].iov_base = buf; >> + pkt->vec[0].iov_len = len; >> + pkt->nr_vecs = 1; >> } >> >> trace_virtio_transport_alloc_pkt(src_cid, src_port, >> @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) >> return pkt; >> >> out: >> - kfree(pkt->buf); >> + kfree(buf); >> out_pkt: >> kfree(pkt); >> return NULL; >> @@ -92,6...

...o out_pkt; > - err = memcpy_from_msg(pkt->buf, info->msg, len); > + err = memcpy_from_msg(buf, info->msg, len); > if (err) > goto out; > + > + pkt->vec[0].iov_base = buf; > + pkt->vec[0].iov_len = len; > + pkt->nr_vecs = 1; > } > > trace_virtio_transport_alloc_pkt(src_cid, src_port, > @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > return pkt; > > out: > - kfree(pkt->buf); > + kfree(buf); > out_pkt: > kfree(pkt); > return NULL; > @@ -92,6 +97,7 @@ static struct sk_buff *virtio...

...err = memcpy_from_msg(buf, info->msg, len); > >> if (err) > >> goto out; > >> + > >> + pkt->vec[0].iov_base = buf; > >> + pkt->vec[0].iov_len = len; > >> + pkt->nr_vecs = 1; > >> } > >> > >> trace_virtio_transport_alloc_pkt(src_cid, src_port, > >> @@ -80,7 +85,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > >> return pkt; > >> > >> out: > >> - kfree(pkt->buf); > >> + kfree(buf); > >> out_pkt: > >> kfree(pkt); &...

This series is based on Michael Tsirkin's vhost branch (v4.5-rc6). I'm about to process Claudio Imbrenda's locking fixes for virtio-vsock but first I want to share the latest version of the code. Several people are playing with vsock now so sharing the latest code should avoid duplicate work. v5: * Transport reset event for live migration support * Reorder virtqueues, drop unused

This series is based on Michael Tsirkin's vhost branch (v4.5-rc6). I'm about to process Claudio Imbrenda's locking fixes for virtio-vsock but first I want to share the latest version of the code. Several people are playing with vsock now so sharing the latest code should avoid duplicate work. v5: * Transport reset event for live migration support * Reorder virtqueues, drop unused

This series is based on v4.7. This RFC is the implementation for the new VIRTIO Socket device. It is developed in parallel with the VIRTIO device specification and proves the design. Once the specification has been accepted I will send a non-RFC version of this patch series. v6: * Add VHOST_VSOCK_SET_RUNNING ioctl to start/stop vhost cleanly * Add graceful shutdown to avoid port reuse while

This series is based on v4.7. This RFC is the implementation for the new VIRTIO Socket device. It is developed in parallel with the VIRTIO device specification and proves the design. Once the specification has been accepted I will send a non-RFC version of this patch series. v6: * Add VHOST_VSOCK_SET_RUNNING ioctl to start/stop vhost cleanly * Add graceful shutdown to avoid port reuse while

This series is based on v4.4-rc2 and the "virtio: make find_vqs() checkpatch.pl-friendly" patch I recently submitted. v4: * Addressed code review comments from Alex Bennee * MAINTAINERS file entries for new files * Trace events instead of pr_debug() * RST packet is sent when there is no listen socket * Allow guest->host connections again (began discussing netfilter support with

This series is based on v4.4-rc2 and the "virtio: make find_vqs() checkpatch.pl-friendly" patch I recently submitted. v4: * Addressed code review comments from Alex Bennee * MAINTAINERS file entries for new files * Trace events instead of pr_debug() * RST packet is sent when there is no listen socket * Allow guest->host connections again (began discussing netfilter support with