search for: trace_flag

From: Maros Zatko <mzatko@redhat.com> Patch adds recursive mutex around C calls, which tries to fix potential race condition in guestfs_umount_local (see [1]). [1] - https://bugzilla.redhat.com/show_bug.cgi?id=917706 Maros Zatko (1): generator: c.ml - wrap non deamon function with recursive mutex generator/c.ml | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 1.8.5.3

--- generator/generator_c.ml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/generator/generator_c.ml b/generator/generator_c.ml index 4324ec0..9cfb2b7 100644 --- a/generator/generator_c.ml +++ b/generator/generator_c.ml @@ -1187,7 +1187,7 @@ trace_send_line (guestfs_h *g) let n = name_of_optargt argt in let uc_shortname = String.uppercase

...anups.h file. *) > @@ -1567,6 +1574,8 @@ and generate_client_actions hash () = > c_name style; > pr "{\n"; > > + pr " gl_recursive_lock_lock (global_lock);\n"; > + > handle_null_optargs optargs c_name; > > pr " int trace_flag = g->trace;\n"; > @@ -1617,6 +1626,9 @@ and generate_client_actions hash () = > trace_return name style "r"; > ); > pr "\n"; > + > + pr " gl_recursive_lock_unlock (global_lock);\n"; > + > pr " return r;\n&...

Previously posted in 2015: v1: https://www.redhat.com/archives/libguestfs/2015-June/msg00048.html v2: https://www.redhat.com/archives/libguestfs/2015-June/msg00118.html I have rebased and tidied up the patches, fixing a few spelling mistakes, but they are broadly the same as before. I also ran all the tests, which pass. As with the previous versions, this makes a change to the API, where you

...} -> generate_prototype ~single_line:true ~newline:true ~handle:"g" @@ -1569,6 +1572,9 @@ and generate_client_actions hash () = handle_null_optargs optargs c_name; + pr " guestfs___per_handle_lock_lock (g);\n"; + pr "\n"; + pr " int trace_flag = g->trace;\n"; pr " struct trace_buffer trace_buffer;\n"; (match ret with @@ -1617,6 +1623,10 @@ and generate_client_actions hash () = trace_return name style "r"; ); pr "\n"; + + pr " guestfs___per_handle_lock_unlock (g);\...

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.

Hi, this patch serie adds a new GUID type in the generator, which would do the same as String, but also validating (just in the C output) the passed GUID string. This allows to reject invalid GUIDs before passing them to low-level tools. Pino Toscano (4): utils: add a function to validate a GUID string generator: add a GUID parameter type generator: generate code for parameter validation

...t;%%s:%%s\\\"\", \"%s\", optargs->%s);\n" n n @@ -1614,7 +1616,7 @@ and generate_client_actions actions () = in let trace_return ?(indent = 2) name (ret, _, _) rv = - let indent = spaces indent in + let indent = String.spaces indent in pr "%sif (trace_flag) {\n" indent; @@ -1679,7 +1681,7 @@ and generate_client_actions actions () = in let trace_return_error ?(indent = 2) name (ret, _, _) errcode = - let indent = spaces indent in + let indent = String.spaces indent in pr "%sif (trace_flag)\n" indent; @@ -1876,7...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.