search for: trace_buffer

...StringList _ | RHashtable _ | RStructList _ -> true | _ -> false in if needs_i then ( pr "%s size_t i;\n" indent; @@ -1656,15 +1657,25 @@ and generate_client_actions hash () = pr "%s }\n" indent; pr "%s fputs (\"]\", trace_buffer.fp);\n" indent; | RStruct (_, typ) -> - (* XXX There is code generated for guestfish for printing - * these structures. We need to make it generally available - * for all callers - *) - pr "%s fprintf (trace_buffer.fp, \"<struc...

Extend the generator to generate a source (and the header for it) with functions that print the content of a guestfs struct. The code is modelled after the code for it in fish.ml, although made a bit more generic (destination FILE*, line separator) so it can be used also in the library, when tracing. This just introduces the new code and builds it as part of the helper libutils.la. ---

...ce_diff (test); /* FIXME: produce a diff here */ - swfdec_test_throw (SWFDEC_AS_OBJECT (test)->context, "invalid trace output"); + swfdec_test_throw (SWFDEC_AS_OBJECT (test)->context, "invalid trace output:\n%s", diff); + g_free (diff); } if (test->trace_buffer) { @@ -68,6 +108,9 @@ swfdec_test_test_trace_stop (SwfdecTestTest *test) } g_free (test->trace_filename); test->trace_filename = NULL; + g_slist_foreach (test->trace_captured, (GFunc) g_free, NULL); + g_slist_free (test->trace_captured); + test->trace_captured = NULL; }...

Previously posted in 2015: v1: https://www.redhat.com/archives/libguestfs/2015-June/msg00048.html v2: https://www.redhat.com/archives/libguestfs/2015-June/msg00118.html I have rebased and tidied up the patches, fixing a few spelling mistakes, but they are broadly the same as before. I also ran all the tests, which pass. As with the previous versions, this makes a change to the API, where you

...ne:true ~handle:"g" @@ -1569,6 +1572,9 @@ and generate_client_actions hash () = handle_null_optargs optargs c_name; + pr " guestfs___per_handle_lock_lock (g);\n"; + pr "\n"; + pr " int trace_flag = g->trace;\n"; pr " struct trace_buffer trace_buffer;\n"; (match ret with @@ -1617,6 +1623,10 @@ and generate_client_actions hash () = trace_return name style "r"; ); pr "\n"; + + pr " guestfs___per_handle_lock_unlock (g);\n"; + pr "\n"; + pr " return r;...

...return 0; + } + case SET_SHARE_PARAM_MAP: + { + int rc = map_param_share_page(arg1, arg2); + DPRINTK("SET_SHAER_PARAM_MAP: gva=%lx\n",arg1); + return rc; + } + + } + return 0L; +} +#endif /* CONFIG_VMX */ #ifdef TRACE_BUFFER asmlinkage void trace_vmentry (void) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...| StringList _ | DeviceList _ | RelativePathnameList _ -> true | _ -> false) args || List.exists (function | OStringList _ -> true @@ -1419,7 +1437,8 @@ and generate_client_actions hash () = pr " else\n"; pr " fprintf (trace_buffer.fp, \" null\");\n" | StringList n - | DeviceList n -> (* string list *) + | DeviceList n + | RelativePathnameList n -> (* string list *) pr " fputc (' ', trace_buffer.fp);\n"; pr " fputc ('\"&...

...; true + | StringList _ | DeviceList _ | FilenameList _ -> true | _ -> false) args || List.exists (function | OStringList _ -> true @@ -1419,7 +1437,8 @@ and generate_client_actions hash () = pr " else\n"; pr " fprintf (trace_buffer.fp, \" null\");\n" | StringList n - | DeviceList n -> (* string list *) + | DeviceList n + | FilenameList n -> (* string list *) pr " fputc (' ', trace_buffer.fp);\n"; pr " fputc ('\"', tr...

...SWFDEC_AS_VALUE_SET_STRING (&val, swfdec_as_context_give_string (cx, s)); + } + swfdec_as_context_throw (cx, &val); +} + /*** trace capturing ***/ +static void +swfdec_test_test_trace_stop (SwfdecTestTest *test) +{ + if (test->trace_filename == NULL) + return; + + if (test->trace_buffer && + test->trace_offset != test->trace_buffer->data + test->trace_buffer->length) + test->trace_failed = TRUE; + + if (test->trace_failed) { + /* FIXME: produce a diff here */ + swfdec_test_throw (SWFDEC_AS_OBJECT (test)->context, "invalid trace o...

...- | FileOut n - | GUID n -> + | String ((PlainString|Device|Mountable|Pathname|Filename + |Dev_or_Path|Mountable_or_Path|FileIn|FileOut|GUID), n) -> (* guestfish doesn't support string escaping, so neither do we *) pr " fprintf (trace_buffer.fp, \" \\\"%%s\\\"\", %s);\n" n - | Key n -> + | String (Key, n) -> (* don't print keys *) pr " fprintf (trace_buffer.fp, \" \\\"***\\\"\");\n" | OptString n -> (* string option *) @@ -15...

Hi, I attached the changes I made to a vanilla libguestfs-1.22.6 in order to make it work in mingw/win32. Added is also the patch required to make QEMU compatible (add a command to QMP that lists the supported devices (the regilat way you do it print it to stderr, which is difficult to redirect in win32)). This is done on behalf of Intel Corp. Thanks, Or (oberon in irc)

Very large but mechanical change to the generator. Rich.

Hi, this patch serie adds a new GUID type in the generator, which would do the same as String, but also validating (just in the C output) the passed GUID string. This allows to reject invalid GUIDs before passing them to low-level tools. Pino Toscano (4): utils: add a function to validate a GUID string generator: add a GUID parameter type generator: generate code for parameter validation

...pr " if (optargs->bitmask & GUESTFS_%s_%s_BITMASK) {\n" - (String.uppercase c_name) (String.uppercase n); + (String.uppercase_ascii c_name) (String.uppercase_ascii n); (match argt with | OString n -> pr " fprintf (trace_buffer.fp, \" \\\"%%s:%%s\\\"\", \"%s\", optargs->%s);\n" n n @@ -1614,7 +1616,7 @@ and generate_client_actions actions () = in let trace_return ?(indent = 2) name (ret, _, _) rv = - let indent = spaces indent in + let indent = String.spaces indent in...