search for: tool_path

The bug is: https://bugzilla.redhat.com/show_bug.cgi?id=1161019 This makes a few other minor refactorings to the code. Rich.

...ows guests. * * This only does a "pre-conversion", the steps needed to get the @@ -239,12 +243,15 @@ let convert (g : G.guestfs) inspect source output rcaps = (* Install RHEV-APT only if appropriate for the output hypervisor. *) if output#install_rhev_apt then ( - let tool_path = virt_tools_data_dir () // "rhev-apt.exe" in - if Sys.file_exists tool_path then - configure_rhev_apt tool_path - else - warning (f_"%s is missing, but the output hypervisor is oVirt or RHV. Installing RHEV-APT in the guest would mean the guest is automatica...

...it.exe must be the first firstboot script as it - * suppresses PnP for all following scripts. + (* Run the firstboot script with pnputil.exe before the one with + * pnp_wait.exe as the latter suppresses PnP for all following scripts. *) + configure_pnputil_install (); + let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in if Sys.file_exists tool_path then configure_wait_pnp tool_path @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = strkey name value | None -> sprintf &qu...

...version", the steps needed to get the > > @@ -239,12 +243,15 @@ let convert (g : G.guestfs) inspect source output rcaps = > > > > (* Install RHEV-APT only if appropriate for the output hypervisor. *) > > if output#install_rhev_apt then ( > > - let tool_path = virt_tools_data_dir () // "rhev-apt.exe" in > > - if Sys.file_exists tool_path then > > - configure_rhev_apt tool_path > > - else > > - warning (f_"%s is missing, but the output hypervisor is oVirt or RHV. Installing RHEV-APT in the...

...it.exe must be the first firstboot script as it - * suppresses PnP for all following scripts. + (* Run the firstboot script with pnputil.exe before the one with + * pnp_wait.exe as the latter suppresses PnP for all following scripts. *) + configure_pnputil_install (); + let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in if Sys.file_exists tool_path then configure_wait_pnp tool_path @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = strkey name value | None -> sprintf &qu...

...spect.i_root in @@ -211,20 +218,21 @@ let convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = (* Perform the conversion of the Windows guest. *) let rec configure_firstboot () = - configure_rhev_apt (); + match installer with + | None -> () + | Some (`RhevApt, tool_path) -> configure_rhev_apt tool_path + | Some (`VmdpExe, tool_path) -> configure_vmdp tool_path + | Some (_, installer_path) -> info (f_"No setup function for installer '%s'") installer_path; unconfigure_xenpv (); unconfigure_prltools () - and configure_rhe...

...only does a "pre-conversion", the steps needed to get the > @@ -239,12 +243,15 @@ let convert (g : G.guestfs) inspect source output rcaps = > > (* Install RHEV-APT only if appropriate for the output hypervisor. *) > if output#install_rhev_apt then ( > - let tool_path = virt_tools_data_dir () // "rhev-apt.exe" in > - if Sys.file_exists tool_path then > - configure_rhev_apt tool_path > - else > - warning (f_"%s is missing, but the output hypervisor is oVirt or RHV. Installing RHEV-APT in the guest would mean the...

...script as it > - * suppresses PnP for all following scripts. > + (* Run the firstboot script with pnputil.exe before the one with > + * pnp_wait.exe as the latter suppresses PnP for all following scripts. > *) > + configure_pnputil_install (); > + > let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in > if Sys.file_exists tool_path then > configure_wait_pnp tool_path > @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = > strkey name value >...

...wing scripts. > >> + (* Run the firstboot script with pnputil.exe before the one with > >> + * pnp_wait.exe as the latter suppresses PnP for all following scripts. > >> *) > >> + configure_pnputil_install (); > >> + > >> let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in > >> if Sys.file_exists tool_path then > >> configure_wait_pnp tool_path > >> @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = > >>...

v1 discussion: https://listman.redhat.com/archives/libguestfs/2023-March/031001.html v1 -> v2: * Omit redirecting output to a separate log with "%~dpn0.log". Andrey Drobyshev (1): convert_windows: add firstboot script to install drivers with pnputil convert/convert_windows.ml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- 2.31.1

...* suppresses PnP for all following scripts. >> + (* Run the firstboot script with pnputil.exe before the one with >> + * pnp_wait.exe as the latter suppresses PnP for all following scripts. >> *) >> + configure_pnputil_install (); >> + >> let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in >> if Sys.file_exists tool_path then >> configure_wait_pnp tool_path >> @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = >> strkey name...

I've been experiencing problem with the drivers not always being installed. This patch merely implements the solution offered by Richard in the commit 73e009c04 ("v2v: windows: Document use of pnputil to install drivers."). The solution wasn't implemented back then, but rather added merely as a comment. Thus I wonder is there some issues which it may cause? The most obvious

...>>> + (* Run the firstboot script with pnputil.exe before the one with >>>> + * pnp_wait.exe as the latter suppresses PnP for all following scripts. >>>> *) >>>> + configure_pnputil_install (); >>>> + >>>> let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in >>>> if Sys.file_exists tool_path then >>>> configure_wait_pnp tool_path >>>> @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = >>>>...

...Run the firstboot script with pnputil.exe before the one with >>>>> + * pnp_wait.exe as the latter suppresses PnP for all following scripts. >>>>> *) >>>>> + configure_pnputil_install (); >>>>> + >>>>> let tool_path = virt_tools_data_dir () // "pnp_wait.exe" in >>>>> if Sys.file_exists tool_path then >>>>> configure_wait_pnp tool_path >>>>> @@ -345,6 +347,16 @@ let convert (g : G.guestfs) _ inspect i_firmware block_driver _ static_ips = >&gt...

While messing around this script, I added one more tiny patch making wait-pnp log its output into the common log.txt file, as suggested by Richard here: https://listman.redhat.com/archives/libguestfs/2023-March/031023.html Discussion on v3: https://listman.redhat.com/archives/libguestfs/2023-March/031070.html v3 -> v4: * Remove unneeded line break from the script; * Add another small

Hi there, Here is v3 of the remaining patches. Diff to v2: * Removed the patch related to QXL * Fixed the firstboot script with Roman's comments * Fixed ova with subfolders test * Handle MF-relative path in ova files * Fixed now unneeded match case as per Richard's comment Cédric Bosdonnat (3): customize: fix windows firstboot script v2v: add support for SUSE VMDP drivers v2v:

...8,6 +230,7 @@ let convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = > sprintf "ControlSet%03Ld" value in > > let rec configure_firstboot () = > + wait_pnp (); > (match installer with > | None -> () > | Some (`RhevApt, tool_path) -> configure_rhev_apt tool_path > @@ -226,6 +239,85 @@ let convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = > unconfigure_xenpv (); > unconfigure_prltools () > > + and set_reg_val_dword_1 root key_path name = > + (* set reg value to REG_DWORD...

...8,6 +230,7 @@ let convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = > sprintf "ControlSet%03Ld" value in > > let rec configure_firstboot () = > + wait_pnp (); > (match installer with > | None -> () > | Some (`RhevApt, tool_path) -> configure_rhev_apt tool_path > @@ -226,6 +239,85 @@ let convert ~keep_serial_console (g : G.guestfs) inspect source rcaps = > unconfigure_xenpv (); > unconfigure_prltools () > > + and set_reg_val_dword_1 root key_path name = > + (* set reg value to REG_DWORD...

Hi all, v2 includes all comments from Pino and Richard. I also removed the mkdir /run/lvm in the init since it only failed in one case and couldn't reproduce it anymore. Cédric Bosdonnat (11): v2v: also search for windows virtio drivers in symlinks Update packagelist for SLES and openSUSE customize: fix windows firstboot script customize: change windows firstboot path customize:

Wait for driver installations fired by the PnP manager to complete before running firstboot scripts. The first patch is a minor refactoring to pave the way for the second patch. The latter contains the bulk of the changes as well as the description of the idea. Roman Kagan (2): v2v:windows: factor out getting CurrentControlSet v2v:windows: prevent conflicts with PnP on firstboot --- v1