search for: toker

On 11 December 2013 17:35, Alp Toker <alp at nuanti.com> wrote: > I noticed a few contributors have been landing patches without responding to > my review comments. Oh, that happened to me too, but it turns out you have to press the "clowncopterize" after making comments inlilne, or Phabricator won't publish...

On 10/12/2013 19:47, Jim Grosbach wrote: > > On Dec 10, 2013, at 11:26 AM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com>> wrote: > >> >> On 10/12/2013 18:03, Jim Grosbach wrote: >>>> That causes dissonance between what the compiler sees and what >>>> lit.py sees for no particularly good reason. One of the nice &gt...

On 26/02/2014 09:03, David Chisnall wrote: > On 25 Feb 2014, at 23:13, Alp Toker <alp at nuanti.com> wrote: > >> Now that we've kick-started the LLVM OpenMP runtime discussion, I want to make a concrete proposal to get a test suite up and running for the LLVM OpenMP runtime. I don't think the current setup as an LLVM subproject is sustainable going forwar...

On 11/12/2013 17:48, Renato Golin wrote: > On 11 December 2013 17:35, Alp Toker <alp at nuanti.com> wrote: >> I noticed a few contributors have been landing patches without responding to >> my review comments. > Oh, that happened to me too, but it turns out you have to press the > "clowncopterize" after making comments inlilne, or Phabricator...

On 04/05/2014 02:30, Tom Stellard wrote: > On Sat, May 03, 2014 at 12:32:02AM +0100, Alp Toker wrote: >> On 02/05/2014 20:45, Tuncer Ayaz wrote: >>> Bump. >>> >>> Is it really unsupported to build llvm from scratch with gcc 4.9 and >>> libstdc++ 4.9? Should I file a bugzilla ticket instead? >> Obviously LLVM/clang should compile out of the box...

On 30/01/2014 22:57, Daniel Berlin wrote: > On Thu, Jan 30, 2014 at 2:34 PM, Alp Toker <alp at nuanti.com> wrote: >> On 30/01/2014 22:06, Daniel Berlin wrote: >>> Actually, the policy actually says the right thing, you removed a >>> sentence, which says: >>> "Please contact the oversight group for more details." >> >> To b...

On 11/11/2013 19:08, Chris Lattner wrote: > On Nov 11, 2013, at 9:56 AM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com>> wrote: >> Done :-) >> >> The patchset is 532K so I've put it online: >> >> http://www.nuanti.com/tmp/llvm-api-stability/ >> >> The bulk edits are split out and noted. They were refactored...

...Let's not write off either possibility given that the LLVM value wasn't originally intended for GCC compatibility -- we just spun it that way in the frontend :-) Quentin, thoughts? Alp. > > And thanks for implementing this flag! > > > On Thu, Jun 5, 2014 at 4:00 PM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com>> wrote: > > Hi Kostya, > > Looks like our new clang diagnostic from r210293 has caught a > potential issue in compiler-rt which is now breaking the build due > to -Werror: > > /home/dtoolsbot...

On 25/06/2014 21:18, Eli Bendersky wrote: > > > > On Wed, Jun 25, 2014 at 11:10 AM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com>> wrote: > > > On 25/06/2014 21:03, Eli Bendersky wrote: > > On Wed, Jun 25, 2014 at 10:44 AM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com> <mailto:alp at nuanti.com >...

On 01/07/2014 21:28, Alp Toker wrote: > Specifically the problem I've been seeing is that people using the > website are unable to CC mailing list-based developers. As a result I > don't get copied in on responses to my review comments, and rarely get > any kind of direct mail with threading. You end up ha...

On 25/06/2014 21:03, Eli Bendersky wrote: > On Wed, Jun 25, 2014 at 10:44 AM, Alp Toker <alp at nuanti.com > <mailto:alp at nuanti.com>> wrote: > > For whatever reason, patches posted to the Phabricator website > still aren't being sent to the mailing list, making it difficult > for us to review them. > > I've raised this issue...

> From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Alp Toker > Subject: Re: [LLVMdev] lit: deprecating trailing \ in RUN lines > //\ > int x=0; > int x=0; > $ gcc-4.9 -fsyntax-only f.c Try gcc with -Wall, and you'll see the appropriate warning. Also try the MS compiler after removing the trailing space after the backslash; I don't...

With the recent thread on using C++11 in LLVM/clang, one of the recurring themes was a desire to make the internal headers more consumable. While I don't personally want any kind of stability guarantee for internal headers, I do think we can do more to ensure that any given snapshot of the headers is consumable from different compilers and build configurations. In practice this means

For whatever reason, patches posted to the Phabricator website still aren't being sent to the mailing list, making it difficult for us to review them. I've raised this issue a couple of times in the last few weeks. In practice this has a detrimental effect to the development workflow because it means that code is being seen only by a small group of individuals who have web accounts.

On Mon, May 05, 2014 at 11:42:28PM +0100, Alp Toker wrote: > > On 05/05/2014 20:51, Richard Smith wrote: > > On Mon, May 5, 2014 at 10:47 AM, Chandler Carruth > > <chandlerc at google.com <mailto:chandlerc at google.com>> wrote: > > > > On Mon, May 5, 2014 at 8:11 AM, Alp Toker <alp at nuanti.com &g...

On Mon, May 5, 2014 at 10:47 AM, Chandler Carruth <chandlerc at google.com>wrote: > On Mon, May 5, 2014 at 8:11 AM, Alp Toker <alp at nuanti.com> wrote: > >> I suspect that pulling in clang header fixes r201729, r202911 and r207606 >> to 3.4.1 will resolve libstdc++ / glibc compatibility issues people have >> been having with 3.4: >> >> r201729: Teach Clang to provide ::max_align_t...

On 15/05/2014 22:52, Tom Stellard wrote: > On Thu, May 15, 2014 at 10:41:08PM +0300, Alp Toker wrote: >> On 15/05/2014 22:12, Tom Stellard wrote: >>> On Thu, May 15, 2014 at 01:38:32PM +0200, Tuncer Ayaz wrote: >>>> On Thu, 15 May 2014 02:25:30 +0200, Tom Stellard wrote: >>>> >>>>> On Sat, May 10, 2014 at 11:48:23PM +0200, Tuncer Ayaz wro...

On 11/11/2013 19:16, Alp Toker wrote: > On 11/11/2013 19:08, Chris Lattner wrote: >> On Nov 11, 2013, at 9:56 AM, Alp Toker <alp at nuanti.com >> <mailto:alp at nuanti.com>> wrote: >>> Done :-) >>> >>> The patchset is 532K so I've put it online: >>> >>>...

On 21/11/2013 18:37, Alp Toker wrote: > It's possible a commit I made fixed this (r193685) or if not, a > similar fix might solve the problem. > > I'm in favour of switching the test back on on and collecting data on > what the crash is, or indeed if it's still broken at all. So, I looked into Sema/...

On 11/11/2013 07:37, NAKAMURA Takumi wrote: > 2013/11/10 Alp Toker <alp at nuanti.com>: >> #ifndef NDEBUG >> >> This is the biggest violation. NDEBUG should only ever be used in source >> files. That way if something is crashing we can swap in a debug build >> without rebuilding every single dependent application. Win! > I wi...