Displaying 6 results from an estimated 6 matches for "tmpdisk_can_multi_conn".
2020 Apr 09
0
[PATCH nbdkit v2 3/3] tmpdisk: Implement this plugin using fileops.
...e command instead of mkfs."
-struct handle {
- int fd;
- int64_t size;
- bool can_punch_hole;
-};
-
/* Multi-conn is absolutely unsafe! In this callback it is simply
* returning the default value (no multi-conn), that's to make it
* clear for future authors.
@@ -169,33 +163,6 @@ tmpdisk_can_multi_conn (void *handle)
return 0;
}
-static int
-tmpdisk_can_trim (void *handle)
-{
-#ifdef FALLOC_FL_PUNCH_HOLE
- return 1;
-#else
- return 0;
-#endif
-}
-
-/* Pretend we have native FUA support, but actually because all disks
- * are temporary we will deliberately ignore flush/FUA operations.
- */...
2020 Apr 09
6
[PATCH nbdkit v2 0/3] Implement fileops.
Needs some work still, see in particular the commit message
for patch 3.
Rich.
2020 Mar 16
1
[PATCH nbdkit] New tmpdisk plugin.
Unfinished (needs tests). This is my attempt to make a
"remote tmpfs" plugin as outlined in this prior email:
https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html
Although it would be possible to construct something a bit like this
using existing plugins and filters (perhaps with some new features in
those filters) I think it may be nicer to have a dedicated plugin for
2020 Mar 17
2
[PATCH nbdkit v2] New tmpdisk plugin.
...type.\n" \
+ "command=<COMMAND> Alternate command instead of mkfs."
+
+struct handle {
+ int fd;
+ bool can_punch_hole;
+};
+
+/* Absolutely unsafe! Although this is simply returning the default
+ * value, provide this callback to make it clear.
+ */
+static int
+tmpdisk_can_multi_conn (void *handle)
+{
+ return 0;
+}
+
+static int
+tmpdisk_can_trim (void *handle)
+{
+#ifdef FALLOC_FL_PUNCH_HOLE
+ return 1;
+#else
+ return 0;
+#endif
+}
+
+/* Pretend we have native FUA support, but actually because all disks
+ * are temporary we will deliberately ignore flush/FUA operations.
+...
2020 Mar 17
0
Re: [PATCH nbdkit v2] New tmpdisk plugin.
...s. But you do have a bug: you are using $disk
unquoted, which is okay when TMPDIR is undefined but not always,
because...[1]
> +
> +/* Absolutely unsafe! Although this is simply returning the default
> + * value, provide this callback to make it clear.
> + */
> +static int
> +tmpdisk_can_multi_conn (void *handle)
> +{
> + return 0;
The comment threw me for just a second, until I realized you meant that
'Advertising multi-conn is absolutely unsafe!' and not 'the
implementation of this callback is absolutely unsafe'.
> +}
> +
> +static int
> +tmpdisk_can_t...
2020 Mar 17
2
[PATCH nbdkit v3] New tmpdisk plugin.
v2 was here:
https://www.redhat.com/archives/libguestfs/2020-March/msg00154.html
v3:
- Micro-optimize tmpdir.
- Quote $disk in default command shell fragment.
- Don't redirect mkfs output to /dev/null. Instead use
exec </dev/null >/dev/null before the shell fragment.
We may want to do this in other places where we run
external shell scripts, or more generally for all