search for: tmparchiv

...All the other members are copied from the temporary > archive, so they are not a problem. The file gets corrupted because it is overwriting itself. The strace showed that it opened the same file for reading and writing with 2 file handlers. This isn't what the code is supposed to do. The TmpArchive variable in ArchiveWriter.cpp is supposed to reference a unique file name and it is not. At that point in the ArchiveWriter, it is trying to insert the symbol table. It does that by creating a temporary file and mmaping the original file. The temporary file is written with the symbol table and...

On Nov 22, 2005, at 19:10, Reid Spencer wrote: > 1. What is the path name associated with TmpArchive? If its the same > as the path name associated with archPath then that's a bug, probably > introduced when Path::makeUnique is called from > Path::createTemporaryFileOnDisk which is called from line 377 of > ArchiveWriter.cpp. This does not appear to be the problem. I excluded...

On Nov 22, 2005, at 17:18, Reid Spencer wrote: > Your patch uses an operating system call that is not portable. All > non-portable code needs to be located in the lib/System library. Yep! I know. That is why I posted it for discussion. I'm not sure if this is the "right" way to fix the problem, or if there is a different fix that should be applied (like perhaps copying the

Evan Jones wrote: > On Nov 22, 2005, at 19:10, Reid Spencer wrote: > >> 1. What is the path name associated with TmpArchive? If its the same >> as the path name associated with archPath then that's a bug, probably >> introduced when Path::makeUnique is called from >> Path::createTemporaryFileOnDisk which is called from line 377 of >> ArchiveWriter.cpp. > > > This does not appe...

...utions: > (1) copy the data pointed to by foreignST > (2) build the new file with the symbol table in a 3rd temporary file > which is later renamed as the original (temp.GNU.a in this case). (3) unlink the original file first (basically equivalent to (2)) (4) Write the foreignST into the TmpArchive file. Is there any reason that this isn't possible? Then the final archive would be created in a single pass, and it could just be moved into place. Also, since writeToDisk() invalidates the mapped file that was originally used to create the archive, shouldn't this function also unmap...

On Nov 23, 2005, at 8:16, Evan Jones wrote: > (4) Write the foreignST into the TmpArchive file. Is there any reason > that this isn't possible? Then the final archive would be created in a > single pass, and it could just be moved into place. Ah. I see: It needs to be written in order to compute the offsets. However, it would be possible to use a stringstream for this. I...

Evan Jones wrote: > On Nov 23, 2005, at 8:16, Evan Jones wrote: > >> (4) Write the foreignST into the TmpArchive file. Is there any reason >> that this isn't possible? Then the final archive would be created in a >> single pass, and it could just be moved into place. > > > Ah. I see: It needs to be written in order to compute the offsets. Exactly. > However, it would be pos...