search for: tmp_place

The first patch is just some simple refactoring. See the second patch for a description of the new virt-sparsify --tmp option. I tested this using a loopback device as my temporary block device, and it seems to work fine for me. Federico .. this needs a BZ :-) Rich.

...string; format : string option; ignores : string list; - machine_readable : bool; zeroes : string list; mode : mode_t; } diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 8c8924241..a4bfcaa2a 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -37,7 +37,7 @@ type tmp_place = | Directory of string | Block_device of string | Prebuilt_file of string let run indisk outdisk check_tmpdir compress convert - format ignores machine_readable option tmp_param zeroes = + format ignores option tmp_param zeroes = (* Once we have got past argument parsing and start t...

Store the machine-readable flag globally, just like done for verbose/debug/etc, and enhance create_standard_options to provide --machine-readable automatically. --- common/mlstdutils/std_utils.ml | 4 ++++ common/mlstdutils/std_utils.mli | 7 +++++-- common/mltools/tools_utils.ml | 7 ++++++- common/mltools/tools_utils.mli | 5 ++++- 4 files changed, 19 insertions(+), 4 deletions(-) diff

...amp;& compress then - error (f_"--compress cannot be used for raw output. Remove this option or use --convert qcow2."); + error (f_"--compress cannot be used for raw output. Remove this option or use --convert qcow2"); (* Use TMPDIR or --tmp parameter? *) let tmp_place = diff --git a/src/fuse.c b/src/fuse.c index 08a8784..f7a6e71 100644 --- a/src/fuse.c +++ b/src/fuse.c @@ -1065,7 +1065,7 @@ guestfs__mount_local_run (guestfs_h *g) r = guestfs_exists (g, "/"); guestfs_pop_error_handler (g); if (r == -1) { - error (g, _("you must call ...

...type cmdline = { ignores : string list; zeroes : string list; mode : mode_t; + ks : Tools_utils.key_store; } and mode_t = diff --git a/sparsify/copying.ml b/sparsify/copying.ml index a33b91e69..43fb15e77 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -37,7 +37,7 @@ type tmp_place = | Directory of string | Block_device of string | Prebuilt_file of string let run indisk outdisk check_tmpdir compress convert - format ignores option tmp_param zeroes = + format ignores option tmp_param zeroes ks = (* Once we have got past argument parsing and start to create *...

Hi, the following series adds a --key option in the majority of tools: this makes it possible to pass LUKS credentials programmatically, avoid the need to manually input them, or unsafely pass them via stdin. Thanks, Pino Toscano (2): mltools: create a cmdline_options struct Introduce a --key option in tools that accept keys builder/cmdline.ml | 2 +-

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

...the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + *) + +(** This is the traditional virt-sparsify mode: We copy from a + source disk to a destination disk. *) + +type tmp_place = +| Directory of string | Block_device of string | Prebuilt_file of string + +val run : string -> string -> Cmdline.check_t -> bool -> string option -> string option -> string list -> bool -> string option -> string option -> string list -> unit diff --git a/sparsi...

...ode_in_place in indisk, debug_gc, format, ignores, machine_readable, - quiet, verbose, trace, zeroes, mode + quiet, zeroes, mode diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 9f788b9..9f20fa3 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -39,7 +39,7 @@ type tmp_place = let run indisk outdisk check_tmpdir compress convert format ignores machine_readable option tmp_param - quiet verbose trace zeroes = + quiet zeroes = (* Once we have got past argument parsing and start to create * temporary files (including the potentially massive overlay f...

This works reliably for me ... Rich.

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check