search for: tlsmodel

...me the most general model GeneralDynamicTLSMode. Elf's >> default visibility being called 'default' is already confusing enough >> :-) > > I was thinking that calling it GeneralDynamicTLSMode wouldn't make > sense for non-ELF targets. My thinking was that DefaultTLSModel would > mean "use the default model for the target, which for ELF is general > dynamic, and on Darwin is whatever Darwin does, etc.". This is a good point, but it applies to the other names too, right? For Darwin, all 4 models map to the one that Darwin has. The two closest example...

...model GeneralDynamicTLSMode. Elf's >>> default visibility being called 'default' is already confusing enough >>> :-) >> >> I was thinking that calling it GeneralDynamicTLSMode wouldn't make >> sense for non-ELF targets. My thinking was that DefaultTLSModel would >> mean "use the default model for the target, which for ELF is general >> dynamic, and on Darwin is whatever Darwin does, etc.". > > This is a good point, but it applies to the other names too, right? > For Darwin, all 4 models map to the one that Darwin has. T...

> OK, let's go with GeneralDynamicTLSModel then. OK >> The restrictions should be documented too. > > I'm not sure how much detail we should go into here, because the > restrictions might vary depending on the environment. For example, > with glibc, it will be possible to use initial-exec in a .so that will > be l...

...ed. > *) Please name the most general model GeneralDynamicTLSMode. Elf's > default visibility being called 'default' is already confusing enough > :-) I was thinking that calling it GeneralDynamicTLSMode wouldn't make sense for non-ELF targets. My thinking was that DefaultTLSModel would mean "use the default model for the target, which for ELF is general dynamic, and on Darwin is whatever Darwin does, etc.". > I was not sure how hard the first item would be, so I just gave it a > try. The resulting patch is attached. Your patch preserves the current constru...

> Attaching a new patch that has the behaviour we discussed. > > The "globaldynamic" and default values have been merged, and LLVM will > start off with the user-specified model, but choose a more specific > one if possible. > > Please review. Awesome, thanks! I will try to do a more complete review tonight or tomorrow. For now, just two quick observations *) This