search for: tgsi_resource_priv

...; unsigned Padding : 22; > }; > > -/* > - * Special resources that don't need to be declared. They map to the > - * GLOBAL/LOCAL/PRIVATE/INPUT compute memory spaces. > - */ > -#define TGSI_RESOURCE_GLOBAL 0x7fff > -#define TGSI_RESOURCE_LOCAL 0x7ffe > -#define TGSI_RESOURCE_PRIVATE 0x7ffd > -#define TGSI_RESOURCE_INPUT 0x7ffc > - This should be in a separate patch with "gallium:" as prefix even if nouveau is the only driver which somehow uses these constants. Other than that, the patch looks fine. And thanks to not remove this resource thing because this...

...7,15 +237,6 @@ struct tgsi_declaration_array { unsigned Padding : 22; }; -/* - * Special resources that don't need to be declared. They map to the - * GLOBAL/LOCAL/PRIVATE/INPUT compute memory spaces. - */ -#define TGSI_RESOURCE_GLOBAL 0x7fff -#define TGSI_RESOURCE_LOCAL 0x7ffe -#define TGSI_RESOURCE_PRIVATE 0x7ffd -#define TGSI_RESOURCE_INPUT 0x7ffc - #define TGSI_IMM_FLOAT32 0 #define TGSI_IMM_UINT32 1 #define TGSI_IMM_INT32 2 -- 2.7.2

Commit c3083c7082 ("nv50/ir: add support for BUFFER accesses") disabled / commented out some of the old resource handling code, but not all of it. Effectively all of it is dead already, if we ever enter the old code paths in handeLOAD / handleSTORE / handleATOM we will get an exception due to trying to access the now always zero-sized resources vector. Disable all the dead code.

...7,15 +237,6 @@ struct tgsi_declaration_array { unsigned Padding : 22; }; -/* - * Special resources that don't need to be declared. They map to the - * GLOBAL/LOCAL/PRIVATE/INPUT compute memory spaces. - */ -#define TGSI_RESOURCE_GLOBAL 0x7fff -#define TGSI_RESOURCE_LOCAL 0x7ffe -#define TGSI_RESOURCE_PRIVATE 0x7ffd -#define TGSI_RESOURCE_INPUT 0x7ffc - #define TGSI_IMM_FLOAT32 0 #define TGSI_IMM_UINT32 1 #define TGSI_IMM_INT32 2 -- 2.7.2

...; >> >> -/* >> - * Special resources that don't need to be declared. They map to the >> - * GLOBAL/LOCAL/PRIVATE/INPUT compute memory spaces. >> - */ >> -#define TGSI_RESOURCE_GLOBAL 0x7fff >> -#define TGSI_RESOURCE_LOCAL 0x7ffe >> -#define TGSI_RESOURCE_PRIVATE 0x7ffd >> -#define TGSI_RESOURCE_INPUT 0x7ffc >> - > > This should be in a separate patch with "gallium:" as prefix even if nouveau is the only driver which somehow uses these constants. Ok, will do. > Other than that, the patch looks fine. > And thanks...

tgsi_default_instruction_memory / tgsi_build_instruction_memory were returning uninitialized memory for tgsi_instruction_memory.Texture and tgsi_instruction_memory.Format. Note 0 means not set, and thus is a correct default initializer for these. Fixes: 3243b6fc97 ("tgsi: add Texture and Format to tgsi_instruction_memory") Cc: Nicolai Hähnle <nicolai.haehnle at amd.com>