Displaying 20 results from an estimated 44 matches for "tgsi_file_memory".
2016 Mar 10
8
[PATCH mesa 0/3] tgsi and nouveau global / local / opencl-input mem support
Hi,
Here are patches which implement the support for OpenCL kernel input
parameters we discussed. They also add the tgsi parsing bits for
adding support for global / local mem, but no implementation yet.
Regards,
Hans
2016 Mar 16
5
[PATCH mesa v2 1/3] tgsi: Fix decl.Atomic and .Shared not propagating when parsing tgsi text
When support for decl.Atomic and .Shared was added, tgsi_build_declaration
was not updated to propagate these properly.
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
Changes in v2:
-Add Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
src/gallium/auxiliary/tgsi/tgsi_build.c | 6 ++++++
1 file changed, 6
2016 Mar 14
2
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...nCL global memory buffers with
nouveau, but clearly the #if 0 is not a solution as it breaks buffers
with GLSL.
The reason I'm posting this as an RFC patch is to discuss how to solve
this properly, 2 solutions come to mind:
1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at translateFile()
we currently have:
case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_GLOBAL;
case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
So doing a s/nv50_ir::FILE_MEMORY_GLOBAL/nv50_ir::FILE_MEMORY_BUFFER/...
2016 Mar 10
1
[Mesa-dev] [PATCH mesa 2/3] tgsi: Add support for global / local / input MEMORY
...tgsi/tgsi_dump.c
> b/src/gallium/auxiliary/tgsi/tgsi_dump.c
> index f232f38..273f0ae 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
> @@ -365,8 +365,13 @@ iter_declaration(
> }
>
> if (decl->Declaration.File == TGSI_FILE_MEMORY) {
> - if (decl->Declaration.Shared)
> - TXT(", SHARED");
> + switch (decl->Declaration.MemType) {
> + /* Note: ,GLOBAL is optional / the default */
> + case TGSI_MEMORY_TYPE_GLOBAL: TXT(", GLOBAL"); break;
> + case TGSI_M...
2016 Mar 16
2
[PATCH mesa 6/6] nouveau: codegen: Disable more old resource handling code
...of the texture read mask on OP_SULDP is not allowed.
> @@ -2274,8 +2278,9 @@ Converter::handleLOAD(Value *dst0[4])
> int c;
> std::vector<Value *> off, src, ldv, def;
>
> - if (tgsi.getSrc(0).getFile() == TGSI_FILE_BUFFER ||
> - tgsi.getSrc(0).getFile() == TGSI_FILE_MEMORY) {
> + switch (tgsi.getSrc(0).getFile()) {
> + case TGSI_FILE_BUFFER:
> + case TGSI_FILE_MEMORY:
> for (c = 0; c < 4; ++c) {
> if (!dst0[c])
> continue;
> @@ -2295,9 +2300,12 @@ Converter::handleLOAD(Value *dst0[4])
> if (...
2016 Mar 14
2
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...is not a solution as it breaks buffers
>> with GLSL.
>>
>> The reason I'm posting this as an RFC patch is to discuss how to solve
>> this properly, 2 solutions come to mind:
>>
>> 1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
>> TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at
>> translateFile()
>> we currently have:
>>
>> case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_GLOBAL;
>> case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
>>
>> So doing...
2016 Mar 10
0
[PATCH mesa 2/3] tgsi: Add support for global / local / input MEMORY
...e)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c
index f232f38..273f0ae 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
@@ -365,8 +365,13 @@ iter_declaration(
}
if (decl->Declaration.File == TGSI_FILE_MEMORY) {
- if (decl->Declaration.Shared)
- TXT(", SHARED");
+ switch (decl->Declaration.MemType) {
+ /* Note: ,GLOBAL is optional / the default */
+ case TGSI_MEMORY_TYPE_GLOBAL: TXT(", GLOBAL"); break;
+ case TGSI_MEMORY_TYPE_LOCAL: TXT(",...
2016 Mar 16
0
[PATCH mesa v2 2/3] tgsi: Add support for global / private / input MEMORY
...e)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c
index c8b91bb..6d39ef2 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
@@ -365,8 +365,13 @@ iter_declaration(
}
if (decl->Declaration.File == TGSI_FILE_MEMORY) {
- if (decl->Declaration.Shared)
- TXT(", SHARED");
+ switch (decl->Declaration.MemType) {
+ /* Note: ,GLOBAL is optional / the default */
+ case TGSI_MEMORY_TYPE_GLOBAL: TXT(", GLOBAL"); break;
+ case TGSI_MEMORY_TYPE_SHARED: TXT(&quo...
2016 Mar 10
0
[Mesa-dev] [PATCH mesa 2/3] tgsi: Add support for global / local / input MEMORY
...llium/auxiliary/tgsi/tgsi_dump.c
>> index f232f38..273f0ae 100644
>> --- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
>> +++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
>> @@ -365,8 +365,13 @@ iter_declaration(
>> }
>>
>> if (decl->Declaration.File == TGSI_FILE_MEMORY) {
>> - if (decl->Declaration.Shared)
>> - TXT(", SHARED");
>> + switch (decl->Declaration.MemType) {
>> + /* Note: ,GLOBAL is optional / the default */
>> + case TGSI_MEMORY_TYPE_GLOBAL: TXT(", GLOBAL"); break;
>...
2016 Mar 14
2
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...with GLSL.
>>>>
>>>> The reason I'm posting this as an RFC patch is to discuss how to solve
>>>> this properly, 2 solutions come to mind:
>>>>
>>>> 1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
>>>> TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at
>>>> translateFile()
>>>> we currently have:
>>>>
>>>> case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_GLOBAL;
>>>> case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMOR...
2016 Mar 10
3
[PATCH mesa 3/3] nouveau: Add support for clover / OpenCL kernel input parameters
...rivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> @@ -1523,9 +1523,21 @@ Converter::makeSym(uint tgsiFile, int fileIdx, int idx, int c, uint32_t address)
>
> sym->reg.fileIndex = fileIdx;
>
> - if (tgsiFile == TGSI_FILE_MEMORY &&
> - code->memoryFiles[fileIdx].mem_type == TGSI_MEMORY_TYPE_SHARED)
> - sym->setFile(FILE_MEMORY_SHARED);
> + if (tgsiFile == TGSI_FILE_MEMORY) {
> + switch (code->memoryFiles[fileIdx].mem_type) {
> + case TGSI_MEMORY_TYPE_SHARED:
> +...
2016 Mar 16
0
[PATCH mesa 6/6] nouveau: codegen: Disable more old resource handling code
...anularity is 4 byte.
// Usage of the texture read mask on OP_SULDP is not allowed.
@@ -2274,8 +2278,9 @@ Converter::handleLOAD(Value *dst0[4])
int c;
std::vector<Value *> off, src, ldv, def;
- if (tgsi.getSrc(0).getFile() == TGSI_FILE_BUFFER ||
- tgsi.getSrc(0).getFile() == TGSI_FILE_MEMORY) {
+ switch (tgsi.getSrc(0).getFile()) {
+ case TGSI_FILE_BUFFER:
+ case TGSI_FILE_MEMORY:
for (c = 0; c < 4; ++c) {
if (!dst0[c])
continue;
@@ -2295,9 +2300,12 @@ Converter::handleLOAD(Value *dst0[4])
if (tgsi.getSrc(0).isIndirect(0))
l...
2016 Mar 10
3
[PATCH mesa 3/3] nouveau: Add support for clover / OpenCL kernel input parameters
...b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
>>> @@ -1523,9 +1523,21 @@ Converter::makeSym(uint tgsiFile, int fileIdx, int
>>> idx, int c, uint32_t address)
>>>
>>> sym->reg.fileIndex = fileIdx;
>>>
>>> - if (tgsiFile == TGSI_FILE_MEMORY &&
>>> - code->memoryFiles[fileIdx].mem_type == TGSI_MEMORY_TYPE_SHARED)
>>> - sym->setFile(FILE_MEMORY_SHARED);
>>> + if (tgsiFile == TGSI_FILE_MEMORY) {
>>> + switch (code->memoryFiles[fileIdx].mem_type) {
>>> +...
2016 Mar 14
0
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...uveau, but clearly the #if 0 is not a solution as it breaks buffers
> with GLSL.
>
> The reason I'm posting this as an RFC patch is to discuss how to solve
> this properly, 2 solutions come to mind:
>
> 1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
> TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at
> translateFile()
> we currently have:
>
> case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_GLOBAL;
> case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
>
> So doing a s/nv50_ir::FILE_MEMORY_GLOBAL...
2016 Mar 16
0
[PATCH mesa 6/6] nouveau: codegen: Disable more old resource handling code
...k on OP_SULDP is not allowed.
>> @@ -2274,8 +2278,9 @@ Converter::handleLOAD(Value *dst0[4])
>> int c;
>> std::vector<Value *> off, src, ldv, def;
>>
>> - if (tgsi.getSrc(0).getFile() == TGSI_FILE_BUFFER ||
>> - tgsi.getSrc(0).getFile() == TGSI_FILE_MEMORY) {
>> + switch (tgsi.getSrc(0).getFile()) {
>> + case TGSI_FILE_BUFFER:
>> + case TGSI_FILE_MEMORY:
>> for (c = 0; c < 4; ++c) {
>> if (!dst0[c])
>> continue;
>> @@ -2295,9 +2300,12 @@ Converter::handleLOAD(Value *d...
2016 Mar 14
0
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...ks buffers
>>> with GLSL.
>>>
>>> The reason I'm posting this as an RFC patch is to discuss how to solve
>>> this properly, 2 solutions come to mind:
>>>
>>> 1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
>>> TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at
>>> translateFile()
>>> we currently have:
>>>
>>> case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_GLOBAL;
>>> case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
>>&g...
2016 Mar 14
0
[RFC mesa] nouveau: Add support for OpenCL global memory buffers
...gt;>
>>>>> The reason I'm posting this as an RFC patch is to discuss how to solve
>>>>> this properly, 2 solutions come to mind:
>>>>>
>>>>> 1) Use separate nv50_ir::FILE_MEMORY_xxx values for buffers versus
>>>>> TGSI_FILE_MEMORY with TGSI_MEMORY_TYPE_GLOBAL, looking at
>>>>> translateFile()
>>>>> we currently have:
>>>>>
>>>>> case TGSI_FILE_BUFFER: return
>>>>> nv50_ir::FILE_MEMORY_GLOBAL;
>>>>> case TGSI_FILE_ME...
2016 Mar 16
2
[PATCH mesa 5/6] nouveau: codegen: Add support for OpenCL global memory buffers
...4,7 @@ static nv50_ir::DataFile translateFile(uint file)
> case TGSI_FILE_IMMEDIATE: return nv50_ir::FILE_IMMEDIATE;
> case TGSI_FILE_SYSTEM_VALUE: return nv50_ir::FILE_SYSTEM_VALUE;
> case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_BUFFER;
> - case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_BUFFER;
> + case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
> case TGSI_FILE_SAMPLER:
> case TGSI_FILE_NULL:
> default:
> @@ -1284,7 +1284,9 @@ bool Source::scanInstruction(const struct tgsi_full_instruction *...
2016 Mar 17
4
[PATCH mesa v2 1/3] nouveau: codegen: Disable more old resource handling code
Commit c3083c7082 ("nv50/ir: add support for BUFFER accesses") disabled /
commented out some of the old resource handling code, but not all of it.
Effectively all of it is dead already, if we ever enter the old code
paths in handeLOAD / handleSTORE / handleATOM we will get an exception
due to trying to access the now always zero-sized resources vector.
Disable all the dead code.
2016 Mar 16
0
[PATCH mesa 5/6] nouveau: codegen: Add support for OpenCL global memory buffers
..._tgsi.cpp
@@ -374,7 +374,7 @@ static nv50_ir::DataFile translateFile(uint file)
case TGSI_FILE_IMMEDIATE: return nv50_ir::FILE_IMMEDIATE;
case TGSI_FILE_SYSTEM_VALUE: return nv50_ir::FILE_SYSTEM_VALUE;
case TGSI_FILE_BUFFER: return nv50_ir::FILE_MEMORY_BUFFER;
- case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_BUFFER;
+ case TGSI_FILE_MEMORY: return nv50_ir::FILE_MEMORY_GLOBAL;
case TGSI_FILE_SAMPLER:
case TGSI_FILE_NULL:
default:
@@ -1284,7 +1284,9 @@ bool Source::scanInstruction(const struct tgsi_full_instruction *inst)
if (dst.isIn...