search for: tgraf

...need to support modify multicast database too (RTM_{ADD,DEL}MDB). (Thanks to Thomas for patient reviews) Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <shemminger at vyatta.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: Thomas Graf <tgraf at suug.ch> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Cong Wang <amwang at redhat.com> --- include/uapi/linux/if_bridge.h | 55 ++++++++++++++ include/uapi/linux/rtnetlink.h | 3 + net/bridge/Makefile | 2 +- net/bridge/br_mdb.c...

I''m trying to configure dsmark qdisc on 2.6.11.4 user mode linux and tc from iproute2-2.6.11-050314. I think I have some mismatch in my setup since adding dsmark qdisc fails *unless* I specify "set_tc_index" argument which I believe should be optional: # tc qdisc add dev eth1 handle 1:0 root dsmark indices 8 RTNETLINK answers: Invalid argument Mar 20 13:00:50 user user.debug

On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf <tgraf at suug.ch> wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio console violated this > > > rule by adding inbufs, whi...

On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf <tgraf at suug.ch> wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio console violated this > > > rule by adding inbufs, whi...

...is dynamically added after >> the probe function is done. >> >> Let's move virtio_device_ready() to the probe function just before >> trying to use the virtqueues instead. This is fine as nothing can >> fail inbetween. >> >> Reported-by: Thomas Graf <tgraf at suug.ch> >> Reviewed-by: Michael S. Tsirkin <mst at redhat.com> >> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Thanks! > > Acked-by: Michael S. Tsirkin <mst at redhat.com> > Tested-by: Michael S. Tsirkin <mst at redhat.com>...

...is dynamically added after >> the probe function is done. >> >> Let's move virtio_device_ready() to the probe function just before >> trying to use the virtqueues instead. This is fine as nothing can >> fail inbetween. >> >> Reported-by: Thomas Graf <tgraf at suug.ch> >> Reviewed-by: Michael S. Tsirkin <mst at redhat.com> >> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Thanks! > > Acked-by: Michael S. Tsirkin <mst at redhat.com> > Tested-by: Michael S. Tsirkin <mst at redhat.com>...

...r, means that we try to set DRIVER_OK again when when a port is dynamically added after the probe function is done. Let's move virtio_device_ready() to the probe function just before trying to use the virtqueues instead. This is fine as nothing can fail inbetween. Reported-by: Thomas Graf <tgraf at suug.ch> Reviewed-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/char/virtio_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_co...

...r, means that we try to set DRIVER_OK again when when a port is dynamically added after the probe function is done. Let's move virtio_device_ready() to the probe function just before trying to use the virtqueues instead. This is fine as nothing can fail inbetween. Reported-by: Thomas Graf <tgraf at suug.ch> Reviewed-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/char/virtio_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_co...

Based on net-next. This patch exports port->port_no port->port_id in the end of IFA_INFO_DATA. Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <shemminger at vyatta.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: Thomas Graf <tgraf at suug.ch> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Cong Wang <amwang at redhat.com> --- include/uapi/linux/if_link.h | 2 ++ net/bridge/br_netlink.c | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/include/uapi/linux/...

After an: # ip ru flush I loose all my ip rules but the priority 0 one. root@sarasvati:~# ip ru 0: from all lookup 255 root@sarasvati:~# Ok with that, but now i''m not able to insert any new rule. This leads to a total loose of conectivity. root@sarasvati:~# ip ru add from all table default RTNETLINK answers: Numerical result out of range root@sarasvati:~# ip ru add from all

Changing the subject line for good ... On Thu, Apr 7, 2011 at 8:58 AM, Lamar Owen <lowen at pari.edu> wrote: > On Thursday, April 07, 2011 11:23:51 AM Brunner, Brian T. wrote: >> AIUI: In previous releases, RH distributed source + patches. ?Starting >> 6.0 RH releases patched source. ?This makes backing out a patch, or >> backporting patches from future development in

On Mon, 20 Oct 2014 13:07:50 +0100 Thomas Graf <tgraf at suug.ch> wrote: > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > This is set automatically after probe returns, virtio console violated this > > rule by adding inbufs, which causes the VQ to be us...

...OK again when when a port is dynamically added after > the probe function is done. > > Let's move virtio_device_ready() to the probe function just before > trying to use the virtqueues instead. This is fine as nothing can > fail inbetween. > > Reported-by: Thomas Graf <tgraf at suug.ch> > Reviewed-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Thanks! Acked-by: Michael S. Tsirkin <mst at redhat.com> Tested-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/char/...

On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio_device_ready before using VQs. > > Signed-off-by: Michael S. Tsirkin

On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio_device_ready before using VQs. > > Signed-off-by: Michael S. Tsirkin

On Mon, Oct 20, 2014 at 04:35:55PM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > > On Mon, 20 Oct 2014 13:07:50 +0100 > > Thomas Graf <tgraf at suug.ch> wrote: > > > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > > This is set automatically after probe returns, virtio console violated this > > > > r...

...b, but currently bridge-specific. We may need to support modify multicast database too (RTM_{ADD,DEL}MDB). Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <shemminger at vyatta.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: Thomas Graf <tgraf at suug.ch> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Cong Wang <amwang at redhat.com> --- include/uapi/linux/if_bridge.h | 55 ++++++++++++++ include/uapi/linux/rtnetlink.h | 3 + net/bridge/Makefile | 2 +- net/bridge/br_mdb.c...

Yes, last night it was 4Mbps the rate of incoming mails. I was wondering if I apply HTB to the following scheme: router -> gw-iface -> MX-server If HTB (new verb) the interface that communicates with MX, say, 2mbit, what will occur to the Input queue of gw-router-iface? Will I still get the link full for 4mbit or will it get lower to 2mbit too, as the inner interface? Appreciate

I am wondering whether the commands ''tc filter change'' and ''tc filter replace'' are working. Googling around revealed a few emails on the LARTC stating that unfoirtunately they do not work. A quick check showed that they are still not implemented (properly). Some propose a solution to build a second tree of filters and apply the 2nd one when a need for it

...r0 bridge br0 port eth1 group 224.8.8.9 bridge br0 port eth0 group 224.8.8.8 router ports on br0: eth0 Cc: Herbert Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <shemminger at vyatta.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: Thomas Graf <tgraf at suug.ch> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Signed-off-by: Cong Wang <amwang at redhat.com> --- bridge/Makefile | 2 +- bridge/br_common.h | 3 +- bridge/bridge.c | 1 + bridge/mdb.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++...