search for: tgolembi

ping +Gil, +Amnon... could you maybe aid in reviewing the patch, please? Tomas On Sun, 22 Oct 2017 20:05:57 +0200 Tom?? Golembiovsk? <tgolembi at redhat.com> wrote: > On Thu, 19 Oct 2017 16:12:20 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Sep 21, 2017 at 02:55:41PM +0200, Tom?? Golembiovsk? wrote: > > > Add a new fields, VIRTIO_BALLOON_S_BUFFERS and VIRTIO_BALLOON_S...

ping +Gil, +Amnon... could you maybe aid in reviewing the patch, please? Tomas On Sun, 22 Oct 2017 20:05:57 +0200 Tom?? Golembiovsk? <tgolembi at redhat.com> wrote: > On Thu, 19 Oct 2017 16:12:20 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Sep 21, 2017 at 02:55:41PM +0200, Tom?? Golembiovsk? wrote: > > > Add a new fields, VIRTIO_BALLOON_S_BUFFERS and VIRTIO_BALLOON_S...

From: Tomáš Golembiovský <tgolembi@redhat.com> Do not print warning for 'sr' devices when converting fstab. Not all systems create the /dev/cdrom symlink for SCSI CD-ROM devices. Moreover, on systems with multiple CD-ROMs, having entries for /dev/sr* devices may be inevitable. RWMJ: Use String.is_prefix instead of Strin...

Linux driver part v2: - fixed typos Tom?? Golembiovsk? (1): virtio_balloon: include buffers and cached memory statistics drivers/virtio/virtio_balloon.c | 11 +++++++++++ include/uapi/linux/virtio_balloon.h | 4 +++- mm/swap_state.c | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) -- 2.14.1

Linux driver part v2: - fixed typos Tom?? Golembiovsk? (1): virtio_balloon: include buffers and cached memory statistics drivers/virtio/virtio_balloon.c | 11 +++++++++++ include/uapi/linux/virtio_balloon.h | 4 +++- mm/swap_state.c | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) -- 2.14.1

Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory statistics protocol. The value represents all disk/file caches. In this case it corresponds to the sum of values Buffers+Cached+SwapCached from /proc/meminfo. Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> --- drivers/virtio/virtio_balloon.c | 4 ++++ include/uapi/linux/virtio_balloon.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f0b3a0b9d42f..d2bd13bbaf9f 100644 --- a/drivers/vir...

Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory statistics protocol. The value represents all disk/file caches. In this case it corresponds to the sum of values Buffers+Cached+SwapCached from /proc/meminfo. Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> --- drivers/virtio/virtio_balloon.c | 4 ++++ include/uapi/linux/virtio_balloon.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f0b3a0b9d42f..d2bd13bbaf9f 100644 --- a/drivers/vir...

...emory statistics protocol. The values correspond to > 'Buffers' and 'Cached' in /proc/meminfo. > > To be able to compute the value of 'Cached' memory it is necessary to > export total_swapcache_pages() to modules. > > Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> Does 'Buffers' actually make sense? It's a temporary storage - wouldn't it be significantly out of date by the time host receives it? > --- > drivers/virtio/virtio_balloon.c | 11 +++++++++++ > include/uapi/linux/virtio_balloon.h | 4 +++- > mm/...

...emory statistics protocol. The values correspond to > 'Buffers' and 'Cached' in /proc/meminfo. > > To be able to compute the value of 'Cached' memory it is necessary to > export total_swapcache_pages() to modules. > > Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> Does 'Buffers' actually make sense? It's a temporary storage - wouldn't it be significantly out of date by the time host receives it? > --- > drivers/virtio/virtio_balloon.c | 11 +++++++++++ > include/uapi/linux/virtio_balloon.h | 4 +++- > mm/...

Building virt-v2v out-of-tree does not work and requires several small fixes here and there. Tomáš Golembiovský (3): build: perform gnulib check from source directory build: run ocaml-link.sh from build directory docs: don't perform lookup on absolute paths cfg.mk | 1 + podwrapper.pl.in | 2 ++ v2v/Makefile.am | 16 ++++++++-------- 3 files changed, 11 insertions(+), 8

...are not stored in the returned > list. The default is to keep the empty elements > > * count: specifies how many splits to perform; negative count > (the default) means do as many splits as possible > > Added tests for nsplit. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > mllib/common_utils.ml | 12 +++++++++--- > mllib/common_utils.mli | 12 ++++++++++-- > mllib/common_utils_tests.ml | 26 ++++++++++++++++++++++++++ > 3 files changed, 45 insertions(+), 5 deletions(-) > > diff --git a/mllib/common_utils.ml b/m...

On Debian family of OSes Grub2 tools are prefixed with 'grub-', not with 'grub2-'. We have to detect the correct name of the tool to use it. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/convert_linux.ml | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index 103728b..1f5f12c 100644 --- a/v2v/convert_linux.ml +++ b/v2v/convert_linux.ml @@ -109,6 +109,23 @@ let rec convert ~k...

...ty: if set to false empty elements are not stored in the returned > list. The default is to keep the empty elements > > * count: specifies how many splits to perform; negative count > (the default) means do as many splits as possible > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- LGTM -- while you are here, what about adding tests for it in mllib/common_utils_tests.ml? Thanks, -- Pino Toscano

..._S_CACHED, to virtio_balloon memory statistics protocol. The values correspond to 'Buffers' and 'Cached' in /proc/meminfo. To be able to compute the value of 'Cached' memory it is necessary to export total_swapcache_pages() to modules. Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> --- drivers/virtio/virtio_balloon.c | 11 +++++++++++ include/uapi/linux/virtio_balloon.h | 4 +++- mm/swap_state.c | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c in...

..._S_CACHED, to virtio_balloon memory statistics protocol. The values correspond to 'Buffers' and 'Cached' in /proc/meminfo. To be able to compute the value of 'Cached' memory it is necessary to export total_swapcache_pages() to modules. Signed-off-by: Tom?? Golembiovsk? <tgolembi at redhat.com> --- drivers/virtio/virtio_balloon.c | 11 +++++++++++ include/uapi/linux/virtio_balloon.h | 4 +++- mm/swap_state.c | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c in...

On Tue, Oct 31, 2017 at 01:20:19PM +0100, Tom?? Golembiovsk? wrote: > ping > > +Gil, +Amnon... could you maybe aid in reviewing the patch, please? > > > Tomas > > On Sun, 22 Oct 2017 20:05:57 +0200 > Tom?? Golembiovsk? <tgolembi at redhat.com> wrote: > > > On Thu, 19 Oct 2017 16:12:20 +0300 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > On Thu, Sep 21, 2017 at 02:55:41PM +0200, Tom?? Golembiovsk? wrote: > > > > Add a new fields, VIRTIO_BALLOON_...

On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > podwrapper.pl.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/podwrapper.pl.in b/podwrapper.pl.in > index f12a173f..1e4aa149 100755 > --- a/podwrapper.pl.in > +++ b/podwrapper.pl.in > @@ -689,6 +689,8 @@ sub find_file > my $u...

This affects -o rhv and -o vdsm. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/create_ovf.ml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml index cfca63452..03df7f934 100644 --- a/v2v/create_ovf.ml +++ b/v2v/create_ovf.ml @@ -390,6 +390,29 @@ let rec create_ovf source targets guestcaps...

The Invalid_argument exception is there to catch unexpected situation when rpm returns no output. Such situation should be reported rather then hidden. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/linux.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2v/linux.ml b/v2v/linux.ml index e57dad6..46cb3ba 100644 --- a/v2v/linux.ml +++ b/v2v/linux.ml @@ -109,8 +109,8 @@ let rec file_owner (g : G.guestfs) inspect path = raise Not_found...

...3 (0) 662 784 971 <+33662784971> > > <http://redhat.com> *TRIED. TESTED. TRUSTED.* > > Twitter: @redhatway <https://twitter.com/redhatway> | Instagram: @redhatinc > <https://www.instagram.com/redhatinc/> | Snapchat: @redhatsnaps -- Tomáš Golembiovský <tgolembi@redhat.com>