search for: tests_helper

I was going to post this as a patch, but I realize the patch is just working around an actual bug in the libvirt backend [not in libvirt]. Anyway, posting it here so we don't forget about it. Rich.

...h.py | 1 - python/t/test410CloseEvent.py | 1 - python/t/test420LogMessages.py | 1 - python/t/test430ProgressMessages.py | 3 ++- python/t/test800ExplicitClose.py | 1 - python/t/test820RHBZ912499.py | 3 +-- python/t/test910Libvirt.py | 1 - python/t/tests_helper.py.in | 2 +- python/test-pycodestyle.sh | 30 +++++++++++++++++++++++++++++ 21 files changed, 61 insertions(+), 23 deletions(-) create mode 100755 python/test-pycodestyle.sh -- 2.24.1

...h.py | 1 - python/t/test410CloseEvent.py | 1 - python/t/test420LogMessages.py | 1 - python/t/test430ProgressMessages.py | 3 ++- python/t/test800ExplicitClose.py | 1 - python/t/test820RHBZ912499.py | 3 +-- python/t/test910Libvirt.py | 1 - python/t/tests_helper.py.in | 2 +- python/test-pycodestyle.sh | 28 ++++++++++++++++++++++++++++ 22 files changed, 60 insertions(+), 24 deletions(-) create mode 100755 python/test-pycodestyle.sh -- 2.24.1

...thon/t/test410CloseEvent.py | 18 ++--- python/t/test420LogMessages.py | 30 ++++---- python/t/test800ExplicitClose.py | 30 ++++---- python/t/test810RHBZ811650.py | 17 ++--- python/t/test820RHBZ912499.py | 58 ++++++++-------- python/t/test910Libvirt.py | 17 ++--- python/t/tests_helper.py | 30 ++++---- tests/http/test-http.py | 143 +++++++++++++++++++------------------- 19 files changed, 473 insertions(+), 403 deletions(-) -- 2.5.5

...+++++ python/t/test420LogMessages.py | 54 +++++++++++++++ python/t/test800ExplicitClose.py | 54 +++++++++++++++ python/t/test810RHBZ811650.py | 37 +++++++++++ python/t/test820RHBZ912499.py | 94 ++++++++++++++++++++++++++ python/t/test910Libvirt.py | 42 ++++++++++++ python/t/tests_helper.py | 63 ++++++++++++++++++ 26 files changed, 653 insertions(+), 670 deletions(-) delete mode 100644 python/t/010-load.py delete mode 100644 python/t/070-optargs.py delete mode 100644 python/t/080-version.py delete mode 100644 python/t/090-retvalues.py delete mode 100644 python/t/100-...

...Values.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/t/test090RetValues.py b/python/t/test090RetValues.py index 7ff51f0..24d97b4 100644 --- a/python/t/test090RetValues.py +++ b/python/t/test090RetValues.py @@ -19,6 +19,7 @@ import unittest import guestfs +from .tests_helper import * class Test090PythonRetValues (unittest.TestCase): @@ -33,7 +34,7 @@ class Test090PythonRetValues (unittest.TestCase): def test_rint64 (self): g = guestfs.GuestFS () - self.assertAlmostEqual (g.internal_test_rint64 ("10"), 10L, places=1) + self.a...

.../python/guestfs.pyo -/python/guestfs-internal-all.h -/python/guestfs-utils.h -/python/ignore-value.h +/python/guestfs-stringlists-utils.h /python/MANIFEST /python/module.c +/python/stringlists-utils.c /python/structs.c /python/__pycache__ /python/setup.py /python/stamp-extra-files /python/t/tests_helper.py -/python/utils.c /rescue/stamp-virt-rescue.pod /rescue/virt-rescue /rescue/virt-rescue.1 diff --git a/generator/python.ml b/generator/python.ml index e436f4bda..821c66755 100644 --- a/generator/python.ml +++ b/generator/python.ml @@ -42,7 +42,7 @@ let rec generate_python_actions_h () = #defi...

On Thu, Dec 12, 2019 at 11:01:02AM +0100, Vincent Danjean wrote: > [resend to the good (cloned) bug, sorry for the message in the original bug, > it was a mistake] > > Hi, > > On Thu, 5 Dec 2019 11:12:56 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > > I believe this is a new bug and nothing much to do with: > >

Verify the returned values of Python Object constructor functions are not NULL before adding them to a collection. This is particularly relevant when constructing Unicode strings in Python 3 as they will return NULL if non UTF-8 characters are present. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- generator/python.ml | 102 ++++++++++++++++++++++++++---------------

Make sure they can build also in no as-neede setups. Pino Toscano (1): utils: split string list functions in own file build: use split stringlist functions from common/utils utils/Makefile.am | 2 + utils/guestfs-stringlists-utils.h | 30 +++++ utils/guestfs-utils.h | 7 +- utils/stringlists-utils.c | 197 ++++++++++++++++++++++++++++++ utils/utils.c

...gitignore +++ b/.gitignore @@ -500,7 +500,6 @@ Makefile.in /python/guestfs.pyc /python/guestfs.pyo /python/guestfs-internal-all.h -/python/guestfs-internal-frontend.h /python/ignore-value.h /python/MANIFEST /python/module.c @@ -511,6 +510,7 @@ Makefile.in /python/stamp-extra-files /python/t/tests_helper.py /python/utils.c +/python/utils.h /qemu-wrapper.sh /rescue/stamp-virt-rescue.pod /rescue/virt-rescue diff --git a/builder/index-validate.c b/builder/index-validate.c index 224cd674a..a830ad8c6 100644 --- a/builder/index-validate.c +++ b/builder/index-validate.c @@ -31,7 +31,7 @@ #include &lt...

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 Thanks: Tomáš Golembiovský --- v2v/virt-v2v.pod | 38 ++++++++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..0943bf305 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,32 @@ that

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 --- v2v/virt-v2v.pod | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..93d1a9ecd 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,33 @@ that guest through the RHV-M UI,

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.