search for: testresulttru

Here is a preliminary fix for this bug. I'm running the test suite on this now. Rich.

...quot;; ""; ""; ""; ""; "false"]; ["read_file"; "/copyff/dest"]], "compare_buffers (ret, size, \"hello, world\", 12) == 0"), []; - let size = 1024 * 1024 in InitScratchFS, Always, TestResultTrue ( + let size = 1024 * 1024 in [["mkdir"; "/copyff2"]; ["fill"; "0"; string_of_int size; "/copyff2/src"]; ["touch"; "/copyff2/dest"]; ["truncate_size"; "/copyff2/dest&q...

...ot; }; { defaults with name = "is_lv"; added = (1, 5, 3); - style = RBool "lvflag", [Device "device"], []; + style = RBool "lvflag", [Mountable "mountable"], []; proc_nr = Some 264; tests = [ InitBasicFSonLVM, Always, TestResultTrue ( @@ -9076,9 +9076,9 @@ I<other> keys." }; InitBasicFSonLVM, Always, TestResultFalse ( [["is_lv"; "/dev/sda1"]]), [] ]; - shortdesc = "test if device is a logical volume"; + shortdesc = "test if mountable is a logical volume&...

...dir/blank-disk-1M.raw"]]), []; InitEmpty, Always, TestResultFalse ( - [["disk_has_backing_file"; "../data/blank-disk-1M.qcow2"]]), []; + [["disk_has_backing_file"; "$databuilddir/blank-disk-1M.qcow2"]]), []; InitEmpty, Always, TestResultTrue ( - [["disk_has_backing_file"; "../data/blank-disk-with-backing.qcow2"]]), []; + [["disk_has_backing_file"; "$databuilddir/blank-disk-with-backing.qcow2"]]), []; ]; shortdesc = "return whether disk has a backing file";...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

sparsify case: modified guestfs_is_lv mllib: fixed is_btrfs_subvolume Maxim Perevedentsev (3): mllib: add checking for btrfs subvolume lvm: modify guestfs_is_lv to take mountable sysprep: fix btrfs subvolume processing in fs-uuids daemon/lvm.c | 6 ++++-- generator/actions.ml | 6 +++--- mllib/common_utils.ml | 7 +++++++

...eq + (* Test prerequisites. *) and c_api_test_prereq = (* Test always runs. *) diff --git a/generator/utils.ml b/generator/utils.ml index 6eff6ad..34edf9d 100644 --- a/generator/utils.ml +++ b/generator/utils.ml @@ -266,7 +266,8 @@ let seq_of_test = function | TestResultDevice (s, _) | TestResultTrue s | TestResultFalse s - | TestLastFail s -> s + | TestLastFail s + | TestRunOrUnsupported s -> s let c_quote str = let str = replace_str str "\\" "\\\\" in -- 2.5.0

Map the HIVEX_OPEN_UNSAFE flag into the libguestfs API and use it in various places. Rich.

...<guestfs_version>. + +=back + +See also C<guestfs_filesystem_available>." }; + + { defaults with + name = "feature_available"; added = (1, 21, 26); + style = RBool "isavailable", [StringList "groups"], []; + tests = [ + InitNone, Always, TestResultTrue [["feature_available"; ""]], [] + ]; + shortdesc = "test availability of some parts of the API"; + longdesc = "\ +This is the same as C<guestfs_available>, but unlike that +call it returns a simple true/false boolean result, instead +of throwing an...

...{ defaults with name = "is_file"; added = (0, 0, 8); style = RBool "fileflag", [String (Pathname, "path")], [OBool "followsymlinks"]; + impl = OCaml "Is.is_file"; once_had_no_optargs = true; tests = [ InitISOFS, Always, TestResultTrue ( @@ -2138,6 +2139,7 @@ See also C<guestfs_stat>." }; { defaults with name = "is_dir"; added = (0, 0, 8); style = RBool "dirflag", [String (Pathname, "path")], [OBool "followsymlinks"]; + impl = OCaml "Is.is_dir"; on...

...""; ""; ""; "false"]; > ["read_file"; "/copyff/dest"]], > "compare_buffers (ret, size, \"hello, world\", 12) == 0"), []; > - let size = 1024 * 1024 in > InitScratchFS, Always, TestResultTrue ( > + let size = 1024 * 1024 in This seems unused? Or is it supposed to be used and its usage has been forgotten? > [["mkdir"; "/copyff2"]; > ["fill"; "0"; string_of_int size; "/copyff2/src"]; > [&q...

...{ defaults with name = "feature_available"; added = (1, 21, 26); - style = RBool "isavailable", [StringList "groups"], []; + style = RBool "isavailable", [StringList (PlainString, "groups")], []; tests = [ InitNone, Always, TestResultTrue [["feature_available"; ""]], [] ]; @@ -1738,7 +1738,7 @@ not normally be used by other libguestfs users." }; let daemon_functions = [ { defaults with name = "mount"; added = (0, 0, 3); - style = RErr, [Mountable "mountable"; String &quo...

Split up the huge generator/actions.ml into several smaller files. Rich.

Very large but mechanical change to the generator. Rich.

...$datadir/blank-disk-1M.raw"]]), []; InitEmpty, Always, TestResultFalse ( - [["disk_has_backing_file"; "../data/blank-disk-1M.qcow2"]]), []; + [["disk_has_backing_file"; "$datadir/blank-disk-1M.qcow2"]]), []; InitEmpty, Always, TestResultTrue ( - [["disk_has_backing_file"; "../data/blank-disk-with-backing.qcow2"]]), []; + [["disk_has_backing_file"; "$datadir/blank-disk-with-backing.qcow2"]]), []; ]; shortdesc = "return whether disk has a backing file"; longd...

...$datadir/blank-disk-1M.raw"]]), []; InitEmpty, Always, TestResultFalse ( - [["disk_has_backing_file"; "../data/blank-disk-1M.qcow2"]]), []; + [["disk_has_backing_file"; "$datadir/blank-disk-1M.qcow2"]]), []; InitEmpty, Always, TestResultTrue ( - [["disk_has_backing_file"; "../data/blank-disk-with-backing.qcow2"]]), []; + [["disk_has_backing_file"; "$datadir/blank-disk-with-backing.qcow2"]]), []; ]; shortdesc = "return whether disk has a backing file"; longd...

...use C<guestfs_mv> instead." }; { defaults with name = "is_whole_device"; added = (1, 21, 9); style = RBool "flag", [String (Device, "device")], []; + impl = OCaml "Devsparts.is_whole_device"; tests = [ InitEmpty, Always, TestResultTrue ( [["is_whole_device"; "/dev/sda"]]), []; diff --git a/generator/daemon.ml b/generator/daemon.ml index 121634806..3ffe91537 100644 --- a/generator/daemon.ml +++ b/generator/daemon.ml @@ -553,6 +553,26 @@ copy_mountable (const mountable_t *mountable) CAMLreturn (r);...

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

...uld fail, and the - * last command must return the given string or device name. - *) | TestResultString of seq * string | TestResultDevice of seq * string - - (* Run the command sequence. No command should fail, and the - * last command must return true or false. - *) | TestResultTrue of seq | TestResultFalse of seq - - (* Run the command sequence and expect the final command (only) - * to fail. - *) | TestLastFail of seq - - (* Run the command sequence and expect either nothing to fail, - * or that the last command only can fail with ENOTSUP. - *) | TestRunO...

This works reliably for me ... Rich.