search for: testig

...ld qemu might only start sending interrupts after DRIVER_OK is set. So I wanted everything completely initialized before DRIVER_OK. You patch makes sense to me since nothing can fail, and we won't get interrupts before we add inbufs. Reviewed-by: Michael S. Tsirkin <mst at redhat.com> Testig will report shortly, pls send with sob line. -- MST

...ld qemu might only start sending interrupts after DRIVER_OK is set. So I wanted everything completely initialized before DRIVER_OK. You patch makes sense to me since nothing can fail, and we won't get interrupts before we add inbufs. Reviewed-by: Michael S. Tsirkin <mst at redhat.com> Testig will report shortly, pls send with sob line. -- MST

...fter DRIVER_OK is set. > > So I wanted everything completely initialized before DRIVER_OK. > > You patch makes sense to me since nothing can fail, > and we won't get interrupts before we add inbufs. > > Reviewed-by: Michael S. Tsirkin <mst at redhat.com> > > Testig will report shortly, pls send with sob line. Sure enough, this helps: Tested-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> Pls repost as a top-level patch. > -- > MST

On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio_device_ready before using VQs. > > Signed-off-by: Michael S. Tsirkin

On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio_device_ready before using VQs. > > Signed-off-by: Michael S. Tsirkin