search for: test_utils_cflags

When valgrinding plugins, the following sequence can happen: plugin_free -> dlclose -> unloads the plugin and symbol table exit -> valgrind prints failures (the same applies to filters). When valgrind is printing the failures, it looks up the addresses in the symbol table, but that has been unloaded already so all you see are "???", resulting in useless

...e4 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -63,7 +63,8 @@ nbdkit_CPPFLAGS = \ > nbdkit_CFLAGS = \ > -pthread \ > $(WARNINGS_CFLAGS) \ > - $(GNUTLS_CFLAGS) > + $(GNUTLS_CFLAGS) \ > + $(VALGRIND_CFLAGS) Just a note that this also has to be added to test_utils_CFLAGS at the bottom of the same file, otherwise the tests fail to compile. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with ma...

...file.am index 6b9e0a9..999aeae 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -102,5 +102,7 @@ test_utils_SOURCES = \ test-utils.c \ utils.c \ cleanup.c -test_utils_CPPFLAGS = -I$(top_srcdir)/include +test_utils_CPPFLAGS = \ + -I$(top_srcdir)/include \ + -I$(top_srcdir)/common/include test_utils_CFLAGS = $(WARNINGS_CFLAGS) $(VALGRIND_CFLAGS) diff --git a/src/utils.c b/src/utils.c index 0e48d52..c9e1e14 100644 --- a/src/utils.c +++ b/src/utils.c @@ -44,20 +44,10 @@ #include <termios.h> #include <errno.h> +#include "get-current-dir-name.h" + #include "internal.h&quot...

...to.c \ debug.c \ @@ -124,9 +123,11 @@ check_PROGRAMS = test-utils test_utils_SOURCES = \ test-utils.c \ utils.c \ - cleanup.c \ extents.c test_utils_CPPFLAGS = \ -I$(top_srcdir)/include \ - -I$(top_srcdir)/common/include + -I$(top_srcdir)/common/include \ + -I$(top_srcdir)/common/utils test_utils_CFLAGS = $(WARNINGS_CFLAGS) $(VALGRIND_CFLAGS) +test_utils_LDADD = \ + $(top_builddir)/common/utils/libutils.la -- 2.20.1

...\ test-help.sh \ test-version.sh \ + test-utils \ test-dump-config.sh +check_PROGRAMS += \ + test-utils + +test_utils_SOURCES = test-utils.c \ + $(top_srcdir)/src/utils.c \ + $(top_srcdir)/src/cleanup.c \ + $(top_srcdir)/include/nbdkit-plugin.h +test_utils_CPPFLAGS = -I$(top_srcdir)/include +test_utils_CFLAGS = $(WARNINGS_CFLAGS) + if HAVE_PLUGINS TESTS += \ diff --git a/tests/test-utils.c b/tests/test-utils.c new file mode 100644 index 0000000..af08416 --- /dev/null +++ b/tests/test-utils.c @@ -0,0 +1,121 @@ +/* nbdkit + * Copyright (C) 2018 Red Hat Inc. + * All rights reserved. + * + * Redistributi...

Take two, this time split into two patches. I liked Rich's suggestion of unit-testing src/ files directly in src/, and automake is a lot happier with this than with my v1 attempt that tried to compile .c files across directories. It's still enough of a change that I'm not pushing it right away. Eric Blake (2): build: Add unit-testing of internal files utils: Revamp

...238,8 @@ noinst_PROGRAMS += libvirt-is-version libvirt_is_version_SOURCES = libvirt-is-version.c libvirt_is_version_LDADD = \ - $(LIBVIRT_LIBS) + $(LIBVIRT_LIBS) \ + $(LTLIBINTL) libvirt_is_version_CPPFLAGS = \ -DLOCALEBASEDIR=\""$(datadir)/locale"\" @@ -266,6 +267,7 @@ test_utils_CFLAGS = \ test_utils_LDADD = \ libguestfs_la-guid.lo \ libutils.la \ + $(LTLIBINTL) \ $(top_builddir)/gnulib/lib/libgnu.la check-valgrind: diff --git a/sysprep/Makefile.am b/sysprep/Makefile.am index 17fe612..58c63bb 100644 --- a/sysprep/Makefile.am +++ b/sysprep/Makefile.am @@ -136,7 +136,7 @@...

There's more that can be done (in particular, use of CLEANUP_FREE), but this is enough to at least see if I'm on the right track. I couldn't figure out an obvious difference between common/include and common/utils, but it looks like the former is for things that are inlineable via .h only, while the latter is when you need to link in a convenience library, so this landed in the

...; libvirt_is_version_SOURCES = libvirt-is-version.c > > libvirt_is_version_LDADD = \ > - $(LIBVIRT_LIBS) > + $(LIBVIRT_LIBS) \ > + $(LTLIBINTL) > > libvirt_is_version_CPPFLAGS = \ > -DLOCALEBASEDIR=\""$(datadir)/locale"\" > @@ -266,6 +267,7 @@ test_utils_CFLAGS = \ > test_utils_LDADD = \ > libguestfs_la-guid.lo \ > libutils.la \ > + $(LTLIBINTL) \ > $(top_builddir)/gnulib/lib/libgnu.la > > check-valgrind: > diff --git a/sysprep/Makefile.am b/sysprep/Makefile.am > index 17fe612..58c63bb 100644 > --- a/sysprep/Makefil...

Hi, continuing what started a couple of weeks ago [1], the attached patch series continues the work in making it easier to build and run libguestfs (in fixed appliance mode) on OSes different than Linux. The provided changes should cause no functional changes on Linux. [1] https://www.redhat.com/archives/libguestfs/2014-October/msg00176.html Thanks, -- Pino Pino Toscano (9): build: check

This is an incomplete port to Windows. Currently the server compiles and starts up successfully, but goes into an infinite loop when you connect to it. Nevertheless I think the approach is ready for feedback. This being Windows the changes go quite deep. Rich.

Add nbdkit-floppy-plugin, “inspired” by qemu's VVFAT driver, but without the ability to handle writes. The implementation is pretty complete, supporting FAT32, LFNs, volume labels, timestamps, etc, and it passes both ‘make check’ and ‘make check-valgrind’. Usage is simple; to serve the current directory: $ nbdkit floppy . Then using guestfish (or any NBD client): $ guestfish --ro

This is a major rewrite compared to my v1 series, where I've tried a lot harder to ensure that we still accommodate building on Haiku (although I have not actually yet fired up a Haiku VM to try it for myself). I also managed to make the sh plugin fully parallel, on capable platforms. See also my question on patch 10 on whether I've picked the best naming convention. Eric Blake (17):