search for: test_unit_mdct

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_unit_dft.c @@ -47,8 +47,7 @@ #if def...

--- celt/tests/test_unit_dft.c | 3 +-- celt/tests/test_unit_mathops.c | 3 +-- celt/tests/test_unit_mdct.c | 3 +-- celt/tests/test_unit_rotation.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/celt/tests/test_unit_dft.c b/celt/tests/test_unit_dft.c index bcee440..484dc57 100644 --- a/celt/tests/test_unit_dft.c +++ b/celt/tests/test_unit_dft.c @@ -47,8 +47,7 @@ #if def...

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics. --- silk/fixed/main_FIX.h | 11 +++++++++++ silk/x86/x86_silk_map.c | 2 ++ 2 files changed, 13 insertions(+) diff --git a/silk/fixed/main_FIX.h b/silk/fixed/main_FIX.h index ffeb4f3..375b5eb 100644 --- a/silk/fixed/main_FIX.h +++ b/silk/fixed/main_FIX.h @@ -97,6 +97,17 @@ void

...a known issue, but running make on revision e3187444692195957eb66989622c7b1ad8448b06 fails one of the tests when using fixed point configuration (floating point is ok) on my linux x86. Note that libopus1.1, as extracted from the tar ball, is OK. Specifically, the tests that fail are in celt/tests/test_unit_mdct: nfft=32 inverse=0,snr = 85.341197 nfft=32 inverse=1,snr = 96.285703 nfft=256 inverse=0,snr = 86.726515 nfft=256 inverse=1,snr = 87.308386 nfft=512 inverse=0,snr = 82.577935 nfft=512 inverse=1,snr = 87.103849 nfft=1024 inverse=0,snr = 84.950837 nfft=1024 inverse=1,snr = 87.105776 nfft=2048 inverse=...

...celt/arm/celt_ne10_fft.c | 2 + celt/arm/celt_ne10_mdct.c | 3 ++ celt/arm/pitch_arm.h | 2 +- celt/dump_modes/Makefile | 2 +- celt/pitch.h | 5 +-- celt/tests/test_unit_dft.c | 3 +- celt/tests/test_unit_mathops.c | 7 ++-- celt/tests/test_unit_mdct.c | 4 +- celt/tests/test_unit_rotation.c | 5 ++- configure.ac | 93 +++++++++++++++++++---------------------- 12 files changed, 67 insertions(+), 67 deletions(-) diff --git a/Makefile.am b/Makefile.am index 3a75740..8bd7447 100644 --- a/Makefile.am +++ b/Makefile.am @@ -...

Hello Jean-Marc, Yep, that was it.. with your patch, test_unit_mdct passes for all nfft. So, what you do you suggest the next step here is? Regards, Vish On 8 May 2015 at 12:30, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi, > > Can you apply this change to the MDCT test and run it again. See if more > (all) sizes pass. Given the results...

Hello Jean-Marc, Below are the results that show test_unit_dft passes, but test_unit_mdct fails (only for nfft=480, 960, 1920) Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] ./test_unit_dft nfft=32 inverse=0,snr = 88.394372 nfft=32 inverse=1,snr = 93.896470 nfft=128 inverse=0,snr = 89.185895 nfft=128 inverse=1,snr = 93.537021 nfft=256 inverse=0,snr = 88.353151 nff...

...+++ celt/arm/celt_lpc_arm.h | 65 ++++++++ celt/arm/celt_lpc_neon_intr.c | 254 ++++++++++++++++++++++++++++++++ celt/celt_lpc.h | 5 + celt/tests/test_unit_dft.c | 1 + celt/tests/test_unit_mathops.c | 1 + celt/tests/test_unit_mdct.c | 1 + celt/tests/test_unit_optimization_lpc.c | 96 ++++++++++++ celt/tests/test_unit_rotation.c | 1 + celt_headers.mk | 1 + celt_sources.mk | 1 + tests/test_unit_optimization.c | 62 ++++++++ 14 files chan...

Hi all, This is Linfeng Zhang from Google. I'll work on ARM NEON optimization in the next few months. I'm submitting 2 patches in the following couple of emails, which have the new created celt_fir_neon(). I revised celt_fir_c() to not pass in argument "mem" in Patch 1. If there are concerns to this change, please let me know. Many thanks to your comments. Linfeng Zhang

...++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) -- 1.9.1

..., but running make on revision e3187444692195957eb66989622c7b1ad8448b06 fails one of the tests when using fixed point configuration (floating point is ok) on my linux x86. > Note that libopus1.1, as extracted from the tar ball, is OK. > > Specifically, the tests that fail are in celt/tests/test_unit_mdct: > nfft=32 inverse=0,snr = 85.341197 > nfft=32 inverse=1,snr = 96.285703 > nfft=256 inverse=0,snr = 86.726515 > nfft=256 inverse=1,snr = 87.308386 > nfft=512 inverse=0,snr = 82.577935 > nfft=512 inverse=1,snr = 87.103849 > nfft=1024 inverse=0,snr = 84.950837 > nfft=1024 inve...

...++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[OPUS_ARCHMASK+1])(const kiss_fft_state...

...++ celt/celt_decoder.c | 18 ++++---- celt/celt_encoder.c | 3 +- celt/kiss_fft.c | 4 +- celt/kiss_fft.h | 13 +++++- celt/mdct.c | 5 ++- celt/mdct.h | 22 ++++++++-- celt/tests/test_unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[OPUS_ARCHMASK+1])(const kiss_fft_state...

Hi Jean-Marc, Thanks for pointing us the way. Yes it is a overflowing problem. I moved all scaling code in the front of any other operations, and test_unit_mdct passes for all sizes. I will update Ne10 right after Vish double checks it on hardware. He will repost patches with more verification later this week. Regards, Phil Wang Well, I see three questions that need to be answered at this point 1) At what value the overflow starts happening 2) What's...

...y the following files don't have copyright header: ./src/opus_compare.c ./src/mlp_data.c ./celt/tests/test_unit_dft.c ./celt/tests/test_unit_mathops.c ./celt/tests/test_unit_entropy.c ./celt/tests/test_unit_types.c ./celt/tests/test_unit_rotation.c ./celt/tests/test_unit_laplace.c ./celt/tests/test_unit_mdct.c ./celt/tests/test_unit_cwrs32.c ./autogen.sh ./win32/config.h ./tests/run_vectors.sh ./doc/build_draft.sh ./doc/build_oggdraft.sh Thanks! -- Sergey Ulanov

...0.c | 43 ++-- celt/kiss_fft.h | 4 +- celt/mdct.h | 2 +- celt/static_modes_fixed.h | 25 +++ celt/static_modes_fixed_arm_ne10.h | 388 ++++++++++++++++++++++++++++++++++ celt/tests/test_unit_dft.c | 6 +- celt/tests/test_unit_mdct.c | 4 +- celt_headers.mk | 1 + configure.ac | 2 +- 15 files changed, 570 insertions(+), 96 deletions(-) create mode 100644 celt/static_modes_fixed_arm_ne10.h diff --git a/Makefile.am b/Makefile.am index 8bd7447..7d3efb3 100644 ---...

Hello Jean-Marc, **Resending.. not sure why subject got removed earlier** Below are the results that show test_unit_dft passes, but test_unit_mdct fails (only for nfft=480, 960, 1920) Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] ./test_unit_dft nfft=32 inverse=0,snr = 88.394372 nfft=32 inverse=1,snr = 93.896470 nfft=128 inverse=0,snr = 89.185895 nfft=128 inverse=1,snr = 93.537021 nfft=256 inverse=0,snr = 88.353151 nff...

...an you apply this change to the MDCT test and run it again. See if more (all) sizes pass. Given the results, I strongly suspect an overflow. Jean-Marc On 08/05/15 01:21 PM, Viswanath Puttagunta wrote: > Hello Jean-Marc, > > Below are the results that show test_unit_dft passes, but > test_unit_mdct fails (only for nfft=480, 960, 1920) > Note: Tested on BeagleboneBlack(Cortex-A8) fixed point on branch [1] > > ./test_unit_dft > nfft=32 inverse=0,snr = 88.394372 > nfft=32 inverse=1,snr = 93.896470 > nfft=128 inverse=0,snr = 89.185895 > nfft=128 inverse=1,snr = 93.537021 &gt...

...-1.1.4' make[4]: Entering directory `/prj/avspw/karthikr/Development/BFamily/Broadcast/SDM845/Opus/opus-1.1.4 PASS: celt/tests/test_unit_types PASS: celt/tests/test_unit_mathops PASS: celt/tests/test_unit_entropy PASS: celt/tests/test_unit_laplace PASS: celt/tests/test_unit_dft PASS: celt/tests/test_unit_mdct PASS: celt/tests/test_unit_rotation PASS: celt/tests/test_unit_cwrs32 PASS: tests/test_opus_api PASS: tests/test_opus_decode ./test-driver: line 107: 36946 Segmentation fault (core dumped) "$@" > $log_file 2>&1 FAIL: tests/test_opus_encode PASS: tests/test_opus_padding ====...